Final Review: chrome.printerProvider

Saswat Panigrahi

unread,

Mar 18, 2015, 3:53:16 PM3/18/15

to apps-dev, Security Enamel, cawa...@chromium.org, vital...@chromium.org, tba...@chromium.org, Bartosz Fabianowski

Hi Folks

chrome.printerProvider proposal was made in Aug 2014. The implementation is complete, and it went to Dev channel in 42.

API proposal

Launch bug

external API spec

Thanks

Tony, Vitaly, Andrew , Saswat

Benjamin Kalman

unread,

Mar 18, 2015, 4:03:33 PM3/18/15

to Saswat Panigrahi, apps-dev, Security Enamel, cawa...@chromium.org, Vitaly Buka, Toni Barzic, Bartosz Fabianowski

Can you resolve (i.e. incorporate their feedback into your document) all the outstanding comments, and mention the changes you made here?

Toni Barzic

unread,

Mar 26, 2015, 1:59:55 PM3/26/15

to Benjamin Kalman, Saswat Panigrahi, apps-dev, Security Enamel, cawa...@chromium.org, Vitaly Buka, Bartosz Fabianowski

OK, I've updated the doc.

There were two changes from the original proposal:

1. printJob.document (argument for onPrintRequested event) type was changed from ArrayBuffer to Blob in order to handle large documents

2. printJob was added 'title' property (containing document/page title); this one's fairly fresh

Also, I still have to add permission message for the API, I hope to get that in today/tomorrow.

Thanks,

Toni

Toni Barzic

unread,

Apr 1, 2015, 3:29:12 PM4/1/15

to Benjamin Kalman, Saswat Panigrahi, apps-dev, Security Enamel, cawa...@chromium.org, Vitaly Buka, Bartosz Fabianowski

friendly ping :)

Mustafa Emre Acer

unread,

Apr 1, 2015, 7:22:00 PM4/1/15

to Toni Barzic, Benjamin Kalman, Saswat Panigrahi, apps-dev, Security Enamel, cawa...@chromium.org, Vitaly Buka, Bartosz Fabianowski, est...@chromium.org

Hi Toni,

Emily is going to take a final look from security standpoint so please wait for her approval.

Thanks!

To unsubscribe from this group and stop receiving emails from it, send an email to apps-dev+u...@chromium.org.

Benjamin Kalman

unread,

Apr 1, 2015, 8:21:26 PM4/1/15

to Mustafa Emre Acer, Toni Barzic, Saswat Panigrahi, apps-dev, Security Enamel, cawa...@chromium.org, Vitaly Buka, Bartosz Fabianowski, est...@chromium.org

Consider lgtm after the install warning question has been answered (I don't think an install warning is necessary).

Mustafa Emre Acer

unread,

Apr 2, 2015, 1:35:43 PM4/2/15

to Emily Stark, Benjamin Kalman, Toni Barzic, Saswat Panigrahi, apps-dev, Security Enamel, cawa...@chromium.org, Vitaly Buka, Bartosz Fabianowski, est...@chromium.org

Looks like I had an earlier comment about extensions polluting the printer list which is why I had proposed the install time warning. I agree it doesn't have much security benefit at this point given that the printer UI now explicitly calls out the associated extension.

On Thu, Apr 2, 2015 at 10:27 AM, Emily Stark <est...@google.com> wrote:

LGTM, modulo the install time warning question. Mustafa, do you have more context or an opinion on whether the install-time permission warning is necessary? I'm somewhat sympathetic to the idea that an install-time warning doesn't add a whole lot, since if there is any abuse it will be clearly visible in the UI which extension is responsible and it will be easy for the user to uninstall the bad extension.

Emily

Reply all

Reply to author

Forward