Unexpected APK name "_incremental" when running locally

[Glen Robertson]

Hi,

When following the instructions to build and test a sample weblayer shell app, I got a weird error message about a failure.

It turned out after some digging that the test script was looking for out/Default/apks/WebLayerShell.apk but the autoninja build was producing

out/Default/apks/WebLayerShell_incremental.apk 

It seemed to work once I renamed the output.

Could this be fixed? Or was I doing something wrong?

Thanks

-Glen

[Colin Blundell]

What are your GN args?

--
You received this message because you are subscribed to the Google Groups "weblayer-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to weblayer-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/weblayer-dev/CAPV%2BSg8_d8T6SMi9z2OQfi-2pqkhrWnZQw7T5_Yo7A%3D2Z6bqdQ%40mail.gmail.com.

[Glen Robertson]

GN args:

use_goma = true
target_os = "android"
target_cpu = "x86"
# Recommended for faster builds by
# https://chromium.googlesource.com/chromium/src/+/refs/heads/main/docs/android_build_instructions.md
incremental_install = true
is_component_build = true
is_java_debug = true
treat_warnings_as_errors = false
use_errorprone_java_compiler = false
disable_android_lint = true
system_webview_shell_package_name = "org.chromium.my_webview_shell"

aha I see incremental_install there. I must have added it some time ago. Removing incremental_install fixed the issue. Thanks!

The docs I got it from say that WebView is always built without incremental_install. Looks like that isn't the case for WebLayer. Would it be possible to make WebLayer also ignore that argument? Or perhaps just note in the "setting up your build environment" section that it doesn't work?

[Colin Blundell]

I think that if you add "never_incremental = true" here it should resolve the problem (which might well just be an impedance mismatch with the wrapper scripts, but from my POV there isn't really ROI from trying to figure out whether that is indeed the only problem and resolve it if so). Would you be up for testing (with incremental_install = true restored to your GN args) and putting up a CL if that works?

Thanks,

Colin

[Glen Robertson]

Thanks, I'll give that a try.

[Colin Blundell]

Thanks!

[Glen Robertson]

That seems to have fixed it, thanks!

I've sent you a CL to set it for everyone.

[Colin Blundell]

Thanks, Glen!