What's the proper way to fix something that will break skew test

[Min Qin]

Hi, weblayer folks

  I am wondering what's the proper way to fix something that will break the skew test? For example, a CL on master may cause a skew test in previous versions to fail, even if the CL also updates the skew test.

 Should I disable the skew test for previous versions? Or should I update the skew test for previous versions?

Thanks

Min

[Colin Blundell]

Hi Min,

Can you elaborate on the specific case? In general breaking a skew test is a signal of breaking API compatibility with older versions, so the first thing to verify is whether the change that you're considering is actually conceptually OK to make.

Thanks,

Colin

--
You received this message because you are subscribed to the Google Groups "weblayer-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to weblayer-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/weblayer-dev/CAF%2Bypm02W8vqiCEYpk968aX9b7T4vOy5f7zbkhNzsGtRSSqpOQ%40mail.gmail.com.

[Min Qin]

Here is the CL that got reverted: https://chromium-review.googlesource.com/c/chromium/src/+/2819219

The existing test will upload files under chrome's app dir, but my CL will not allow that.

[Colin Blundell]

I see, thanks. Your original CL is here, for folks following along. It looks to me that the fact that WebLayer was using the functionality that your CL disallows was just an artifact of the test setup. In that case, +Rakib Hasan can advise on the current best practice for expecting the test to fail on older client versions.

+Clark Duvall wrote that test along with the support it's testing here and can confirm one way or the other.

Thanks,

Colin

[Clark Duvall]

Just to close the loop, Rakib answered in a separate thread that you can add a test expectation in this file:

https://source.chromium.org/chromium/chromium/src/+/master:weblayer/browser/android/javatests/skew/expectations.txt;l=1