{
name: "line-break",
alias_for: "-webkit-line-break",
runtime_flag: "CSSLineBreak",
},
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CACQRE%2BR_9AeoNtjc87PonbwaM4JHzfCXzyPTbq5F8dMP5KY-og%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/758e8d1c-f4b5-4703-b197-e9f6243d5e75%40chromium.org.
Woo hoo!☆PhistucK
On Wed, Jun 28, 2017 at 9:50 AM, Alan Cutter <alanc...@chromium.org> wrote:
Thanks for bringing it to our attention that we don't list property aliases in our webexposed tests!I have created a patch to fix this: https://chromium-review.googlesource.com/c/551400
On Wednesday, 28 June 2017 00:08:41 UTC+10, Koji Ishii wrote:Hi all, a novice question.When CSSProperties.json5 has:{
name: "line-break",
alias_for: "-webkit-line-break",
runtime_flag: "CSSLineBreak",
},Should this alias be only valid when CSSLineBreak flag is set?I do not see this alias listed in LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt, but the property seems to work in M58 stable.I added this alias to import wpt tests by following crbug.com/614955 guidance, but I'm afraid that I intentionally shipped this according to a Japanese stackoverflow article and my own tests, unless I'm mistaken somewhere.From this, I'm guessing "runtime_flag" is supposed to be ignored for aliases, but experts confirmation would be appreciated.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/758e8d1c-f4b5-4703-b197-e9f6243d5e75%40chromium.org.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CABc02_%2BMD_-vPDS17H2A6sC7E7FAm2MjDE2q-KQcdC_pyBiG%2Bg%40mail.gmail.com.
I've also created a patch to prevent runtime flags from being used for aliases: https://chromium-review.googlesource.com/c/551877/
On Wed, Jun 28, 2017 at 4:59 PM PhistucK <phis...@gmail.com> wrote:
Woo hoo!☆PhistucK
On Wed, Jun 28, 2017 at 9:50 AM, Alan Cutter <alanc...@chromium.org> wrote:
Thanks for bringing it to our attention that we don't list property aliases in our webexposed tests!I have created a patch to fix this: https://chromium-review.googlesource.com/c/551400
On Wednesday, 28 June 2017 00:08:41 UTC+10, Koji Ishii wrote:Hi all, a novice question.When CSSProperties.json5 has:{
name: "line-break",
alias_for: "-webkit-line-break",
runtime_flag: "CSSLineBreak",
},Should this alias be only valid when CSSLineBreak flag is set?I do not see this alias listed in LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt, but the property seems to work in M58 stable.I added this alias to import wpt tests by following crbug.com/614955 guidance, but I'm afraid that I intentionally shipped this according to a Japanese stackoverflow article and my own tests, unless I'm mistaken somewhere.From this, I'm guessing "runtime_flag" is supposed to be ignored for aliases, but experts confirmation would be appreciated.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/758e8d1c-f4b5-4703-b197-e9f6243d5e75%40chromium.org.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
Do you have an idea of how many CSS properties were/are accidentally shipped this way?☆PhistucK
On Wed, Jun 28, 2017 at 10:22 AM, Darren Shen <sh...@chromium.org> wrote:
I've also created a patch to prevent runtime flags from being used for aliases: https://chromium-review.googlesource.com/c/551877/
On Wed, Jun 28, 2017 at 4:59 PM PhistucK <phis...@gmail.com> wrote:
Woo hoo!☆PhistucK
On Wed, Jun 28, 2017 at 9:50 AM, Alan Cutter <alanc...@chromium.org> wrote:
Thanks for bringing it to our attention that we don't list property aliases in our webexposed tests!I have created a patch to fix this: https://chromium-review.googlesource.com/c/551400
On Wednesday, 28 June 2017 00:08:41 UTC+10, Koji Ishii wrote:Hi all, a novice question.When CSSProperties.json5 has:{
name: "line-break",
alias_for: "-webkit-line-break",
runtime_flag: "CSSLineBreak",
},Should this alias be only valid when CSSLineBreak flag is set?I do not see this alias listed in LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt, but the property seems to work in M58 stable.I added this alias to import wpt tests by following crbug.com/614955 guidance, but I'm afraid that I intentionally shipped this according to a Japanese stackoverflow article and my own tests, unless I'm mistaken somewhere.From this, I'm guessing "runtime_flag" is supposed to be ignored for aliases, but experts confirmation would be appreciated.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/758e8d1c-f4b5-4703-b197-e9f6243d5e75%40chromium.org.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CABc02_%2BMD_-vPDS17H2A6sC7E7FAm2MjDE2q-KQcdC_pyBiG%2Bg%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+...@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CABc02_J3%2BpiJ56usjhPr%3DpHuqwZcxUxntzRiE9u344yx076rxQ%40mail.gmail.com.
Woo hoo!☆PhistucK
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/758e8d1c-f4b5-4703-b197-e9f6243d5e75%40chromium.org.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CABc02_%2BMD_-vPDS17H2A6sC7E7FAm2MjDE2q-KQcdC_pyBiG%2Bg%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
To post to this group, send email to styl...@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CABc02_J3%2BpiJ56usjhPr%3DpHuqwZcxUxntzRiE9u344yx076rxQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "style-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to style-dev+unsubscribe@chromium.org.
To view this discussion on the web, visit https://groups.google.com/a/chromium.org/d/msgid/style-dev/CAMO7KM8%2BFi_MnG29MbxCaheXa9duE0H3J6wNgd7p0cuHZqjkHQ%40mail.gmail.com.