Re: Requesting adding components/services/screen_ai/public/mojom to content/renderer/DEPS

[John Abd-El-Malek]

+services-dev as well

If this is going to be depended on by content, it seems like it's now a foundational service and it should move to services/screen_ai? I see one include in there to content/public/browser/browser_thread.h which isn't necessary since it runs in a separate process (BrowserThread is just for browser process).

On Wed, Feb 7, 2024 at 3:03 PM 'Abigail Klein' via content-owners <content...@chromium.org> wrote:

Hello content owners,

I would like to add components/services/screen_ai/public/mojom to content/renderer/DEPS. According to the content/DEPS:

# Content can depend on components that are:

# 1) related to the implementation of the web platform, or,

# 2) shared code between third_party/blink and content

Our use case qualifies for the first. We are using the screen ai service to annotate the accessibility tree that is provided to content public APIs. There is precedent for doing this already from the content layer: AXImageAnnotator (in content/renderer/accessibility/annotations) depends on services/image_annotation to annotate images in the accessibility tree with alt text. We're doing something similar with the screen_ai service, to annotate the accessibility tree with a "main" role.

The CL in which I'd like to propose adding the DEP is crrev.com/c/5269803. For more information about this effort, here's the design doc (for Googlers).

Thanks,

Abigail

--
You received this message because you are subscribed to the Google Groups "content-owners" group.
To unsubscribe from this group and stop receiving emails from it, send an email to content-owner...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/content-owners/CAHpW9bep83_ikEW4_9zwSRduVz%3Dk0PbCCLQP%2B5W7dJ9ArXMR6g%40mail.gmail.com.

[Colin Blundell]

On Thu, Feb 8, 2024 at 12:18 AM John Abd-El-Malek <j...@chromium.org> wrote:

+services-dev as well

If this is going to be depended on by content, it seems like it's now a foundational service and it should move to services/screen_ai?

+1

 

You received this message because you are subscribed to the Google Groups "services-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to services-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/services-dev/CALhVsw3Sr9GuSFuk6euZ4sEvTgn399dTM6wd3Chg4vtYUNjVqg%40mail.gmail.com.

[Abigail Klein]

Thanks all, uploaded https://chromium-review.googlesource.com/c/chromium/src/+/5314624 to move screen_ai from //components/services to //services.

[Abigail Klein]

+Avi Drissman for context on this move to services. John--added you as a review to https://chromium-review.googlesource.com/c/chromium/src/+/5314624; it is ready to review (all trybots passing except for ios simulator, and it shouldn't be running on ios so probably just missing an ifdef somewhere).

[Jake Comia]

Para saan bayan