PSA: Changing ownership/hierarchy of WebAppFrameToolbarView

[Marijn Kruisselbrink]

Once https://crrev.com/c/4214978 lands WebAppFrameToolbarView (the three-dot menu, extension icon, reload button, etc) as well as the title for PWA windows will no longer be a child of BrowserNonClientFrameView, but rather become a child of BrowserView itself. This should cause nearly no noticeable changes, but helps unblocking "immersive fullscreen" mode on Mac OS for PWA windows. 

Also my hope is that by doing the layout of the PWA titlebar as part of the rest of BrowserViewLayout there should be less code duplication between all the different platforms (as one example, with this change the under-development tabbed PWA mode should look and work a lot better on non-Chrome OS platforms).

I think I've tested the new implementation fairly well, but I wouldn't be surprised if I missed something, so please let me know if you see any strange rendering/behavior issues surrounding the PWA title/toolbar area, and I'll try to fix those (or worst case flip the flag back off while I figure out how to fix them).

Marijn

[Daniel Murphy]

This is big, thanks for the FYI Marijn! Adding +Hoch Hochkeppel directly as FYI, I'm guessing you (or someone) at MSFT will want to test this against your patched build to see if any of your tests reveal any problems etc :)

--
You received this message because you are subscribed to the Google Groups "pwa-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pwa-dev+u...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/pwa-dev/CA%2BOSsVY3gtcDk%3Ds8XhqsGpoBm3QFei7%2BMVUMHRPZe99yLaCpKg%40mail.gmail.com.

[Alan Cutter]

This is fantastic, you've fixed the same issue in Chrome OS that we've struggled with for a while. Thank you!