"Web" prefix in Blink public APIs

[Kentaro Hara]

Hi

Currently we are adding the "Web" prefix to all classes / enums in blink/public/{platform, web}. However, the rule is not clear for blink/public/common/. Some classes / enums have the "Web" prefix but others don't.

Do we have any guidelines for it?

What happens if we make the "Web" prefix optional for the Blink public APIs? It won't cause any confusion because the classes / enums are prefixed with "blink::".

--

Kentaro Hara, Tokyo

[Kinuko Yasuda]

My opinion has been that at least for blink/public/common things do not need to have "Web" prefix unless it has other reasons (e.g. using the prefix is easier for handling naming or concept conflicts), and kept telling people no need to do so as well.  (README.md doesn't say it should either, while I realized it's not in other public directories either)

I agree that we probably don't need to be obliged to prefix with "Web" in other blink public directories (i.e. public/{platform,web}, while for existing classes they are probably just fine as is.

--
You received this message because you are subscribed to the Google Groups "platform-architecture-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to platform-architect...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/platform-architecture-dev/CABg10jwtrpCMQaYyiEWCT9mN17M9MyweudMxaWepkGJGgEjs6g%40mail.gmail.com.

[Matt Falkenhagen]

AgreeーI tend to view the Web* clases as a target for Onion Soup, so I'd prefer to disallow or discourage it in public/common. Most of the classes don't have it. I suppose sometimes it's needed to distinguish from an existing blink:: type, like blink::InputEvent and blink::WebInputEvent.

For public/{platform,web} it may be good to keep the guideline for internal consistency. We expect these to be removed with Onion Soup, is that right?

2020年9月23日(水) 15:30 Kinuko Yasuda <kin...@chromium.org>:

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/platform-architecture-dev/CAMWgRNbHok%3DKbe_iLX21tqi5VXTjROdb1f4i9wEzmgE_z2sZBQ%40mail.gmail.com.

[Kentaro Hara]

For public/{platform,web} it may be good to keep the guideline for internal consistency. We expect these to be removed with Onion Soup, is that right?

Not entirely. Classes used by //components/ etc will remain after Onion soup.

1) Don't need to use the "Web" prefix in the Blink public APIs (including platform/, web/ and common/).

2) Leave the existing "Web" prefix as is.

sounds like a reasonable guideline to me.

--

Kentaro Hara, Tokyo

[Jeremy Roman]

common/ certainly doesn't need it. public/{platform,web}...I'd lean toward keeping it for consistency but don't feel strongly.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/platform-architecture-dev/CABg10jzJSBGX7OMrjF%3Dvtx%2B-_OW-hb6mnBKCNM310XZj%2BiOOvw%40mail.gmail.com.

[dan...@chromium.org]

On Wed, Sep 23, 2020 at 1:48 PM Jeremy Roman <jbr...@chromium.org> wrote:

common/ certainly doesn't need it. public/{platform,web}...I'd lean toward keeping it for consistency but don't feel strongly.

Similar feeling from me. It may help explain layering for code inside blink, where the namespace is shared.

 

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/platform-architecture-dev/CACuR13dz9OTASPgODBASyAy%2BQfsoB%3DF6Ax-vw0VQrqeV1VWd_w%40mail.gmail.com.

[Kentaro Hara]

Gyuyoung kindly added the guideline to blink/public/README.md. Thanks!

--

Kentaro Hara, Tokyo