Nice! I've been using this instead of git cl try now, but I find it annoying that it spews the same messages as if I was trying to commit (potentially making my reviewers panic that I'm landing unfinished code?), could we make it not output CQ messages (or at least word them differently and perhaps only mail them to the owner of the issue)?Thanks!GabOn Tue, Mar 31, 2015 at 8:54 AM Sadrul Chowdhury <sad...@chromium.org> wrote:On Mon, Mar 30, 2015 at 9:13 PM, Ravi <rmi...@chromium.org> wrote:
>
> There have been recent changes made to the COMMIT=false keyword in CQ:
> * The LGTM check is skipped if the owner of the issue is a committer.
> * The issue is no longer automatically closed after the CL goes through the
> CQ successfully (this only made sense for e2e test CLs created by
> commit-bot).
>
> The new "CQ dry run" button in Rietveld (added in chromium:467912) works
> similar to the COMMIT=false keyword, it runs all CQ verifiers including
> triggering the CQ trybots, but with the following advantages:
>
> * The username of who triggered the dry run is now saved in Rietveld. The CQ
> skips the LGTM check if the triggerer is a project committer. This makes it
> possible for a reviewer to CQ dry run the CL of an external contributor
> without having to give an LGTM first.
> * Easy way for developers to dry run their change with a few clicks instead
> of having to know about the magic COMMIT=false keyword.
> * Avoids accidental commits due to keyword misspells.
>
> This button/link is available in both Rietveld UIs. As with everything else
> this change looks and feels much better in the new UI.
>
> Next I will work on adding a new flag in "git cl upload" that sets the CQ
> dry run bit when specified.
Would it make sense to have 'git cl try' pick the same set of trybots,
or is that already the case?
Sadrul
>
>
> Thanks,
> Ravi
>
> --
> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-dev+unsubscribe@chromium.org.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
On Tuesday, March 31, 2015 at 12:10:26 PM UTC-4, Gabriel Charette wrote:Nice! I've been using this instead of git cl try now, but I find it annoying that it spews the same messages as if I was trying to commit (potentially making my reviewers panic that I'm landing unfinished code?), could we make it not output CQ messages (or at least word them differently and perhaps only mail them to the owner of the issue)?
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/68d93017-cfac-4427-a617-a1c178ee2976%40chromium.org.--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
Would it be possible to also skip the LGTM check if you have trybot access, but are not a committer? I guess that's a rare case (although I just stumbled over it) so it's probably too much work to justify...
Cheers,Toby.
> email to chromium-dev...@chromium.org.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/68d93017-cfac-4427-a617-a1c178ee2976%40chromium.org.--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
Would it be possible to also skip the LGTM check if you have trybot access, but are not a committer? I guess that's a rare case (although I just stumbled over it) so it's probably too much work to justify...
Cheers,Toby.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/68d93017-cfac-4427-a617-a1c178ee2976%40chromium.org.
Update:You can now trigger CQ dry runs from the command line when uploading patches with "git cl upload --cq-dry-run".To use the new flag please sync your depot_tools checkout past r294699.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAF%2BmdicAt5cHJxRrqzzZ6-r0bQv84YXYaDoJRZcLKVYC_-smiA%40mail.gmail.com.
On Fri, Apr 10, 2015 at 7:22 AM, Ravi Mistry <rmi...@chromium.org> wrote:Update:You can now trigger CQ dry runs from the command line when uploading patches with "git cl upload --cq-dry-run".To use the new flag please sync your depot_tools checkout past r294699.Since the default trybots are in sync with the CQ, what is the benefit to using the CQ dry run over "git cl try"?
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAF%2BmdicAt5cHJxRrqzzZ6-r0bQv84YXYaDoJRZcLKVYC_-smiA%40mail.gmail.com.
It's awesome to have this feature in the UI so you can git cl try from the webpage. But I really don't want to get emails for every CL that I am cc'd/reviewer'd on every time someone tries try bots.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAHtyhaStMd2OSjEojrgP%2BYUrUFPTuLMrAYFp7OsHjxm35EAv-g%40mail.gmail.com.
On Fri, Apr 10, 2015 at 5:27 PM, Dana Jansens <dan...@chromium.org> wrote:It's awesome to have this feature in the UI so you can git cl try from the webpage. But I really don't want to get emails for every CL that I am cc'd/reviewer'd on every time someone tries try bots.I agree that this causes spam for the cc'ed not interested in dry run results.This is tricky though, because the emails are sent by the CQ, it is difficult to filter who gets the email.If a CL non-owner requested the dry run then presumably everybody cc'ed is interested in the dry run results. If the CL owner requested it then maybe only the owner is interested. Thoughts?
On Fri, Apr 10, 2015 at 5:27 PM, Dana Jansens <dan...@chromium.org> wrote:It's awesome to have this feature in the UI so you can git cl try from the webpage. But I really don't want to get emails for every CL that I am cc'd/reviewer'd on every time someone tries try bots.I agree that this causes spam for the cc'ed not interested in dry run results.This is tricky though, because the emails are sent by the CQ, it is difficult to filter who gets the email.If a CL non-owner requested the dry run then presumably everybody cc'ed is interested in the dry run results. If the CL owner requested it then maybe only the owner is interested. Thoughts?
On Fri, Apr 10, 2015 at 2:47 PM, Ravi Mistry <rmi...@chromium.org> wrote:On Fri, Apr 10, 2015 at 5:27 PM, Dana Jansens <dan...@chromium.org> wrote:It's awesome to have this feature in the UI so you can git cl try from the webpage. But I really don't want to get emails for every CL that I am cc'd/reviewer'd on every time someone tries try bots.I agree that this causes spam for the cc'ed not interested in dry run results.This is tricky though, because the emails are sent by the CQ, it is difficult to filter who gets the email.If a CL non-owner requested the dry run then presumably everybody cc'ed is interested in the dry run results. If the CL owner requested it then maybe only the owner is interested. Thoughts?IMO at most the CL owner and the person who initiated the dry run should get an email.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAA3nRaiV7ypy0AnV7uV82Ah1Nd8osD4rawe%3DyiKt5e8Z945sCA%40mail.gmail.com.
I'm with Gab here. No mail would be good for me.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAJTZ7LJgcbgAKPGhz_sjdZ6HzqA%2BEm%2B-_-UO9HX9AHzrCHD2%2BQ%40mail.gmail.com.
I'm with Gab here. No mail would be good for me.
On Apr 13, 2015 6:51 PM, "Gabriel Charette" <g...@chromium.org> wrote:If sending no emails at all is simpler to implement, I think we should go with that. i.e., what I really want is a git cl try that is a true "pre-CQ check" (i.e., if it's green, then real CQ has nothing left to do but commit when ticked), but I don't really want emails (even as the CL owner) from this early check.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAHtyhaStMd2OSjEojrgP%2BYUrUFPTuLMrAYFp7OsHjxm35EAv-g%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAA3nRaiV7ypy0AnV7uV82Ah1Nd8osD4rawe%3DyiKt5e8Z945sCA%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAJTZ7LJgcbgAKPGhz_sjdZ6HzqA%2BEm%2B-_-UO9HX9AHzrCHD2%2BQ%40mail.gmail.com.