--On 6 June 2017 at 10:26, Trent Apted <tap...@chromium.org> wrote:git config --global pretty.mine "format:format:%C(yellow)commit %H%n%C(white)Author: %an <%ae>%nCommitDate: %ad%n%n%w(0,4,4)%B%n"git config --global alias.lg "log --abbrev-commit --date local --pretty=mine"uh, that should be,git config --global pretty.mine "format:format:%C(yellow)commit %H%n%C(white)Author: %an <%ae>%nCommitDate: %cd%n%n%w(0,4,4)%B%n"git config --global alias.lg "log --abbrev-commit --date local --pretty=mine"
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAAGrfxdk9E%2B2VGf7kJNTQuE4VUggZLxTQRSyO893sE4GHvLJzQ%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAATLsPYqy5WzF9iEKKPppZOqQofDbidQWxGeJgzygoN7Cw2tRw%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGE5NGprAV0dJ0QzVngX-%3Du53KfWSNXOCDvh%2B%3DsEzAA70FueQ%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGE5NGQL1JurqH3m3nrU%3Dk1SvEM%2BhWBpqwsaKYtai03oTPNfA%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGE5NEvEpPXDLqgMEq2VHKreW6poJR8Xk4V3QkiGSFUf9qtHQ%40mail.gmail.com.--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
So the question remains -- should git-cl make an effort to reset the Author Date on every upload, even for single-commit branches; or should git-cl respect the author's intent when the author uses "git commit --amend"?
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAAjAU%3DY1ywPqwiM07Y9XkjRABgM6tOCm_0QY1KpKZGNnfbDENA%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGE5NGvDJ4FKdbvDgOJUzrUXFFxGogDyzZ%2Bk7VPhjB-qd%2BE1Q%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAPTJ0XENaxC7NOEUhfmowNbXMyMWOdgD5YiUeU_aj2v4Ez-rWw%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAB8jPhfF%2BsCYzDuouY537u5J83dcN0mh3WAiyvgDRXrPWraGWw%40mail.gmail.com.
So from the feedback here, it seems clear that git-cl should always set the Author Date to "now" when it uploads a new patchset, no matter whether the user has been using "git commit --amend" locally or not. That makes total sense to me, and I'll file a change to have it do that soon.Some people in this thread are also expressing the opinion that the time-of-last-upload is insufficient, and that the Author Date should be set to the time of submission, the same as the Commit Date. That will not happen. As Mike Frysinger said, changing the internals of Gerrit to set the Author Date when submitting a commit is a non-starter for the rest of the git-using community.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/50e565a9-4a0a-48b2-bfaa-57529a7fd5ed%40chromium.org.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CACi5S_2tT%3D6J%2B16bQLrXEY8PXJeC9MOtZ%3Dj5k6NkJ4-xvfZV%3Dg%40mail.gmail.com.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CACi5S_2tT%3D6J%2B16bQLrXEY8PXJeC9MOtZ%3Dj5k6NkJ4-xvfZV%3Dg%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAH58R2d9EHV-QB0kCCRo6NT8eYYKKOj40%2Ba6H-xFNpPWz8O4LA%40mail.gmail.com.
Personally I care less about what git command line tools show.I'm mostly curious what code search and gittiles show. I strongly believe these should be the date that the commit made it to the branch, otherwise it's confusing when one is using these tools.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAAHOzFC6H79yQnk9cXtjt8Zi2L5wfhFZUBrY2Lb%3DwXo%2BpDa5-Q%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEoffTAxLt%2Br7auVfn8fHjYfJu6G%3D95w1ip%2B2ETRjPKWAfNrWw%40mail.gmail.com.
I'm sorry, I should've been clearer. Yes, I would only want to change gitiles for the Chromium projects, so we'd want to look for some way for this to be a per-project setting.-- Dirk
On Tue, Jun 6, 2017 at 11:18 PM, Mike Frysinger <vap...@chromium.org> wrote:
to reiterate, i don't think changing gitiles for all repos is appropriate. there are a number of projects (like all the CrOS repos) who are used to standard git behavior here, and having repos change behavior depending on the viewer is bad.-mike
On Tue, Jun 6, 2017 at 7:19 PM, Dirk Pranke <dpr...@chromium.org> wrote:
I definitely think it's reasonable to look into changing what gitiles and code search display, and we'll follow up on that.-- Dirk
On Tue, Jun 6, 2017 at 6:20 PM, Peter Kasting <pkas...@chromium.org> wrote:
On Tue, Jun 6, 2017 at 5:09 PM, John Abd-El-Malek <j...@chromium.org> wrote:Personally I care less about what git command line tools show.I'm mostly curious what code search and gittiles show. I strongly believe these should be the date that the commit made it to the branch, otherwise it's confusing when one is using these tools.This.I would be happy for us to cater to git log folks by adding some kind of alias (like "git cl log", but that feels a little weird) that shows commit rather than author dates. But I don't think we should change the underlying "author date" more than we currently do; if git cl upload sets it at upload time, that seems correct. Having "git log" display author dates rather than commit dates definitely doesn't make sense for how we manage our project, but to me the right way to fix is to try and change the tools displaying the dates to do the right thing, rather than corrupt the underlying metadata.
PK
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAAHOzFC6H79yQnk9cXtjt8Zi2L5wfhFZUBrY2Lb%3DwXo%2BpDa5-Q%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEoffTAxLt%2Br7auVfn8fHjYfJu6G%3D95w1ip%2B2ETRjPKWAfNrWw%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAEoffTA2gG46HJsOZ7ubf50Wi8eX1RAGwKyuTfG%2BDh9VOa2hCQ%40mail.gmail.com.
For folks looking for nicer log formats, depot tools already provides "git map", which prints a colorized and nicely formatted log showing all your local branches, their relationships, and (as of today) the committer date instead of the author date.It turns out all the discussion of Gitiles is moot -- on chromium.googlesource.com, the relative timestamp which it displays is already calculated relative to the committer timestamp, not the author timestamp. And when you click through to a commit, both timestamps are displayed side-by-side.
So we have log covered, and we have gitiles covered. It's worthwhile to look into changing codesearch (which does display the Author Date). Given the current state of the tooling, I see no reason to clobber the Author Date with a redundant Committer Date.Aaron
On Wed, Jun 7, 2017 at 9:09 AM Dirk Pranke <dpr...@chromium.org> wrote:
I'm sorry, I should've been clearer. Yes, I would only want to change gitiles for the Chromium projects, so we'd want to look for some way for this to be a per-project setting.-- Dirk
On Tue, Jun 6, 2017 at 11:18 PM, Mike Frysinger <vap...@chromium.org> wrote:
to reiterate, i don't think changing gitiles for all repos is appropriate. there are a number of projects (like all the CrOS repos) who are used to standard git behavior here, and having repos change behavior depending on the viewer is bad.-mike
On Tue, Jun 6, 2017 at 7:19 PM, Dirk Pranke <dpr...@chromium.org> wrote:
I definitely think it's reasonable to look into changing what gitiles and code search display, and we'll follow up on that.-- Dirk
On Tue, Jun 6, 2017 at 6:20 PM, Peter Kasting <pkas...@chromium.org> wrote:
On Tue, Jun 6, 2017 at 5:09 PM, John Abd-El-Malek <j...@chromium.org> wrote:Personally I care less about what git command line tools show.I'm mostly curious what code search and gittiles show. I strongly believe these should be the date that the commit made it to the branch, otherwise it's confusing when one is using these tools.This.I would be happy for us to cater to git log folks by adding some kind of alias (like "git cl log", but that feels a little weird) that shows commit rather than author dates. But I don't think we should change the underlying "author date" more than we currently do; if git cl upload sets it at upload time, that seems correct. Having "git log" display author dates rather than commit dates definitely doesn't make sense for how we manage our project, but to me the right way to fix is to try and change the tools displaying the dates to do the right thing, rather than corrupt the underlying metadata.
PK
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAAHOzFC6H79yQnk9cXtjt8Zi2L5wfhFZUBrY2Lb%3DwXo%2BpDa5-Q%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEoffTAxLt%2Br7auVfn8fHjYfJu6G%3D95w1ip%2B2ETRjPKWAfNrWw%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAEoffTA2gG46HJsOZ7ubf50Wi8eX1RAGwKyuTfG%2BDh9VOa2hCQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAH58R2darEEyj6_aH3_Dd3Vgtb2nqQk5aQ%2B0sC01jX%3DM0DEH4g%40mail.gmail.com.
@mgiuffrida: Try "git cl archive". It automatically removes all of the branches which are tracking CLs that have been submitted, on the assumption that you don't really need to be maintaining them anymore.
In addition, if you're a fan of the rebase workflow, "git rebase-update" will rebase all of your currently-open branches on top of origin/master, and remove any which end up with no diff (i.e. have been submitted).
Your git repo has too many branches (74/20) for this tool to work well.
Colin
--
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAAHOzFC6H79yQnk9cXtjt8Zi2L5wfhFZUBrY2Lb%3DwXo%2BpDa5-Q%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEoffTAxLt%2Br7auVfn8fHjYfJu6G%3D95w1ip%2B2ETRjPKWAfNrWw%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAEoffTA2gG46HJsOZ7ubf50Wi8eX1RAGwKyuTfG%2BDh9VOa2hCQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGE5NFqHUe_QGx96FzpLPFUqoDPo0Urq2XypQdLUm_Bqgsvqw%40mail.gmail.com.
You don't need your own git command alias. You can configure whatever you choose as the git log default by doing, for example,git config --global format.pretty "fuller"If you don't like any of gits standard format you can also do, for example,git config --global format.pretty "format:format:%C(yellow)commit %H%n%C(white)Author: %an <%ae>%nCommitDate: %ad%n%n%w(0,4,4)%B%n"
On Tue, 6 Jun 2017 at 15:38 Colin Blundell <blun...@chromium.org> wrote:Slightly more productively: I'm not suggesting that we necessarily need to go back to the behavior where Author Date and Commit Date were identical, as from the bug it sounds like that's not desired. What I'm saying is that Author Date is uninteresting (and when referenced as "Date", worse than uninteresting) from a chromium dev's perspective. Could we make it (e.g., via depot_tools) such that Commit Date is what is shown as the Date field by default when doing "git log" in a chromium checkout (and on cs.chromium.org and whatever other mainstream tooling chromium devs use)? I don't think it's sufficient to have chromium devs be able to customize their git log output to achieve that effect.Thanks,ColinOn Tue, Jun 6, 2017 at 4:31 PM Colin Blundell <blun...@chromium.org> wrote:Thanks for calling this out, Trent. I had noticed this in the past day or two but hadn't really put my finger on the reason.Apologies in advance for harping on this, as I know how hard you've been working on this transition overall, Aaron (and overall it's going great). However:This seems like a serious regression to me. For example, when I was sheriffing yesterday I was investigating a flake that was introduced in the past few days. I initially ignored what turned out to be the culprit CL because its "Date" field was May 19, whereas the flake had started June 2.It seems like if we stick with this behavior, the "Date" field in "git log" (and by extension the history in cs.chromium.org) becomes actively misleading from a chromium developer's perspective, and the best we could do is teach ourselves to ignore it (and suffer from a lack of information).Am I missing something that makes this less serious than I'm outlining above?Thanks,ColinOn Tue, Jun 6, 2017 at 11:50 AM Paweł Hajdan, Jr. <phajd...@chromium.org> wrote:+infra-dev,agableOn Tue, Jun 6, 2017 at 2:36 AM, Trent Apted <tap...@chromium.org> wrote:On 6 June 2017 at 10:26, Trent Apted <tap...@chromium.org> wrote:git config --global pretty.mine "format:format:%C(yellow)commit %H%n%C(white)Author: %an <%ae>%nCommitDate: %ad%n%n%w(0,4,4)%B%n"git config --global alias.lg "log --abbrev-commit --date local --pretty=mine"uh, that should be,git config --global pretty.mine "format:format:%C(yellow)commit %H%n%C(white)Author: %an <%ae>%nCommitDate: %cd%n%n%w(0,4,4)%B%n"git config --global alias.lg "log --abbrev-commit --date local --pretty=mine"
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAAGrfxdk9E%2B2VGf7kJNTQuE4VUggZLxTQRSyO893sE4GHvLJzQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAATLsPYqy5WzF9iEKKPppZOqQofDbidQWxGeJgzygoN7Cw2tRw%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGE5NGQL1JurqH3m3nrU%3Dk1SvEM%2BhWBpqwsaKYtai03oTPNfA%40mail.gmail.com.
On Tue, Jun 6, 2017 at 5:06 PM Anthony Berent <abe...@chromium.org> wrote:You don't need your own git command alias. You can configure whatever you choose as the git log default by doing, for example,git config --global format.pretty "fuller"If you don't like any of gits standard format you can also do, for example,git config --global format.pretty "format:format:%C(yellow)commit %H%n%C(white)Author: %an <%ae>%nCommitDate: %ad%n%n%w(0,4,4)%B%n"Just to close the loop here, the above preserves Trent's original error of using the author date instead of commit date :). Here's the command I used to get something that looks basically identical to the default of "pretty=medium" but with "Date: <author-date>" replaced by "Committed: <commit-date>":git config --global format.pretty "format:%C(yellow)commit %H%nAuthor: %an <%ae>%nCommitted: %cd%n%n%w(0,4,4)%B%n"
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGE5NGP-Wq-gx9b6S7Msa%3DtOCDHXJRU8Tj6aOzY%3Dz5KSRj2HQ%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGE5NGP-Wq-gx9b6S7Msa%3DtOCDHXJRU8Tj6aOzY%3Dz5KSRj2HQ%40mail.gmail.com.
We could probably a hook to DEPS that would set `git config --local` if it wasn't already.Thoughts?-- Dirk
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
OK, here's my latest attempt which matches --pretty=medium almost exactly, but substitutes the commited date:git config --global format.pretty 'format:%C(auto,yellow)commit %H%C(auto)%d%nAuthor: %an <%ae>%nCommitted: %cd%n%n%w(0,4,4)%B%-%n'Like --pretty=medium, this:
- Shows short ref names for commits, e.g. HEAD or my-branch
- Prints color codes ONLY when outputting to a terminal
- Has exactly one blank line after each commit's message
The only problem I've found is that when NOT outputting to a terminal (e.g., redirecting to a file), the short ref names are still included. The default format would exclude the short ref names, only showing the commit hash. There should be a workaround with --decorate but it doesn't seem to work.
Brett
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CABiGVV_9z1DVN8yBC4RecMdR6Q8i%2BLB967Qqn_gWGJAe%2BCcAyg%40mail.gmail.com.
Is even the commit date what you want? If you look at a log of master with commit dates even these are not in order. I believe the commit dates are the dates at which the commits were uploaded to Gerrit, not when they landed.
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CABdZ6yC-toQmwN2S-p4tujP6DsSGVaxu%3Dj5Vf7gLcOBTYwJKCQ%40mail.gmail.com.
Is even the commit date what you want? If you look at a log of master with commit dates even these are not in order. I believe the commit dates are the dates at which the commits were uploaded to Gerrit, not when they landed.
On Tue, Jun 13, 2017 at 5:23 PM, Anthony Berent <abe...@chromium.org> wrote:Is even the commit date what you want? If you look at a log of master with commit dates even these are not in order. I believe the commit dates are the dates at which the commits were uploaded to Gerrit, not when they landed.By default git log shows commits in: std::tie(topological order, commit date). For a project which has a strict linear history like us it just degenerates into topological order (% crossing the blink merge point, but I seriously doubt anybody git-logs that deep).That means that no matter how you touch either the commit or the author date, the order of git log won't change.
--On Tue, 13 Jun 2017 at 16:05 Nico Weber <tha...@chromium.org> wrote:On Tue, Jun 6, 2017 at 6:38 PM, Brett Wilson <bre...@chromium.org> wrote:On Tue, Jun 6, 2017 at 3:38 PM, Brett Wilson <bre...@chromium.org> wrote:On Tue, Jun 6, 2017 at 3:07 PM, Aaron Gable <aga...@chromium.org> wrote:So from the feedback here, it seems clear that git-cl should always set the Author Date to "now" when it uploads a new patchset, no matter whether the user has been using "git commit --amend" locally or not. That makes total sense to me, and I'll file a change to have it do that soon.Some people in this thread are also expressing the opinion that the time-of-last-upload is insufficient, and that the Author Date should be set to the time of submission, the same as the Commit Date. That will not happen. As Mike Frysinger said, changing the internals of Gerrit to set the Author Date when submitting a commit is a non-starter for the rest of the git-using community.Can you go into more details? Why is this a non-starter? I understand why this is inappropriate for our project, but why not have a setting for our project?I meant inappropriate for "some" projects.Was this question ever answered?I attempted to do a summary of this thread, and it sounds like several people (tapted blundell asvitkine brettw dcheng hwennborg) all feel that not having the commit date by default in `git log` is an issue. Nobody said they found this useful.Why can't we fix this? (It could be some gerrit setting or something that's off by default but on for us. That seems far preferable over a complicated thing that tries to configure git's log command to fix up the displayed data after the fact.Brett--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CABiGVV_9z1DVN8yBC4RecMdR6Q8i%2BLB967Qqn_gWGJAe%2BCcAyg%40mail.gmail.com.
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
On Tue, 13 Jun 2017 at 17:39 Primiano Tucci <prim...@chromium.org> wrote:On Tue, Jun 13, 2017 at 5:23 PM, Anthony Berent <abe...@chromium.org> wrote:Is even the commit date what you want? If you look at a log of master with commit dates even these are not in order. I believe the commit dates are the dates at which the commits were uploaded to Gerrit, not when they landed.By default git log shows commits in: std::tie(topological order, commit date). For a project which has a strict linear history like us it just degenerates into topological order (% crossing the blink merge point, but I seriously doubt anybody git-logs that deep).That means that no matter how you touch either the commit or the author date, the order of git log won't change.
I don't think anybody wants the order in the log to change. What I think people want to see in git log is the dates when the commits landed on master. This is something this is not, as far as I know, recorded at within the commits, and, I believe, hasn't been available since we stopped using SVN. To add this so we would, I think, have to change how the commit queue lands commits (although I am not sure of the details).
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CABdZ6yB7-vWVgByDhhxrvYuqbJEWgQ4nKBowcT_TX5Oym5Lk5A%40mail.gmail.com.
Ok, summary of this thread:* git log (and other things which want to act like git log, such as gitiles and codesearch) shows the Author Date by default* Chromium developers are accustomed to having their git log be in chronological order, because of an old bug in Rietveld meant that it didn't forge the Author Date to be the time of last patchset upload when it was forging the Author Name* Now that we're using Gerrit, some Chromium developers don't like the fact that their git log sometimes shows dates which are not in chronological order
* There are many "git config" commands (provided in this thread) which will make your git log show the committer date instead of the author date* depot_tools provides "git map", which shows the committer date along with other useful information* Gitiles already shows the committer date instead of the author date* A change (internal, sorry) is in flight to make codesearch show the committer date instead of the author date as well* A proposal has been floated to make Gerrit forge the author date to match the committer date.- I am opposed to this proposal because it would lose useful information,
make the chromium project even less of a canonical git project
, and take large amounts of developer effort that could be better spent elsewhere* A propsal has been floated to add a "git config --local" command to set up the appropriate log alias as a chromium DEPS hook- I don't have any strong opinion on thisSome more details to address recent emails:aberent@: yes, the commit date is what people want. This information is still available; it didn't go away with the switch away from SVN. Because chromium modifes every commit when it lands (to add the cr-commit-position and other footers), the commit date is always exactly when it was submitted. This is not necessarily true for other gerrit projects that don't modify commit messages like we do.thakis@: Gerrit offers a selection of six submission strategies. None of these are configurable -- the configuration is in choosing which strategy you want, not in configuring that strategy. So it would be a large amount of developer effort, as well as convincing the gerrit community
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CABdZ6yC-toQmwN2S-p4tujP6DsSGVaxu%3Dj5Vf7gLcOBTYwJKCQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGbLiFc4sAHwZ7FHzZNY8k6RrnimsMczArE%2Bk4NmUc5Jy0JXw%40mail.gmail.com.
I think having a linear history is extremely rare. Virtually no standard git tooling or workflows even make this something you can easily do - gerrit's support for server-side cherrypicking of completed code reviews is the only mechanism I know that even makes this realistic and even most gerrit based projects I'm aware of don't use this option or don't enforce this being the sole way to commit (and still permit pushing normally, or merging by other mechanisms).
thakis@: Gerrit offers a selection of six submission strategies. None of these are configurable -- the configuration is in choosing which strategy you want, not in configuring that strategy. So it would be a large amount of developer effort, as well as convincing the gerrit community that they should accept such additional complexity, in order to make them configurable to forge the author date. Gerrit also offers an API to intercept changes during submission, but the API only lets you modify the commit message, not other commit metadata. So again, changing that would take a large amount of developer effort.
Ok, summary of this thread:* git log (and other things which want to act like git log, such as gitiles and codesearch) shows the Author Date by default
* Chromium developers are accustomed to having their git log be in chronological order, because of an old bug in Rietveld meant that it didn't forge the Author Date to be the time of last patchset upload when it was forging the Author Name
* Now that we're using Gerrit, some Chromium developers don't like the fact that their git log sometimes shows dates which are not in chronological order
* There are many "git config" commands (provided in this thread) which will make your git log show the committer date instead of the author date
* depot_tools provides "git map", which shows the committer date along with other useful information
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2dqQLBKv%2BsdiYgfDCRrD8yYUZiMQ4w7m9tNEU-66YBzPQ%40mail.gmail.com.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CABdZ6yC-toQmwN2S-p4tujP6DsSGVaxu%3Dj5Vf7gLcOBTYwJKCQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2dqQLBKv%2BsdiYgfDCRrD8yYUZiMQ4w7m9tNEU-66YBzPQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CACi5S_1zOoEo6Ld11v2mXwHJX9a7%2BvuqDfqMq8WqNFWcybsB8w%40mail.gmail.com.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CABdZ6yC-toQmwN2S-p4tujP6DsSGVaxu%3Dj5Vf7gLcOBTYwJKCQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAMGbLiFc4sAHwZ7FHzZNY8k6RrnimsMczArE%2Bk4NmUc5Jy0JXw%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEV-rjeaD%3D264e9-%3D8N720pqkmGqvbv8zvjQdmdv%2B3mSh5Jx%3DA%40mail.gmail.com.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CABdZ6yC-toQmwN2S-p4tujP6DsSGVaxu%3Dj5Vf7gLcOBTYwJKCQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2dqQLBKv%2BsdiYgfDCRrD8yYUZiMQ4w7m9tNEU-66YBzPQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CABdZ6yC-toQmwN2S-p4tujP6DsSGVaxu%3Dj5Vf7gLcOBTYwJKCQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2dqQLBKv%2BsdiYgfDCRrD8yYUZiMQ4w7m9tNEU-66YBzPQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CACi5S_1zOoEo6Ld11v2mXwHJX9a7%2BvuqDfqMq8WqNFWcybsB8w%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGE5NHeo5xWa1MRJP58TFUdEU0ugwbWCM1i2WkY03r9Ha59bg%40mail.gmail.com.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CABdZ6yC-toQmwN2S-p4tujP6DsSGVaxu%3Dj5Vf7gLcOBTYwJKCQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2dqQLBKv%2BsdiYgfDCRrD8yYUZiMQ4w7m9tNEU-66YBzPQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CACi5S_1zOoEo6Ld11v2mXwHJX9a7%2BvuqDfqMq8WqNFWcybsB8w%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGE5NHeo5xWa1MRJP58TFUdEU0ugwbWCM1i2WkY03r9Ha59bg%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAPSmAAQuBC6kGwp%2BoDEhaS2LnvtxBzPN2RE64LBtXj7h1yr2RA%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGE5NHOoNTwU_apAoC%3Dr6ZvjB8hdvgegCY2TL84xEG_KY5cNw%40mail.gmail.com.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CABdZ6yC-toQmwN2S-p4tujP6DsSGVaxu%3Dj5Vf7gLcOBTYwJKCQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2dqQLBKv%2BsdiYgfDCRrD8yYUZiMQ4w7m9tNEU-66YBzPQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CACi5S_1zOoEo6Ld11v2mXwHJX9a7%2BvuqDfqMq8WqNFWcybsB8w%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
--To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGE5NHeo5xWa1MRJP58TFUdEU0ugwbWCM1i2WkY03r9Ha59bg%40mail.gmail.com.
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAPSmAAQuBC6kGwp%2BoDEhaS2LnvtxBzPN2RE64LBtXj7h1yr2RA%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CABdZ6yC-toQmwN2S-p4tujP6DsSGVaxu%3Dj5Vf7gLcOBTYwJKCQ%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2dqQLBKv%2BsdiYgfDCRrD8yYUZiMQ4w7m9tNEU-66YBzPQ%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CACi5S_1zOoEo6Ld11v2mXwHJX9a7%2BvuqDfqMq8WqNFWcybsB8w%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
--To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGE5NHeo5xWa1MRJP58TFUdEU0ugwbWCM1i2WkY03r9Ha59bg%40mail.gmail.com.
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAPSmAAQuBC6kGwp%2BoDEhaS2LnvtxBzPN2RE64LBtXj7h1yr2RA%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGE5NHOoNTwU_apAoC%3Dr6ZvjB8hdvgegCY2TL84xEG_KY5cNw%40mail.gmail.com.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAH58R2eqiAT4Zt-16A3Em3mJQKFqt8Wd3ovXKL3yLdb%2B%2BwPdow%40mail.gmail.com.