Re: [chromium-dev] How should we work on Mac 10.6 test failures?

7 views
Skip to first unread message

Paweł Hajdan, Jr.

unread,
Nov 26, 2014, 5:16:07 AM11/26/14
to trc...@chromium.org, infr...@chromium.org, hackability-cy, Chromium-dev
+infra-dev,hackability-cy

This is a very good point.


It'd be great to align our infrastructure, at least the tryserver with main waterfall.

What's the version of OSX that we could pick? 10.9?

Paweł

On Wed, Nov 26, 2014 at 3:47 AM, Tien-Ren Chen <trc...@chromium.org> wrote:
Hello Chromium,

Recently I have submitted a Blink CL that is soon reverted by the
sheriff because the CL caused a few layout tests to fail on Mac 10.6.
I fully understand it is nothing personal and the sheriff need to do
his best to fix the tree.

However it is still very frustrating because the commit queue doesn't
run Mac 10.6, and there is no Mac 10.6 try-bots. Basically what I felt
is that I'm being forced to fix something I can't test locally, and
the only way I could test it is to submit it and hope the tree won't
turn red. This is pretty bad because 1. it wastes everybody's time if
the tree closes because of it, and 2. it wastes my time to wait for
the commit queue, getting reverted, and having to rebase again.

Am I missing something here? Is there a secret Mac 10.6 try-bot that
is not on the list which I can make use of? I've tried to setup a
virtual machine, but it is way too slow. Compiling in the virtual
machine takes hours, and it takes another few hours to run all the
layout tests. Between the few hours, more changes come in and I will
have to rebase and repeat everything endlessly. What do people do in
this situation?

Thanks for any suggestion!

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
    http://groups.google.com/a/chromium.org/group/chromium-dev

Trent Apted

unread,
Nov 26, 2014, 7:51:02 AM11/26/14
to Paweł Hajdan, Jr., trc...@chromium.org, infr...@chromium.org, hackability-cy, Chromium-dev
Chrome currently supports Snow Leopard / 10.6, so, generally speaking, stuff needs to work there. Official builds are still linked against the 10.6 SDK.

Apple's support for Snow Leopard (e.g. w.r.t. security updates) is uncertain, so I can understand why we don't offer public-facing bots for tryjobs.

I'm doing a ton of Mac development, so to answer "What do people do in this situation?" I have a "spare" macbook that just runs Snow Leopard (and takes many hours to produce a build from scratch). I appreciate that this isn't a reasonable solution for everyone. If you have a VM working, you should be able to ship a build linked against the 10.6 SDK to it, and focus on the failing tests with --gtest_filter. But, still, getting a 10.6 SDK isn't straightforward - it is another pain point.

On the chrome side, if it's a feature that can't run on Snow Leopard (e.g. fullscreen comes up a lot), there is OS version detection in base/mac/mac_util.h that can disable it. (And, if disabled properly, a test can just return early if the OS version is too old). I'm not sure if there's something similar for Blink (User Agent? #blinkn00b).

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAATLsPbMqtZ8mJS-5%3DVL64UYPsj72i_soqRu7KVBd4X3_mEGPA%40mail.gmail.com.

Marc-Antoine Ruel

unread,
Nov 26, 2014, 9:13:01 AM11/26/14
to Trent Apted, Paweł Hajdan, Jr., trc...@chromium.org, infr...@chromium.org, hackability-cy, Chromium-dev
The long term answer is to run the test on Swarming. In practice layout tests are not isolated yet and won't be for probably at least one quarter. We're planning improvements to make this possible.

M-A 

Robert Sesek

unread,
Nov 26, 2014, 10:43:09 AM11/26/14
to Trent Apted, Paweł Hajdan, Jr., trc...@chromium.org, infr...@chromium.org, hackability-cy, Chromium-dev

On Wed, Nov 26, 2014 at 7:50 AM, Trent Apted <tap...@chromium.org> wrote:
I'm doing a ton of Mac development, so to answer "What do people do in this situation?" I have a "spare" macbook that just runs Snow Leopard (and takes many hours to produce a build from scratch). I appreciate that this isn't a reasonable solution for everyone. If you have a VM working, you should be able to ship a build linked against the 10.6 SDK to it, and focus on the failing tests with --gtest_filter. But, still, getting a 10.6 SDK isn't straightforward - it is another pain point.

A dedicated machine is my answer, too. You can avoid having to build on the slow machine/VM, though! What I do is build on my powerful 10.9 Mac Pro, and then I use directly-connected ethernet between my old 10.6 machine and my 10.9 machine. All you have to do is enable file sharing (over AFP because 10.6's SMB support isn't great) and connect to the 169.254.xx.xx address. You can then run your build products on 10.6. Similarly, you could build on your main machine and then use a shared folder with the VM.

If you need the 10.6 SDK, you can get it from http://go/mac-10.6-sdk.

rsesek / @chromium.org
Reply all
Reply to author
Forward
0 new messages