PSA: gclient syntax and schema validation enabled by default (reland #1)

[Paweł Hajdan, Jr.]

With https://chromium-review.googlesource.com/c/517950 syntax and validation for gclient DEPS files is enabled by default.

If you see any errors, please pass --disable-syntax-validation to gclient as an escape hatch, and make sure to report them.

If you need to revert above CL, note the revert may also need to be rolled into tools/build repo (see https://chromium-review.googlesource.com/c/518147/).

All known issues have been fixed in https://chromium-review.googlesource.com/c/512724/ .

This is part of the effort to support conditionals and internal dependencies in gclient. Also see https://goto.google.com/fyuix for some internal announcements.

Paweł

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAATLsPZXgzj%3DYU1rP8r4%2ByHQQ28oKH0_aEwB_P3Ov91QU12KQw%40mail.gmail.com.

[Scott Violet]

Are there plans to make 'git cl format' automatically fix up what it can? My question isn't specific to DEPS file, but other file formats we have that trigger validation checks. For example, if I have a trailing ',' in a json file it would be great if 'git cl format' fixed it up for me.

  -Scott

On Mon, May 29, 2017 at 8:05 AM, Paweł Hajdan, Jr. <phajd...@chromium.org> wrote:

With https://chromium-review.googlesource.com/c/517950 syntax and validation for gclient DEPS files is enabled by default.

If you see any errors, please pass --disable-syntax-validation to gclient as an escape hatch, and make sure to report them.

If you need to revert above CL, note the revert may also need to be rolled into tools/build repo (see https://chromium-review.googlesource.com/c/518147/).

All known issues have been fixed in https://chromium-review.googlesource.com/c/512724/ .

This is part of the effort to support conditionals and internal dependencies in gclient. Also see https://goto.google.com/fyuix for some internal announcements.

Paweł

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.

To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAATLsPZXgzj%3DYU1rP8r4%2ByHQQ28oKH0_aEwB_P3Ov91QU12KQw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAATLsPZXgzj%3DYU1rP8r4%2ByHQQ28oKH0_aEwB_P3Ov91QU12KQw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAKARY_mDKWCJnEH8_zbuP01yCP2qXQpN2h3rH7k%2BPsetW-zuvQ%40mail.gmail.com.

[Paweł Hajdan, Jr.]

[bcc: infra-announce, +infra-dev]

On Mon, May 29, 2017 at 10:00 PM, Scott Violet <s...@chromium.org> wrote:

Are there plans to make 'git cl format' automatically fix up what it can? My question isn't specific to DEPS file, but other file formats we have that trigger validation checks. For example, if I have a trailing ',' in a json file it would be great if 'git cl format' fixed it up for me.

For the side question about fixing other files, I wonder what others think.

For DEPS, I don't think we can have automated fixers, but if anyone has ideas/suggestions, just let me know.

Paweł

On Mon, May 29, 2017 at 8:05 AM, Paweł Hajdan, Jr. <phajd...@chromium.org> wrote:

With https://chromium-review.googlesource.com/c/517950 syntax and validation for gclient DEPS files is enabled by default.

If you see any errors, please pass --disable-syntax-validation to gclient as an escape hatch, and make sure to report them.

If you need to revert above CL, note the revert may also need to be rolled into tools/build repo (see https://chromium-review.googlesource.com/c/518147/).

All known issues have been fixed in https://chromium-review.googlesource.com/c/512724/ .

This is part of the effort to support conditionals and internal dependencies in gclient. Also see https://goto.google.com/fyuix for some internal announcements.

Paweł

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.
To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAATLsPZXgzj%3DYU1rP8r4%2ByHQQ28oKH0_aEwB_P3Ov91QU12KQw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAATLsPZXgzj%3DYU1rP8r4%2ByHQQ28oKH0_aEwB_P3Ov91QU12KQw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAATLsPY9fDZJqg0R6AsJUU6p8f_TMO%3DXLZWzaW_2CbMw%2BUhN1w%40mail.gmail.com.

[Harisha Navilarekallu]

Hi Pawel,

When DEPS file has 'recursion = 2', returns error from gclient_eval.
Yes --disable-syntax-validation works


-Hari

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/1ff75412-9fbe-4523-a395-9178deb0bf2f%40chromium.org.

[Dirk Pranke]

Hi Harisha,

We tried to stamp out uses of `recursion = X` a while ago, but I'm guessing your usage isn't in our repos :).

In general, we want people to use `recursedeps` instead; is that something you can do? If not, please file a bug

and we can follow up off-thread.

-- Dirk

On Wed, May 31, 2017 at 9:50 PM, Harisha Navilarekallu <hnav...@cisco.com> wrote:

Hi Pawel,

When DEPS file has 'recursion = 2', returns error from gclient_eval.
Yes --disable-syntax-validation works


-Hari




On Monday, May 29, 2017 at 8:36:43 PM UTC+5:30, Paweł Hajdan, Jr. wrote:

With https://chromium-review.googlesource.com/c/517950 syntax and validation for gclient DEPS files is enabled by default.

If you see any errors, please pass --disable-syntax-validation to gclient as an escape hatch, and make sure to report them.

If you need to revert above CL, note the revert may also need to be rolled into tools/build repo (see https://chromium-review.googlesource.com/c/518147/).

All known issues have been fixed in https://chromium-review.googlesource.com/c/512724/ .

This is part of the effort to support conditionals and internal dependencies in gclient. Also see https://goto.google.com/fyuix for some internal announcements.

Paweł

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAATLsPZXgzj%3DYU1rP8r4%2ByHQQ28oKH0_aEwB_P3Ov91QU12KQw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.

To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/1ff75412-9fbe-4523-a395-9178deb0bf2f%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/1ff75412-9fbe-4523-a395-9178deb0bf2f%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAEoffTBV3N9Wja4PNF%3DojwY5RRgRSTAQE1VyXxc0anE9c-e1KA%40mail.gmail.com.

[Dirk Pranke]

On Tue, May 30, 2017 at 3:48 AM, Paweł Hajdan, Jr. <phajd...@chromium.org> wrote:

[bcc: infra-announce, +infra-dev]

On Mon, May 29, 2017 at 10:00 PM, Scott Violet <s...@chromium.org> wrote:

Are there plans to make 'git cl format' automatically fix up what it can? My question isn't specific to DEPS file, but other file formats we have that trigger validation checks. For example, if I have a trailing ',' in a json file it would be great if 'git cl format' fixed it up for me.

For the side question about fixing other files, I wonder what others think.

I am generally in favor of auto-formatting everything we can, but we don't have any active plans to do so.

 

For DEPS, I don't think we can have automated fixers, but if anyone has ideas/suggestions, just let me know.

I don't know why DEPS would be any different than anything else (once we are enforcing a stricter syntax, at least), but I guess that's a different way of saying that I don't know what common errors we might want to auto-fix.

-- Dirk

 

Paweł

On Mon, May 29, 2017 at 8:05 AM, Paweł Hajdan, Jr. <phajd...@chromium.org> wrote:

With https://chromium-review.googlesource.com/c/517950 syntax and validation for gclient DEPS files is enabled by default.

If you see any errors, please pass --disable-syntax-validation to gclient as an escape hatch, and make sure to report them.

If you need to revert above CL, note the revert may also need to be rolled into tools/build repo (see https://chromium-review.googlesource.com/c/518147/).

All known issues have been fixed in https://chromium-review.googlesource.com/c/512724/ .

This is part of the effort to support conditionals and internal dependencies in gclient. Also see https://goto.google.com/fyuix for some internal announcements.

Paweł

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.
To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAATLsPZXgzj%3DYU1rP8r4%2ByHQQ28oKH0_aEwB_P3Ov91QU12KQw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAATLsPZXgzj%3DYU1rP8r4%2ByHQQ28oKH0_aEwB_P3Ov91QU12KQw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAATLsPY9fDZJqg0R6AsJUU6p8f_TMO%3DXLZWzaW_2CbMw%2BUhN1w%40mail.gmail.com.

[hnav...@cisco.com]

Hi Dirk,

Yes, I can use recusredeps .
I did not see that recursion was getting out, also gclient_test still has recursion test.

One more thing what i saw is when I try to sync chromium-src (58-stable version) with gclient sync , it gave error in  skia for "import os",  & i see that there already bug raised (id=728358).

Thanks for the help.

Regads
Hari

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/1ff75412-9fbe-4523-a395-9178deb0bf2f%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.

To post to this group, send email to infr...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/1ff75412-9fbe-4523-a395-9178deb0bf2f%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/3daec790-8b8e-4d52-aaf7-a5f5480a2665%40chromium.org.

[Paweł Hajdan, Jr.]

[bcc:infra-announce]

FYI, the bug referenced above (https://bugs.chromium.org/p/chromium/issues/detail?id=728358) is now closed.

Paweł

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.

To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/3daec790-8b8e-4d52-aaf7-a5f5480a2665%40chromium.org.

--

You received this message because you are subscribed to the Google Groups "infra-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.

To post to this group, send email to infr...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/3daec790-8b8e-4d52-aaf7-a5f5480a2665%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAATLsPa8K_F17AM6jtXvJYVD-ZJJp7bzaSC6aH%2B6-hE4Hvc0yA%40mail.gmail.com.