PSA: gclient about to throw errors if deps_os override deps

3 views
Skip to first unread message

Paweł Hajdan, Jr.

unread,
Jun 14, 2017, 4:16:58 AM6/14/17
to infra-a...@chromium.org
I intend to land https://chromium-review.googlesource.com/c/531029/ which makes gclient throw errors if deps_os override any entries in deps.

Please speak up if you have questions or concerns. The change will not be landed if we detect a known issue, and it will be reverted if it causes any breakage.

Paweł

Paweł Hajdan, Jr.

unread,
Jun 14, 2017, 7:35:39 AM6/14/17
to infra-a...@chromium.org
Also note https://groups.google.com/a/chromium.org/d/msg/infra-dev/1wrIbQc2U2A/Vd8wkROhAAAJ by Dirk.

I'll probably wait a bit longer to give everyone a chance to read and respond.

Paweł

Paweł Hajdan, Jr.

unread,
Jun 19, 2017, 9:52:13 AM6/19/17
to infra-a...@chromium.org
The change has now landed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/66945379c69dca334b61ebb4728b4a6ee95fde79

It's safe to revert if you see any issues.

If in doubt, feel free to ping me on IM (phajdan) or irc (phajdan-jr).

Paweł
Reply all
Reply to author
Forward
0 new messages