PSA: conditionals in chromium/src/DEPS

[Paweł Hajdan, Jr.]

Chromium Denizens,

With recent changes (#1, #2), chromium/src/DEPS no longer uses deps_os or hooks_os. All entries have been moved to deps and hooks respectively, and are using conditionals (design doc).

The conditionals follow a subset of python syntax, and the following predefined variables are available:

• checkout_android (bool)

• checkout_fuchsia (bool)

• checkout_ios (bool)

• checkout_linux (bool)

• checkout_mac (bool)

• checkout_win (bool)

• host_os (str; one of “linux”, “mac”, “win” - see CL)

Please keeps deps entries sorted.

Feel free to send feedback or questions.

Paweł

[nedn...@google.com]

We currently run fetch_telemetry_binary_dependencies conditionally through https://cs.chromium.org/chromium/src/tools/perf/conditionally_execute wrapper that allows running script only if the GYP environment variable contains certain string. (example)

Do you think it's in scope of the new system to also cover this case? 

[Paweł Hajdan, Jr.]

+infra-dev, bcc:infra-announce

Thanks for bringing this up.

Yes, it's in scope to convert all references to GYP_DEFINES to gclient variables.

Paweł

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.
To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/0776831f-647d-405f-81ec-7392415da4a3%40chromium.org.

[Dirk Pranke]

On Thu, Oct 5, 2017 at 5:29 AM, nednguyen via infra-announce <infra-a...@chromium.org> wrote:

We currently run fetch_telemetry_binary_dependencies conditionally through https://cs.chromium.org/chromium/src/tools/perf/conditionally_execute wrapper that allows running script only if the GYP environment variable contains certain string. (example)

Do you think it's in scope of the new system to also cover this case? 

Yes, definitely. I can follow up with you off-thread.

-- Dirk

 

On Tuesday, October 3, 2017 at 4:25:10 AM UTC-4, Paweł Hajdan, Jr. wrote:

Chromium Denizens,

With recent changes (#1, #2), chromium/src/DEPS no longer uses deps_os or hooks_os. All entries have been moved to deps and hooks respectively, and are using conditionals (design doc).

The conditionals follow a subset of python syntax, and the following predefined variables are available:

• checkout_android (bool)

• checkout_fuchsia (bool)

• checkout_ios (bool)

• checkout_linux (bool)

• checkout_mac (bool)

• checkout_win (bool)

• host_os (str; one of “linux”, “mac”, “win” - see CL)

Please keeps deps entries sorted.

Feel free to send feedback or questions.

Paweł

--

You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/0776831f-647d-405f-81ec-7392415da4a3%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/0776831f-647d-405f-81ec-7392415da4a3%40chromium.org.