PSA: Updating our copyright header

[Avi Drissman]

Howdy, folks.

The lawyers have reached out and asked us to update the copyright headers that we use in our files, so we will be doing so. This will be a churn, but given that no one should be touching those anyway, there should be no conflicts.

While the text is a bit different:

// Copyright [year] The [Chromium|ChromiumOS] Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

The rules remain the same:

- When creating a new file, use the current year in this header.

- When modifying a file, do not modify the header.

No specific action is required on your part other than to use the new header format.

Avi

[Anthony Vallee-Dubois]

Hi Avi,

The presubmit check on git cl upload seems unaware of this change:

Note that I generated these files with tools/boilerplate.py (which *has* been updated) so their license is:

// Copyright 2022 The Chromium Authors.

// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

Is this a known issue? Should this presubmit check be skipped to land the newer license or should the old license be landed until the presubmit check is changed?

Thanks,

Anthony

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CACWgwAaJLXFNk3wa3s9-LRh7o46WOhO3gYSMnMRthEkyB7cRuA%40mail.gmail.com.

[Erik Anderson]

The issue appears to be the trailing period at the end of the first line in tools/boilerplate.py which doesn’t match the expected format/regex.

 

From: Anthony Vallee-Dubois <anth...@chromium.org>
Sent: Wednesday, September 7, 2022 4:18 PM
To: a...@google.com
Cc: Chromium-dev <chromi...@chromium.org>; Chromium Embedders <embedd...@chromium.org>
Subject: [embedder-dev] Re: [chromium-dev] PSA: Updating our copyright header

 

You don't often get email from anth...@chromium.org. Learn why this is important

Hi Avi,

 

The presubmit check on git cl upload seems unaware of this change:

 

--
You received this message because you are subscribed to the Google Groups "Chromium Embedders" group.
To unsubscribe from this group and stop receiving emails from it, send an email to embedder-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/embedder-dev/CAAyTkm%3D4RKE1pexVYP0OArAGw4166jjxpAx-5Phf_RqGqXCCig%40mail.gmail.com.

[Mark Mentovai]

Anthony Vallee-Dubois wrote:

Hi Avi,

The presubmit check on git cl upload seems unaware of this change:

Note that I generated these files with tools/boilerplate.py (which *has* been updated) so their license is:

boilerplate.py was updated to an interim boilerplate that was later shortened by one character upon receipt of the most current advice from lawyers:

// Copyright 2022 The Chromium Authors.

There’s an errant period at the end of that line that needs to be removed.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAAyTkm%3D4RKE1pexVYP0OArAGw4166jjxpAx-5Phf_RqGqXCCig%40mail.gmail.com.

[Avi Drissman]

The phrasing of the copyright header is above my pay grade, sorry.

Re tools/boilerplate.py, you are correct in that it is not generating the correct header. I will get to that tomorrow.

On Wed, Sep 7, 2022 at 7:56 PM guest271314 <guest...@gmail.com> wrote:

Some Chromium source code from 2013 has that preamble, some source code from 2015 does not.

Suggestion: Include full path (link) to LICENSE file in parentheses adjacent to below

// found in the LICENSE file (https://source.chromium.org/chromium/chromium/src/+/main:LICENSE).

I used some Chromium source code in a project a few days ago. I included the LICENSE in comments above the section cotaining the specific Chromium source code used.

It would be helpful to have the direct link to the primary reference in the document, updated to the current full path if necessary, programmatically.

[Fergal Daly]

CQ android-binary-size is failing because ". All rights reserved." is missing.

https://ci.chromium.org/ui/p/chromium/builders/try/android-binary-size/1226172/overview android-binary-size   

F

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CACWgwAa2-x5ON2W2HDXCeuu8MsEACcXo5dUAGgyBJN0Oesxamw%40mail.gmail.com.

[Daniel Cheng]

Those failures should be fixed now. There were three CLs that were reverted over 3-4 hours; unfortunately, it seems like the failing step would only produce one error at a time, so it took a bit of time to sort out.

Daniel

You received this message because you are subscribed to the Google Groups "Chromium Embedders" group.
To unsubscribe from this group and stop receiving emails from it, send an email to embedder-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/embedder-dev/CAAozHL%3DSichWROAjKDGb7aq5ap%3D08871EuYvpv_eaXehEy9KhQ%40mail.gmail.com.

[Avi Drissman]

Apologies. It turns out that altering a comment is not as innocuous as I assumed it would be. I now know what went wrong and hope to resume tomorrow. 

[dan...@chromium.org]

On Thu, Sep 8, 2022 at 12:25 PM guest271314 <guest...@gmail.com> wrote:

Some of Chromium source code has that preamble, some Chromium source code from 2015 does not.

Suggestion: 

Include full path to the LICENSE file in paratheses adjacent to what the lawyers advised at close of sentence 

    // found in the LICENSE file (https://source.chromium.org/chromium/chromium/src/+/main:LICENSE).

I included the license above some Chromium source code in a project a few days ago.

It will be helpful for canonical link to the license in each source code file as described above, for expediency.

We should follow the text specified by the lawyers without modification.

 

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHk1GDzmXqL3Oc4RfAbiSR--fM89huR0123wvuSpwpzzR8sfPw%40mail.gmail.com.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CA%2BsyWAO7gw9UHaAywS3sYDyevgM2PFOFTnAw49OGSNNOc%3DExnw%40mail.gmail.com.

[K. Moon]

s/should/must/ :-)

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHtyhaSiLG6Arh250WpkXC0uM8NM7nsjTPO7%2BbcGZe6Psg-oTw%40mail.gmail.com.

[Avi Drissman]

Indeed, lawyers gonna lawyer. I am not qualified to opine on legal issues, so I'm going to do exactly what they say.

Some followup:

- The boilerplate script is now updated. Thanks!

- The lack of period strikes me personally as weird too, but we did ask the lawyers about it, and they declared that it was standard practice.

Avi

[Lei Zhang]

Are other projects in the Chromium-sphere going to do similar updates?
ANGLE/Dawn/PDFium/Skia/V8, etc.

[Avi Drissman]

I will inquire.

[Avi Drissman]

The lawyer says that the changes in adjusting the copyright headers of Chromium and ChromiumOS are the same guidance that it would be appropriate for all the associated open-source projects to follow.

To the question of are they going to do that update, I don't know. It would be best if the owners of those projects took on this change. I can relay guidance.

Avi

On Fri, Sep 9, 2022 at 8:22 PM Lei Zhang <the...@chromium.org> wrote: