Usage of "// static" comment before definitions of static member functions

[Tim Judkins]

This is a pattern I see very commonly in Chromium, but I don't see any specific guidance on it either in https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md or https://google.github.io/styleguide/cppguide.html

Do people have strong opinions and if so should we add explicit guidance?

[Peter Kasting]

My only opinion is that we should not add guidance.

PK

On Wed, Apr 27, 2022, 4:29 PM 'Tim Judkins' via cxx <c...@chromium.org> wrote:

This is a pattern I see very commonly in Chromium, but I don't see any specific guidance on it either in https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md or https://google.github.io/styleguide/cppguide.html

Do people have strong opinions and if so should we add explicit guidance?

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CALC37Vcv9m8JNnNp840H1R7EDeaQS3%3DTeFh8pgmUTxwWLRTsrw%40mail.gmail.com.

[Ryan Hamilton]

FWIW: there is google-internal (sorry! :<) advice against this convention in go/c-readability-advice#static-comments.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAAHOzFA1T2UBaadxn6-x54r4-YA3%2BEEqtdRDi%3DjstjbD%2BxiuOQ%40mail.gmail.com.

[dan...@chromium.org]

On Wed, Apr 27, 2022 at 7:52 PM Ryan Hamilton <r...@chromium.org> wrote:

FWIW: there is google-internal (sorry! :<) advice against this convention in go/c-readability-advice#static-comments.

Interesting. The discussion thread it links to didn't really go anywhere conclusive.

 

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAJ_4DfREKTrwyAgM8r6FZHx3cw0_SaEJu6OtRs4dcON%2BWE1mkw%40mail.gmail.com.

[K. Moon]

I think it's basically a consistency argument: be consistent with what's there already, and also, the majority of code doesn't do this, so you're more likely to be consistent if you don't add new uses. In a different code base, those trade-offs can be completely different. There aren't really strong technical arguments one way or the other.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAHtyhaQrVN5jSCnx1y4U%2BGry%3Dt%2B%2B2h-9bRNEUp33JL7DwUX7kA%40mail.gmail.com.