LSC proposal to modernize use of bool literals

[Anton Bikineev]

Hi all,

I have seen (and written myself) code like:

  bool foo() {

    if (something)

      return 0; // implicit conversion of int literal to bool

  }

This conversion is benign, however it often impairs readability. There is a clang-tidy's check that finds/transforms the integral literals to bool ones - modernize-use-of-bool-literals. Here I'm proposing to apply the check across chromium (and other repos) to fix such uses.

Possible controversial topics:

• while (1) { ... }. This is quite common and actually idiomatic in C89, where there is no the bool type. According to codesearch, we have more "while (1)" than "while (true)" (5600 vs 3814). I propose to not touch these cases and fix/augment the clang-tidy's check in upstream.

• some unittest data (here, for example), where the use of integral literals is more representative. There seem to be not many cases like this, so I'd also propose to not rewrite them.

What do you think? 

[Peter Kasting]

Personally I'd just rewrite both those cases you mention.

PK

--
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAFd1ZwdWGJgrVYLO4JeVBzGXNoZsVskqgkskE%2BHTpKRgDMeo4g%40mail.gmail.com.

[K. Moon]

I prefer "for (;;)" for infinite loops, anyway.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAAHOzFBRQ%3DAZmregtTU39BpA6Bp55s_tc4bKQ2b_GHos7H3Vsw%40mail.gmail.com.

[Anton Bikineev]

I've applied the check on Chromium (+ V8, pdfium, webrtc and some other repos). In Chromium there are only 75 files changed (CL). Do you think we need an LSC doc for the change?

[Nico Weber]

(I commented on the CL.)

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAFd1ZweKqrAK5H2V3B6vayMpQegbxi%3DmGvcS%3D9ycCvwu7533Vg%40mail.gmail.com.

[Anton Bikineev]

Thanks! I created a short doc for it.