Right now we're using absl::optional, and I just got a review that used std::optional. It seems like quite a few uses have found their way into the tree.Is absl::optional hardened in a way that would make a migration harder, or is it time to move to std::optional?
--Avi
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CACWgwAa%3DKcCVipq4TSqdx1M5Zgy6-3da0r1QTra6iL_0WGUWMw%40mail.gmail.com.
Where do we go from here?- Do we make a CL switching uses in our tree to absl::?
- Do we add a presubmit (sigh) or a Tricium plugin to alert folks?
Whatever happened to the stdlib hardening switch?
--On Tue, Feb 15, 2022 at 1:47 PM <dan...@chromium.org> wrote:On Tue, Feb 15, 2022 at 1:46 PM 'Avi Drissman' via cxx <c...@chromium.org> wrote:Right now we're using absl::optional, and I just got a review that used std::optional. It seems like quite a few uses have found their way into the tree.Is absl::optional hardened in a way that would make a migration harder, or is it time to move to std::optional?Yes, absl::optional will crash instead of give you UB when you try to use its value() but it's not present. std::optional is banned for this reason. Not banned hard enough I guess.--Avi
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CACWgwAa%3DKcCVipq4TSqdx1M5Zgy6-3da0r1QTra6iL_0WGUWMw%40mail.gmail.com.
You received this message because you are subscribed to the Google Groups "cxx" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cxx+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CACWgwAbvbh4yyu_MbtVojFq-yFkM-sO%2BrmHmPvA7ZHGvgmcMcw%40mail.gmail.com.
On Tue, 15 Feb 2022 at 10:54, 'Avi Drissman' via cxx <c...@chromium.org> wrote:Where do we go from here?- Do we make a CL switching uses in our tree to absl::?Yes.- Do we add a presubmit (sigh) or a Tricium plugin to alert folks?Yes to the presubmit.Whatever happened to the stdlib hardening switch?Mostly lack of anyone working on it :)
CL is https://crrev.com/c/3465476.If we're not going to see any movement any time soon on this, do we mark a bunch of library functions as banned and add them to the presubmit?
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAHtyhaSEVfu9AhN%2B7P7KfyJiov-G_n%2Br4LTw_4vT%3DP8gfyYSog%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAF3XrKrumqKJXe7rmYD%3DWSGn_kMtkceed25Bw%3DBxaUZsgd8S0g%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/cxx/CAKCW6pviWkyOh1VDwZTBKsofii9T7fTgYqFm%2BuFqWUWsHGQqaA%40mail.gmail.com.