Fix compilation issue on arm64 with Debian's glibc 2.19 [crashpad/crashpad : master]

55 views
Skip to first unread message

Joshua Peraza (Gerrit)

unread,
Jan 14, 2021, 5:46:44 PM1/14/21
to Dangyi Liu, Francois Rousseau, crashp...@chromium.org

Attention is currently required from: Dangyi Liu.

Patch set 1:Code-Review +1

View Change

    To view, visit change 2630288. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: master
    Gerrit-Change-Id: I46368eb08f7cc7338783f115869e5c761f35e465
    Gerrit-Change-Number: 2630288
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dangyi Liu <dan...@google.com>
    Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
    Gerrit-CC: Francois Rousseau <frou...@google.com>
    Gerrit-Attention: Dangyi Liu <dan...@google.com>
    Gerrit-Comment-Date: Thu, 14 Jan 2021 22:46:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Joshua Peraza (Gerrit)

    unread,
    Jan 14, 2021, 5:48:16 PM1/14/21
    to Dangyi Liu, Francois Rousseau, crashp...@chromium.org

    Attention is currently required from: Dangyi Liu.

    Patch set 1:Commit-Queue +2

    View Change

      To view, visit change 2630288. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: crashpad/crashpad
      Gerrit-Branch: master
      Gerrit-Change-Id: I46368eb08f7cc7338783f115869e5c761f35e465
      Gerrit-Change-Number: 2630288
      Gerrit-PatchSet: 1
      Gerrit-Owner: Dangyi Liu <dan...@google.com>
      Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
      Gerrit-CC: Francois Rousseau <frou...@google.com>
      Gerrit-Attention: Dangyi Liu <dan...@google.com>
      Gerrit-Comment-Date: Thu, 14 Jan 2021 22:48:04 +0000

      Commit Bot (Gerrit)

      unread,
      Jan 14, 2021, 6:15:17 PM1/14/21
      to Dangyi Liu, Joshua Peraza, Francois Rousseau, crashp...@chromium.org

      Commit Bot submitted this change.

      View Change

      Approvals: Joshua Peraza: Looks good to me; Commit
      Fix compilation issue on arm64 with Debian's glibc 2.19

      Fuchsia's glibc is derived from Debian so it's causing issues on
      Fuchsia.

      Change-Id: I46368eb08f7cc7338783f115869e5c761f35e465
      Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/2630288
      Reviewed-by: Joshua Peraza <jpe...@chromium.org>
      Commit-Queue: Joshua Peraza <jpe...@chromium.org>
      ---
      M compat/linux/sys/user.h
      1 file changed, 4 insertions(+), 1 deletion(-)

      diff --git a/compat/linux/sys/user.h b/compat/linux/sys/user.h
      index 6ed77a9..d698c35 100644
      --- a/compat/linux/sys/user.h
      +++ b/compat/linux/sys/user.h
      @@ -20,8 +20,11 @@
      #include <features.h>

      // glibc for 64-bit ARM uses different names for these structs prior to 2.20.
      +// However, Debian's glibc 2.19-8 backported the change so it's not sufficient
      +// to only test the version. user_pt_regs and user_fpsimd_state are actually
      +// defined in <asm/ptrace.h> so we use the include guard here.
      #if defined(__aarch64__) && defined(__GLIBC__)
      -#if !__GLIBC_PREREQ(2, 20)
      +#if !__GLIBC_PREREQ(2, 20) && defined(__ASM_PTRACE_H)
      using user_regs_struct = user_pt_regs;
      using user_fpsimd_struct = user_fpsimd_state;
      #endif

      To view, visit change 2630288. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: crashpad/crashpad
      Gerrit-Branch: master
      Gerrit-Change-Id: I46368eb08f7cc7338783f115869e5c761f35e465
      Gerrit-Change-Number: 2630288
      Gerrit-PatchSet: 2
      Gerrit-Owner: Dangyi Liu <dan...@google.com>
      Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
      Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
      Gerrit-CC: Francois Rousseau <frou...@google.com>
      Gerrit-MessageType: merged

      Mayur Kale

      unread,
      Jan 16, 2021, 11:01:55 AM1/16/21
      to Commit Bot, Francois Rousseau, ger...@eemailme.com, isabel90....@gmail.com, jpe...@chromium.org, Crashpad-dev, dan...@google.com
      Hi All,

      I want to add name of the crashing process to the crash dump file as simple annotation,
      Could you please let me know what would be the way to do this?

      -Mayur

      --
      You received this message because you are subscribed to the Google Groups "Crashpad-dev" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to crashpad-dev...@chromium.org.
      To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/crashpad-dev/38ab164d5d065e9a2da7ad48347cc21b6e4e35de-HTML%40chromium-review.googlesource.com.
      Reply all
      Reply to author
      Forward
      0 new messages