Opting-in to mandatory coverage tests

[Ian Clelland]

Hey folks,

https://chromium.googlesource.com/chromium/src/+/HEAD/docs/testing/code_coverage_in_gerrit.md#cls-blocked-due-to-low-coverage tells me that "For some teams in Chrome, we have turned on a coverage check, which blocks a CL from submission if the incremental coverage is below a preset threshold"

How does one become such a team? What's the scope of those checks? (directory-scoped? fle-scoped? something else?) I'd like to be able to have coverage enforced on commits in several directories that I'm OWNER in, or that our team manages, but I can't find docs on how that's enabled.

Thanks for any pointers,

Ian

[Jeremy Bettis]

We have it turned on in platform/ec. You can see the gerrit config at https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/meta/config/project.config

And also you have to change your builder to upload the coverage artifacts, see https://source.corp.google.com/h/chromium/chromiumos/codesearch/+/main:infra/recipes/recipe_modules/cros_artifacts/api.py;l=920;drc=ff5d879888d5e7c1ef718a39d0e8788910c2850a

--
You received this message because you are subscribed to the Google Groups "code-coverage" group.
To unsubscribe from this group and stop receiving emails from it, send an email to code-coverag...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/code-coverage/CAK_TSXL5%3Dnk1FnGCd0Qr4hMQhRs1eOAgAuaeU-gdgjWTaHAjFA%40mail.gmail.com.

--

Jeremy Bettis | ChromeOS FAFT lead | jbe...@google.com | 303-257-2486

[Ian Clelland]

Thanks, Jeremy -- that sounds like the setting is per-project (e.g., all of Chromium,) and not per-directory, so that would be a much larger change than I'm looking to make (at least right now).

[Prakhar Asthana]

If your code is restricted to chromium/src, then all you need is to drop as a ping/email with the list of directories that you want this check enabled for. We would then create a config in code coverage backend for the same. See FAQ doc

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/code-coverage/CAK_TSXK2voQ6OhQayHiaXrXjW76_ncwo8spr71WD%3DgHeRGTFKw%40mail.gmail.com.

[Alexei Svitkine]

Hi, I'm wondering if the error message and docs could be expanded with instructions on how to actually see the coverage data corresponding to the CL that was analyzed? Otherwise, it's not very actionable if people don't know what coverage is missing and would be tempted to just add the tag to bypass the check, instead of adding coverage.

[Alexei Svitkine]

I see it's actually shown via background color on line numbers in the diff. Can the messages say that explicitly? 

[Prakhar Asthana]

Raised CL to fix this.

[Alexei Svitkine]

Thanks!