searchEnginesPrivate API proposal

[Oren Blasberg]

Hi all,

In working on the search engines settings page, I found the need for a new API to provide functionality for populating the search engines dropdown as well as allowing changes to the list of custom search engines etc. in the "manage" dialog.

The proposed API is here. A sanity check would be much appreciated.

Note: implementing this API will require a sizable amount of effort since we'll have to copy and adapt a big chunk of code from multiple existing cc files used with the existing Settings. I'm somewhat concerned about the cost since I think the other APIs (e.g. autofill, SSL settings, etc.) will carry a similarly high implementation cost. Let's discuss at the meeting tomorrow.

Thanks,

Oren

[Dan Beam]

On Mon, Apr 20, 2015 at 5:53 PM, Oren Blasberg <or...@chromium.org> wrote:

Hi all,

In working on the search engines settings page, I found the need for a new API to provide functionality for populating the search engines dropdown as well as allowing changes to the list of custom search engines etc. in the "manage" dialog.

The proposed API is here. A sanity check would be much appreciated.

Can I sanely request comment rights?  ;)

-- Dan

 

Note: implementing this API will require a sizable amount of effort since we'll have to copy and adapt a big chunk of code from multiple existing cc files used with the existing Settings. I'm somewhat concerned about the cost since I think the other APIs (e.g. autofill, SSL settings, etc.) will carry a similarly high implementation cost. Let's discuss at the meeting tomorrow.

Thanks,

Oren

--
You received this message because you are subscribed to the Google Groups "Chromium Settings" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-setti...@chromium.org.
To post to this group, send email to chromium...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-settings/CAFeCVRcOTkZ3hFsQkDW8CJZyQDE1Xc7R39Q4oFqf%3DCx41KDWRQ%40mail.gmail.com.

[Oren Blasberg]

Update: Thanks for the feedback everyone. After chatting with folks offline, I'm switching gears a bit: I'm going first try to implement only the "default search engine" part (the drop-down) of the Search Engines page, end to end, with a very simple get/set style API as proof of concept. This way we can see how much work it is in general to go with the "make a bunch of private APIs" approach. Hopefully this can inform our approach going forward.

I will let you know when the design doc and/or the CL are ready to look at again.

Thanks,

Oren