Safe Browsing flag in chromium

[Dudi Patimer]

Hi,

I'm trying to configure safe-browsing using the command line argument -safebrowsing-enable-enhanced-protection when running chroimum in headless-mode (new), but it seems safe browsing doesn't take affect.

Is this is a know issue?

Thanks,

David

[Daniel Rubery]

I don't think Safe Browsing code is compiled into headless mode, so unfortunately testing Safe Browsing in headless is not possible.

[Mathias Bynens]

Daniel, this is true for the old Headless (//headless) but I believe the new Headless (--headless=new) should generally match headful Chrome. Peter, do you have any insights here?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/fd4dad43-9312-4fbb-aba4-eed00af556cbn%40chromium.org.

[Peter Kvitek]

Confirming what Mathias said. Safe Browsing was not available in old headless mode, however, new headless mode which is essentially the actual Chrome running with no visible mode is expected to fully support it.

Best,

Peter

[Dudi Patimer]

I've tested both headless=new and headless=false modes, but it seems safe browsing is not included.

Is there a repository that includes safe browsing in the compiled artifact?

[Peter Kvitek]

New headless is the regular headful Chrome, so it should include everything regular Chrome includes.  Please try your tests with regular Chrome and if they work with it but fail with --headless-new share the repro script.

/Peter

[Dudi Patimer]

I've tested according to Peter suggestion and although safebrowsing feature is working in my regular Chrome installation, it seems to not take effect when I run Chrome from the command line (both in headless/headful).

After trying with different arguments, it seems that when --user-data-dir argument is being added (with tmp folder) to the command it causes safe browsing to be disabled.

What could be the relation between the data-dir and safe-browsing?

[Dudi Patimer]

This is indeed the issue, I've tested Safe-Browsing using a known phishing URL right after starting chromium. When waiting for ~2-3 after startup the Safe-Browsing page appears.

So it's working for the new headless.

Thanks for your help!

On Wed, Nov 29, 2023 at 7:27 PM Daniel Rubery <dru...@google.com> wrote:

How exactly are you testing whether Safe Browsing is enabled? Safe Browsing stores its lists of bad URL hashes in the user data directory. Changing user-data-dir will require you to download new hash lists, which can take a few minutes after startup.

[Peter Kvitek]

Great! Thank you for getting to the bottom of it.

I'll investigate what other Chrome features are this king of lazy initialization.

/Peter 

[Daniel Rubery]

How exactly are you testing whether Safe Browsing is enabled? Safe Browsing stores its lists of bad URL hashes in the user data directory. Changing user-data-dir will require you to download new hash lists, which can take a few minutes after startup.