Compile errors with gMock on Windows only.

[Erik Jensen]

I'm trying to land https://crrev.com/c/1668070, which uses Google Mock for some tests. I had a previous version of the patchset building on all builders a few weeks ago, but I had to put in on the back burner for a bit. Now, after doing a sync and rebase, the tests are failing to build on Windows, but are still working on all other platforms. The error messages all appear to be failing static asserts from Google Mock, such as the following:

telemetry_log_writer_unittest.cc(45,3): error: static_assert failed "(override) should be enclosed in parentheses."

Given that "(override)" obviously is indeed enclosed in parentheses, it would appear that the preprocessor macros that check for that and the compiler aren't getting along, somehow.

Any ideas?

Thanks!

[Nico Weber]

Can you file crbug under Tools>LLVM for starters? This might be gmock trying to be overly clever, but who knows.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAN%3DK5G_mQCpr_hBmrnDHAd-hjettPWNoCXdXv1zqiNLpwtUCAQ%40mail.gmail.com.

[Erik Jensen]

Filed as https://crbug.com/989095. Thanks.