After cl upload, git cl owners tells nothing

55 views
Skip to first unread message

xin...@intel.com

unread,
Mar 15, 2018, 10:50:19 PM3/15/18
to Chromium-dev
Hi, after I submited a cl by git cl upload --gerrit,  I tried git cl owners  to get the owners info for cl review. However, git cl owners only prompts a single line like:
** You selected these owners **

Tom Anderson

unread,
Mar 16, 2018, 2:32:54 PM3/16/18
to xin...@intel.com, Chromium-dev
That can happen when "*" is in the OWNERS file.  It just means you can get anyone to review that CL.  Perhaps it would be better for "git cl owners" to pick a reviewer though, since presubmit will still require at least one.

On Thu, Mar 15, 2018 at 7:50 PM, <xin...@intel.com> wrote:
Hi, after I submited a cl by git cl upload --gerrit,  I tried git cl owners  to get the owners info for cl review. However, git cl owners only prompts a single line like:
** You selected these owners **

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/2627ae8f-4f70-4abe-afdd-98afbdae749c%40chromium.org.

Anita Woodruff

unread,
Mar 19, 2018, 11:18:18 AM3/19/18
to thomasa...@google.com, xin...@intel.com, Chromium-dev
Aha, that's what I suspected but wasn't sure enough to reply myself - thanks Tom!

As an alternative to picking a random reviewer, how about if the tool printed some message saying anyone can review it?

Personally I'd find that most helpful, for the rare occasion when it happens and I forget what no output means.

On Fri, 16 Mar 2018 at 18:32 'Tom Anderson' via Chromium-dev <chromi...@chromium.org> wrote:
That can happen when "*" is in the OWNERS file.  It just means you can get anyone to review that CL.  Perhaps it would be better for "git cl owners" to pick a reviewer though, since presubmit will still require at least one.

On Thu, Mar 15, 2018 at 7:50 PM, <xin...@intel.com> wrote:
Hi, after I submited a cl by git cl upload --gerrit,  I tried git cl owners  to get the owners info for cl review. However, git cl owners only prompts a single line like:
** You selected these owners **

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

Aaron Gable

unread,
Mar 20, 2018, 12:13:56 PM3/20/18
to aw...@google.com, thomasa...@google.com, xin...@intel.com, Chromium-dev
Please file a bug in the Infra>SDK component so we can keep track of this request :)

Anita Woodruff

unread,
Mar 21, 2018, 11:25:15 AM3/21/18
to Aaron Gable, thomasa...@google.com, xin...@intel.com, Chromium-dev
Reply all
Reply to author
Forward
0 new messages