--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CACWgwAaJLXFNk3wa3s9-LRh7o46WOhO3gYSMnMRthEkyB7cRuA%40mail.gmail.com.
Hi Avi,The presubmit check on git cl upload seems unaware of this change:Note that I generated these files with tools/boilerplate.py (which *has* been updated) so their license is:
// Copyright 2022 The Chromium Authors.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAAyTkm%3D4RKE1pexVYP0OArAGw4166jjxpAx-5Phf_RqGqXCCig%40mail.gmail.com.
Some Chromium source code from 2013 has that preamble, some source code from 2015 does not.Suggestion: Include full path (link) to LICENSE file in parentheses adjacent to below// found in the LICENSE file (https://source.chromium.org/chromium/chromium/src/+/main:LICENSE).I used some Chromium source code in a project a few days ago. I included the LICENSE in comments above the section cotaining the specific Chromium source code used.It would be helpful to have the direct link to the primary reference in the document, updated to the current full path if necessary, programmatically.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CACWgwAa2-x5ON2W2HDXCeuu8MsEACcXo5dUAGgyBJN0Oesxamw%40mail.gmail.com.
You received this message because you are subscribed to the Google Groups "Chromium Embedders" group.
To unsubscribe from this group and stop receiving emails from it, send an email to embedder-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/embedder-dev/CAAozHL%3DSichWROAjKDGb7aq5ap%3D08871EuYvpv_eaXehEy9KhQ%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHk1GDzmXqL3Oc4RfAbiSR--fM89huR0123wvuSpwpzzR8sfPw%40mail.gmail.com.
Some of Chromium source code has that preamble, some Chromium source code from 2015 does not.Suggestion:Include full path to the LICENSE file in paratheses adjacent to what the lawyers advised at close of sentence// found in the LICENSE file (https://source.chromium.org/chromium/chromium/src/+/main:LICENSE).I included the license above some Chromium source code in a project a few days ago.It will be helpful for canonical link to the license in each source code file as described above, for expediency.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CA%2BsyWAO7gw9UHaAywS3sYDyevgM2PFOFTnAw49OGSNNOc%3DExnw%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAHtyhaSiLG6Arh250WpkXC0uM8NM7nsjTPO7%2BbcGZe6Psg-oTw%40mail.gmail.com.