Chromium Windows build on Linux fails, apparently due to updated Dawn hook referencing ciopfs.sha1 file

[Alesandro Ortiz]

Hello,

I'm trying to update my Chromium checkout (host=Linux, target=Windows), but seem stuck on an issue when running the `ciopfs_linux` hook within Dawn (triggered by gclient runhooks/sync).

Last time I made a successful build on this machine was with a checkout from end of November 2022. Today I updated my checkout using `git rebase-update` and `gclient sync`, along with updating my MSVC toolchain, and started facing this issue.

alesandro@chromium-build-9:~/chromium/cr/src$ gclient runhooks
Updating depot_tools...
using /run/user/1001/goma_alesandro as tmpdir
compiler_proxy is not running
Running hooks:  83% (115/137) ciopfs_linux
________ running 'download_from_google_storage --no_resume --no_auth --bucket chromium-browser-clang/ciopfs -s build/ciopfs.sha1' in '/home/alesandro/chromium/cr/src/third_party/dawn'
Fatal error: build/ciopfs.sha1 not found when attempting enumerate files to download.
Error: Command 'download_from_google_storage --no_resume --no_auth --bucket chromium-browser-clang/ciopfs -s build/ciopfs.sha1' returned non-zero exit status 1 in /home/alesandro/chromium/cr/src/third_party/dawn
Fatal error: build/ciopfs.sha1 not found when attempting enumerate files to download.

(same relevant output with gclient sync vs. gclient runhooks, the issue is when running the hooks)

The Dawn ciopfs_linux hook seems to have been added [1] within the past 24 hours to the dawn DEPS file.

However, a similar hook has also been present in the main DEPS [2] file since 2018 and seemed to work in the past.

The local file does exist relative to the top-level checkout directory:
alesandro@chromium-build-9:~/chromium/cr/src$ cat build/ciopfs.sha1
5454b3c4f1c9992047e7ae9d6d14d5b49b1b12f3

The issue seems to be that the working directory is /home/alesandro/chromium/cr/src/third_party/dawn instead of /home/alesandro/chromium/cr/src when running depot_tools' download_from_google_storage.py. This is based on output of os.getcwd() within /home/alesandro/chromium/depot_tools/download_from_google_storage.py (which is the Python script that is run in this case).

Is there something I'm missing in my update procedures, or is the issue in the Dawn DEPS file and/or download script?

I haven't yet tried building using a commit immediately prior to the identified commit [1], but will try within a few days if I can to verify if that's the issue. Any help or pointers would be appreciated so I can avoid checking out an older version of the tree.

[1] https://source.chromium.org/chromium/_/dawn/dawn.git/+/78583a14e642831d33cf1f6d66362e0d7ea591ad

[2] https://chromium.googlesource.com/chromium/src/+/762993055a75a8f62232e5454f16b566a2de7e3c%5E%21/#F0

Regards,

Alesandro

[Lei Zhang]

The fix in Dawn [3] should roll into Chromium in the near future.

[3] https://dawn-review.googlesource.com/119560

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/e59e0e3e-7252-4b38-b91d-3f3dcac275b4n%40chromium.org.

[Brian Begnoche]

Relevant bug is crbug.com/1415010.

I have the same question as the last comment. Can you specify what "the near future" means? Any workaround in the meantime?

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CACSHbcRc0ecJb8Ydh_7jLQv%2BNiDDtQWEe%2BdoyX44XmWYWyNuAg%40mail.gmail.com.

[Alesandro Ortiz]

Thanks, I'll use that patch until it rolls into main (if it hasn't already).

Shortly after sending my initial email on Friday, I confirmed the identified patch was the issue by building using a commit immediately prior to it. That unblocked me temporarily.

Regards,

Alesandro

[Alesandro Ortiz]

What I did on Friday to unblock myself was to use a commit immediately prior to the relevant Dawn roll (not on laptop now so don't have exact hash, sorry).

You could also manually apply the patch linked by thestig@ to a more recent build which in theory should also work.

[Lei Zhang]

The "near future" was actually the past. Please sync to crrev.com/1104528 or newer.

[Brian Begnoche]

Thanks. Can confirm that while a previous rebase got me into a broken state, another rebase just now seems to have gotten me out of it (gclient sync completed successfully).