Websocket close code changed to 1005 from 1000

[Zeus Kronos]

I am using chrome beta 116. I have noticed change in close code in websocket.

Earlier when I call websocket.close() the close code will be 1000

Now when I call websocket.close() the close code is 1005

Any reason for this behaviour?

[PhistucK]

I could not find any evidence that this has been 1000 in the last two years (or nine years)...

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/websockets/Close-1005-verify-code.any.js;l=18?q=1005&ss=chromium

https://source.chromium.org/chromium/chromium/src/+/main:net/websockets/websocket_channel.h;l=309?q=1005%20websocket&ss=chromium

(Click on "Blame" to see when the line was last changed)

☆PhistucK

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/935d8419-0999-4aeb-80c3-47e7f28fa23an%40chromium.org.

[Adam Rice]

I can confirm that there have been no intentional changes.

1005 (ie. no close code) is the correct behaviour according to the standard: https://websockets.spec.whatwg.org/#dom-websocket-close

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CABc02_Kj7D6eOf9pDmhihzJs%3DzaAUtDFWnaTaurMMgstNbLW%2BA%40mail.gmail.com.