PSA: git version 2.11+ is required by depot_tools users

[Andrii Shyshkalov]

If your $ git version is 2.11 or above, you can stop reading now.

Hi Chromium devs,

git cl and other tools in depot_tools will be expecting git 2.11 or higher soon.

For those using Gerrit codereview, soon is today (bug).

depot_tools has been downloading git 2.11+ on windows machines for a while, and Chrome test machines fleet has been using recent git versions to get security patches.

Thus, if you don't yet have 2.11, you should upgrade too!

Thanks,

Andrii

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CADzH4%2BvbMHrwu9kLzyRDGa9ysauYcZFwbnU%3DB2qK6h%3DqivBUVg%40mail.gmail.com.

[Andrii Shyshkalov]

For Mac users: updating your xcode to latest release will bring git to 2.11 

[Daniel Bratell]

What is in 2.11 that is so important?

I just checked my ubuntu 16.4 LTS and it seems to be on git 2.7.4  Is there an expectation that those that use Linuxes that are not just released to build and install a custom git or will it too be bundled in depot_tools like in Windows?

The Chromium build documentation mentions Ubuntu 14.4, the previous LTS release but I guess that should be updated to 16.4. Either way, they will not have the right version of git so https://chromium.googlesource.com/chromium/src/+/master/docs/linux_build_instructions.md should be updated.

/Daniel

You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CADzH4%2BvbMHrwu9kLzyRDGa9ysauYcZFwbnU%3DB2qK6h%3DqivBUVg%40mail.gmail.com.

--

/* Opera Software, Linköping, Sweden: CET (UTC+1) */

[Lei Zhang]

And Ubuntu 14.04, which is a supported platform for development, is
still shipping 1.9.1. http://packages.ubuntu.com/trusty/git

> --
> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev
> ---

> You received this message because you are subscribed to the Google Groups

> "Chromium-dev" group.

> To view this discussion on the web visit

> https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/op.yx8iyu0mrbppqq%40cicero2.linkoping.osa.

[Matthew Menke]

Both my PCs look to be running git 2.10.0.windows.1, and there doesn't look to be a newer version in my depot_tools directory that's being masked by an older version.  Neither gclient sync not gclient --version changes that.

How confident are you that depot_tools is actually installing git 2.11?

[Ben Wagner]

Looks like 2.10 has push-options ( https://github.com/git/git/commit/f6a4e61fbb647928d615a0befaec163a5d2bf4af ). So maybe it will work.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/dd4e61ec-e801-4191-ae38-0829a1e2c926%40chromium.org.

[Daniel Bratell]

If push-options is the key here, does that mean that unless you do a patch upload, an older git will still work? Things like gclient update?

/Daniel

[Peter Kasting]

On Wed, Apr 5, 2017 at 1:57 PM, 'Matthew Menke' via Chromium-dev <chromi...@chromium.org> wrote:

Both my PCs look to be running git 2.10.0.windows.1, and there doesn't look to be a newer version in my depot_tools directory that's being masked by an older version.  Neither gclient sync not gclient --version changes that.

How confident are you that depot_tools is actually installing git 2.11?

I also see depot_tools/git.bat version returning 2.10.0.windows.1.

That said, I don't use the depot_tools git, I use the built-in one from git for Windows (formerly msysgit), so I just installed the newest version, which is 2.12.2.windows.2.

PK

[Primiano Tucci]

Requiring git 2.11 which, as people pointed out above, is not yet  rolled in the version of Linux we currently officially support, seems IMHO quite aggressive.
By looking at the bug linked, it seems that the requirement comes from wanting to use push -o m=patchset_title, which is only supported in latest git.
Can I humbly suggest you have a fallback via a json endpoint (as suggested but ruled out in the bug) and make depot_tools be like

  If git.version >= 2.11:
    Git push -o t...
Else
   Just git push
   Use json api to set title at the cost of some extra latency

?

--

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAAHOzFA7b-tPSQFux2H-93bwn2W5APR8s3VLphrSLBdzm%2BrXQg%40mail.gmail.com.

[Andrii Shyshkalov]

tl;dr I cancel this PSA

Yes, it was aggressive and optimistic, thank you very much for feedback! 

I should have said 2.10, as that's what we bake into depot_tools for windows (thanks, Matthew), but 2.10 so I am not sure how many people are affected by this outside of Google.

So, for now I drop this proposal.

On Thu, Apr 6, 2017 at 10:51 AM Primiano Tucci <prim...@chromium.org> wrote:

Requiring git 2.11 which, as people pointed out above, is not yet  rolled in the version of Linux we currently officially support, seems IMHO quite aggressive.
By looking at the bug linked, it seems that the requirement comes from wanting to use push -o m=patchset_title, which is only supported in latest git.
Can I humbly suggest you have a fallback via a json endpoint (as suggested but ruled out in the bug) and make depot_tools be like

  If git.version >= 2.11:
    Git push -o t...
Else
   Just git push
   Use json api to set title at the cost of some extra latency

?

Yeah, I considered this, but given code health in that part of git cl, it'd take 1 or more work days to write and properly test, and it'll make code worth off. So, I'm shelving this idea for now until either:

 * most of our developers use 2.10+

 * git cl is refactored and cleaned, so that Primiano's proposal isn't so costly