Question About Build.gn

[JongWon Heo]

Hi i have just wondering about simple things.

Why only Some WebUI Root folder have Build.gn?

While I was developing my own browser, 

I have small subfolders in large components like new_tab_page, and there are images that are only used in these folders, and it is difficult to maintain them in collaboration with others to use them in ntp's build.gn . As far as I know, chromium basically has the principle of having build.gn only for large folders such as downloads and ntp. What's the clear reason why subfolders shouldn't have it?

[Dirk Pranke]

There's no clear reason or standard one way or another, but in general the main principle is to group things that are used the same together, so that if a bunch of files all are built the same way and have the same dependencies and the same users, then you might as well leave them in a single target and in a single BUILD.gn file. That said, if there are reasons that splitting things up would make development easier, you can certainly do that as well.

However, we don't generally structure code in Chromium to make things easier for downstream browsers, so you'd have to show that splitting targets up would make upstream development better as well.

-- Dirk

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/14764874-f2b7-4504-99a1-0f37c996f048n%40chromium.org.