Rebaseline over 1k tests.

31 views
Skip to first unread message

Yoichi Osato

unread,
Aug 21, 2018, 4:12:38 AM8/21/18
to blink...@chromium.org, Hayato Ito
Hi, infra team. I'm from DOM team and be trying to
rebaseline bunch of layouttests to insert deprecation message:
https://chromium-review.googlesource.com/c/chromium/src/+/1180840

However, "tools/blink_tool.py rebaseline-cl" hanged and it looks
it is creating redundant platform expect result even each original test
has platform-free expectation.

What's the best way to rebaseline for the patch? Thanks.

Robert Ma

unread,
Aug 21, 2018, 12:05:02 PM8/21/18
to yoi...@chromium.org, nedn...@chromium.org, blink...@chromium.org, hay...@chromium.org
Could you add --verbose and paste the last few lines of log before it hangs?

My guess based on your description is that the tool has actually done downloading new baselines and is struggling with optimization, which is known to be inefficient and very slow (tens of minutes) when dealing with thousands of tests (I filed a bug a while ago and let me try to find it later).

+Ned Nguyen this blink-infra@ list isn't really active. Does Chrome Core Automation have a *public* (chromium.org) list for discussions like this?

--
You received this message because you are subscribed to the Google Groups "blink-infra" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-infra...@chromium.org.
To post to this group, send email to blink...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-infra/CAAEV3p%3D31SGv9f1LPP96n2PC75Q6Vk0AQgr9Y-H2GX7UoAxMmw%40mail.gmail.com.

Dirk Pranke

unread,
Aug 21, 2018, 12:41:49 PM8/21/18
to Robert Ma, Yoichi Osato, Ned Nguyen, blink-infra, Hayato Ito
On Tue, Aug 21, 2018 at 9:04 AM, Robert Ma <robe...@chromium.org> wrote:
Could you add --verbose and paste the last few lines of log before it hangs?

My guess based on your description is that the tool has actually done downloading new baselines and is struggling with optimization, which is known to be inefficient and very slow (tens of minutes) when dealing with thousands of tests (I filed a bug a while ago and let me try to find it later).

optimization is known to be inefficient? I don't recall it being slow in the past (several years ago) ...

-- Dirk
 

+Ned Nguyen this blink-infra@ list isn't really active. Does Chrome Core Automation have a *public* (chromium.org) list for discussions like this?
2018, 04:12 Yoichi Osato <yoi...@chromium.org> wrote:
Hi, infra team. I'm from DOM team and be trying to
rebaseline bunch of layouttests to insert deprecation message:
https://chromium-review.googlesource.com/c/chromium/src/+/1180840

However, "tools/blink_tool.py rebaseline-cl" hanged and it looks
it is creating redundant platform expect result even each original test
has platform-free expectation.

What's the best way to rebaseline for the patch? Thanks.

--
You received this message because you are subscribed to the Google Groups "blink-infra" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-infra+unsubscribe@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-infra" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-infra+unsubscribe@chromium.org.

To post to this group, send email to blink...@chromium.org.

Robert Ma

unread,
Aug 21, 2018, 12:48:49 PM8/21/18
to Dirk Pranke, yoi...@chromium.org, nedn...@chromium.org, blink...@chromium.org, hay...@chromium.org
I just found the bug I filed: https://crbug.com/808572

And sorry my first reply wasn't accurate; I misremembered a detail. The slow part (at least back in February when I was rebaselining thousands of tests for Mac 10.13) was in fact part of rebaseline, not optimize-baselines. The slow function is called before optimizing the baselines, so the symptom is that rebaseline-cl seems to hang (not really, it's just slow) before new baselines are optimized.

I didn't have time to look into that, but I think this should be totally fixable.

On Tue, Aug 21, 2018 at 12:41 PM Dirk Pranke <dpr...@chromium.org> wrote:
On Tue, Aug 21, 2018 at 9:04 AM, Robert Ma <robe...@chromium.org> wrote:
Could you add --verbose and paste the last few lines of log before it hangs?

My guess based on your description is that the tool has actually done downloading new baselines and is struggling with optimization, which is known to be inefficient and very slow (tens of minutes) when dealing with thousands of tests (I filed a bug a while ago and let me try to find it later).

optimization is known to be inefficient? I don't recall it being slow in the past (several years ago) ...

-- Dirk
 

+Ned Nguyen this blink-infra@ list isn't really active. Does Chrome Core Automation have a *public* (chromium.org) list for discussions like this?
2018, 04:12 Yoichi Osato <yoi...@chromium.org> wrote:
Hi, infra team. I'm from DOM team and be trying to
rebaseline bunch of layouttests to insert deprecation message:
https://chromium-review.googlesource.com/c/chromium/src/+/1180840

However, "tools/blink_tool.py rebaseline-cl" hanged and it looks
it is creating redundant platform expect result even each original test
has platform-free expectation.

What's the best way to rebaseline for the patch? Thanks.

--
You received this message because you are subscribed to the Google Groups "blink-infra" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-infra...@chromium.org.

--
You received this message because you are subscribed to the Google Groups "blink-infra" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-infra...@chromium.org.

To post to this group, send email to blink...@chromium.org.
Reply all
Reply to author
Forward
0 new messages