On 26/11/2020 07:13, Rome Rome wrote:
> *Explainer*
> https://github.com/w3c/staticrange/issues/1
This is not a explainer, it's usually better to have a small summary in
a separated document (or an inline comment in the intent if that's
enough).
> *Interoperability and Compatibility Risks *
> Compatibility:
> As an abstract interface, we will not directly instantiate an object of
> type AbstractRange.
> So, we should change the overlapping code in the Range and StaticRange
> interfaces.
Does it has any impact on current websites? Would anything stop working?
No, the current websites can keep the code. Because 'Range' and 'StaticRange' can be used the same as before.
This change will add the abstract superclass and inherits it.
> Interoperability:
> Firefox: Public support
> <https://wpt.fyi/results/dom/idlharness.window.html%3Fexclude%3DNode>
> Safari: Public support
> <https://wpt.fyi/results/dom/idlharness.window.html%3Fexclude%3DNode>
More than public support it seems it has been shipped in both, or am I
wrong?
Bye,
Rego
On 27/11/2020 11:13, Manuel Rego wrote:
On 26/11/2020 07:13, Rome Rome wrote:
> *Explainer*
> https://github.com/w3c/staticrange/issues/1
This is not a explainer, it's usually better to have a small summary in
a separated document (or an inline comment in the intent if that's
enough).
Thanks for the guidance. I wonder omit the Explainer in this.
> *Interoperability and Compatibility Risks *
> Compatibility:
> As an abstract interface, we will not directly instantiate an object of
> type AbstractRange.
> So, we should change the overlapping code in the Range and StaticRange
> interfaces.
Does it has any impact on current websites? Would anything stop working?
No, the current websites can keep the code. Because 'Range' and 'StaticRange' can be used the same as before.
This change will add the abstract superclass and inherits it.
> Interoperability:
> Firefox: Public support
> <https://wpt.fyi/results/dom/idlharness.window.html%3Fexclude%3DNode>
> Safari: Public support
> <https://wpt.fyi/results/dom/idlharness.window.html%3Fexclude%3DNode>
More than public support it seems it has been shipped in both, or am I
wrong?You're the boss. I will change 'Public support' to 'Shipped/Shipping' both.
Bye,
RegoThank you very much, Rego.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/efe97b91-8b9f-465a-9671-412afb48beb1n%40chromium.org.
On 27/11/2020 17:33, Yoav Weiss wrote:On Mon, Nov 30, 2020 at 9:07 AM Romederful <jdrag...@gmail.com> wrote:
On 27/11/2020 11:13, Yoav Weiss wrote:
On Mon, Nov 30, 2020 at 7:00 AM Jaeyong Bae <jdrag...@gmail.com> wrote:On 27/11/2020 11:13, Manuel Rego wrote:
On 26/11/2020 07:13, Rome Rome wrote:
> *Explainer*
> https://github.com/w3c/staticrange/issues/1
This is not a explainer, it's usually better to have a small summary in
a separated document (or an inline comment in the intent if that's
enough).
Thanks for the guidance. I wonder omit the Explainer in this.As Rego said, it's better to include an explainer, even if a short, inlined one, so that reviewers (and the public) can quickly understand what it is you're trying to ship and why.
Thanks Yoav :) I'm going to change it like below.
Explainer
Implement and ship superclass named AbstractRange, StaticRange and Range both inherit from AbstractRange.The bits shared between StaticRange and Range objects are put on a shared AbstractRange.What is the use case for this? What would it enable developers to do?How would developer code need to change as a result?
On 27/11/2020 17:33, Yoav Weiss wrote:On Mon, Nov 30, 2020 at 9:07 AM Romederful <jdrag...@gmail.com> wrote:On 27/11/2020 11:13, Yoav Weiss wrote:On Mon, Nov 30, 2020 at 7:00 AM Jaeyong Bae <jdrag...@gmail.com> wrote:On 27/11/2020 11:13, Manuel Rego wrote:
On 26/11/2020 07:13, Rome Rome wrote:
> *Explainer*
> https://github.com/w3c/staticrange/issues/1
This is not a explainer, it's usually better to have a small summary in
a separated document (or an inline comment in the intent if that's
enough).
Thanks for the guidance. I wonder omit the Explainer in this.As Rego said, it's better to include an explainer, even if a short, inlined one, so that reviewers (and the public) can quickly understand what it is you're trying to ship and why.Thanks Yoav :) I'm going to change it like below.
Explainer
Implement and ship superclass named AbstractRange, StaticRange and Range both inherit from AbstractRange.The bits shared between StaticRange and Range objects are put on a shared AbstractRange.What is the use case for this? What would it enable developers to do?How would developer code need to change as a result?
AbstractRange is abstract interface, so developers will not directly instantiate an object of type AbstractRange.
This means that developers will use the Range or StaticRange interfaces instead.
As a result, I think developer code related to Range or StaticRange can be kept without any changes.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOhF%3Dqx7KChOPTCQLOhFrGO9a9M7aeV-u7xw0JfzMTVMSjNROw%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/bb03156e-8a73-4c3b-8bf0-0e0d6678bbe5n%40chromium.org.