Intent to Ship: ImageCapture.getPhotoSettings()

43 views
Skip to first unread message

Miguel Casas-Sanchez

unread,
Jun 14, 2017, 10:35:54 PM6/14/17
to blink-dev

Contact emails

mca...@chromium.org, sch...@chromium.org


Summary

Adding the method getPhotoSettings() [1].  This method allows for reading the photo-specific settings of the API.  Retrieving these values was lost in the Spec reorganization of ~Jan'17.


Spec


We propose adding the method getPhotoSettings() [1] to the currently shipped ImageCapture object [2]. It's a trivial follow up to the MediaStream Image Capture API shipped in 59 [3]. TAG review is still going on in [4] but the significant comments were already addressed.


[1] https://w3c.github.io/mediacapture-image/#dom-imagecapture-getphotosettings 

[2] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl?q=imagecapture.idl&sq=package:chromium&dr 

[3] https://www.chromestatus.com/features/4843864737185792

[4] https://github.com/w3c/mediacapture-image/issues/69

 

Link to “Intent to Implement” blink-dev discussion

No blink-dev discussion since this is a trivial increase.

  

Is this feature supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes

  

Interoperability and Compatibility Risk

No other browser implements this feature yet, so there should be no compatibility concerns.

 

Edge: No signals

Firefox: Reviewed the PR and 👍 (https://github.com/w3c/mediacapture-image/pull/183#pullrequestreview-44125153)

Safari: No signals

Web developers: No signals

  

Is this feature fully tested by web-platform-tests?

Still not being shipped but being tracked in https://crbug.com/706434.

 

OWP launch tracking bug

https://crbug.com/732521

 

Entry on the feature dashboard

https://www.chromestatus.com/feature/5104908176982016


ddena...@yahoo.com

unread,
Jun 15, 2017, 1:05:17 AM6/15/17
to blink-dev

Philip Jägenstedt

unread,
Jun 16, 2017, 4:42:23 AM6/16/17
to Miguel Casas-Sanchez, blink-dev
LGTM1

https://github.com/w3c/mediacapture-image/issues/186 was filed yesterday, is that something that should be included in this intent?

P.S. https://github.com/w3ctag/design-reviews/issues/133 is the TAG review, https://github.com/w3c/mediacapture-image/issues/69 is something else, but in any event neither is blocking. Also filed https://github.com/w3c/mediacapture-image/issues/188 with a bit of non-blocking feedback.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPUS08596mgbLwY_FtRB2vNL9BNHU0hyZT-wBV2XmZ8Qhb1iNQ%40mail.gmail.com.

TAMURA, Kent

unread,
Jun 16, 2017, 4:55:58 AM6/16/17
to Miguel Casas-Sanchez, blink-dev
LGTM2.


Miguel Casas-Sanchez

unread,
Jun 16, 2017, 10:48:45 AM6/16/17
to TAMURA, Kent, blink-dev
On 16 June 2017 at 04:55, TAMURA, Kent <tk...@chromium.org> wrote:
LGTM2.


On Fri, Jun 16, 2017 at 5:42 PM, Philip Jägenstedt <foo...@chromium.org> wrote:
LGTM1

https://github.com/w3c/mediacapture-image/issues/186 was filed yesterday, is that something that should be included in this intent?

Yeah, there's a few additions to the Spec in in different stages of review:

https://github.com/w3c/mediacapture-image/issues/186 adds a member to PhotoSettings dictionary to configure the encoded (jpeg, png) quality.
https://github.com/w3c/mediacapture-image/issues/162 adds a member to PhotoCapabilities and PhotoSettings to enumerate and configure the capture format (e.g. jpeg, png, raw)
https://github.com/w3c/mediacapture-image/issues/177 adds a member to PhotoCapabilities and PhotoSettings to enumerate and configure the camera pan and tilt.

But since none of those issues has landed in the Spec yet, I thought better to send this i2s now.

Chris Harrelson

unread,
Jun 16, 2017, 11:06:54 AM6/16/17
to Miguel Casas-Sanchez, TAMURA, Kent, blink-dev
LGTM3

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPUS087iyLPFgfnN1eSSKVSFdgb_fonMrhBUyCeNoW%2BoKPRbdQ%40mail.gmail.com.

Reply all
Reply to author
Forward
0 new messages