A pseudo class selector to style dialog element. The :modal pseudo-class represents an element which is in a state that excludes all interaction with elements outside it until it has been dismissed.
Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications?
Automatically supported, same as other pseudo-elements.
No milestones specified
Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).
Specification
https://www.w3.org/TR/selectors-4/#modal-stateSummary
A pseudo class selector to style dialog element.
The :modal pseudo-class represents an element which is in a state that excludes all interaction with elements outside it until it has been dismissed.
Blink component
Blink>CSSTAG review
TAG review status
PendingRisks
Interoperability and Compatibility
Gecko: Shipped/Shipping (https://bugzilla.mozilla.org/show_bug.cgi?id=1768535)
Other signals:WebView application risks
Does this intent deprecate or change behavior of existing APIs, such that it has potentially high risk for Android WebView-based applications?
Debuggability
Automatically supported, same as other pseudo-elements.
Is this feature fully tested by web-platform-tests?
Yes
Flag name
Requires code in //chrome?
FalseTracking bug
https://crbug.com/1327113Estimated milestones
No milestones specified
Anticipated spec changes
Open questions about a feature may be a source of future web compat or interop issues. Please list open issues (e.g. links to known github issues in the project for the feature specification) whose resolution may introduce web compat/interop risk (e.g., changing to naming or structure of the API in a non-backward-compatible way).
Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5192833009975296This intent message was generated by Chrome Platform Status.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAPJHA1oU6TM%3DqU6udPJ46g2%3DUoYYiObOuoYrSLboMBZe7icofQ%40mail.gmail.com.
Thanks for feedbacks!
1. Explainer : I added an csswg-drafts issue link(https://github.com/w3c/csswg-drafts/issues/6965) into explainer. It has been re-opened due to the fullscreen spec.
2. fullscreen spec : As mentioned, issue has been re-opened due to this. Further discussion is needed.
3. TAG review : I think it would not needed since it's an existing spec discussed. If not, please let me know :)
4. Gecko vendor signal : I set gecko's signal to 'Shipped/Shipping' as the doc(bit.ly/blink-signals) defines 'Shipped/Shipping' as 'Link to public documentation or bug/issue'. I'm not sure which signal would be right if there is an open issue.
Thank for this feedback - I can see how that is confusing. I updated the language to say "Link to public documentation or bug/issue that demonstrates the issue has shipped (i.e., an issue that links to patches that have been merged, or a comment that a previously disabled feature is not enabled by default)."
In this case, the better choice is probably "No signal", and we
should ask for an official position via the Mozilla standards
position repo (the fact that Emilio tagged it as "good-first-bug"
is encouraging!).
5. WPT link :There were some differences between what was written in chromestatus and I2S. I added WPT test links but on I2S that is not shown.As Emillo mentioned, WPT links are as follows.
Thanks again!
2022년 5월 26일 목요일 오전 1시 0분 45초 UTC+9에 sligh...@chromium.org님이 작성:
I'd like to see an explainer and completed TAG review before moving forward. Could this perhaps be going to OT instead?
On Wednesday, May 25, 2022 at 3:44:22 AM UTC-7 Emilio Cobos Alvarez wrote:
On 5/25/22 09:38, Manuel Rego Casasnovas wrote:
> There are these tests for ":modal":
> * http://http://wpt.live//css/selectors/modal-pseudo-class.html
> *
> http://http://wpt.live//css/selectors/invalidation/modal-pseudo-class-in-has.html
>
> They are for <dialog>, but it looks there are no tests for the
> fullscreen case.
It isn't clear from the resolution[1] that this should apply to
fullscreen, and it doesn't seem like WebKit's implementation does that
(it seems a bit weird that it would since fullscreen at least in Gecko
isn't modal / doesn't make the rest of the page inert...).
I commented on the spec issue about this.
-- Emilio
[1]: https://github.com/w3c/csswg-drafts/issues/6965#issuecomment-1118033655
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/d44d8453-865b-4d6b-8e59-be09570aa8ean%40chromium.org.
On 5/26/22 2:42 AM, Jihwan Kim wrote:
4. Gecko vendor signal : I set gecko's signal to 'Shipped/Shipping' as the doc(bit.ly/blink-signals) defines 'Shipped/Shipping' as 'Link to public documentation or bug/issue'. I'm not sure which signal would be right if there is an open issue.Thank for this feedback - I can see how that is confusing. I updated the language to say "Link to public documentation or bug/issue that demonstrates the issue has shipped (i.e., an issue that links to patches that have been merged, or a comment that a previously disabled feature is not enabled by default)."
If we're first to implement, we should always be asking for design guidance from the TAG. That a feature originates in the CSS WG is not a pass for design review (although I know CSS WG participants often wish it were).
Hello,
It would be nice if there was some repository or documents were we could fill some security/privacy questions. I will do it here instead.
How does this interacts with iframes? Do you know where it might be defined in the spec? I remember for the modal dialog, there was some "inertness" attribute propagated toward parent/iframes. It was shown it can be used to leak cross-site data, or it can be used to create new communication channel. It was found and fixed here: https://crbug.com/1293191. I guess the two features relies on the same mechanism and Chrome might immune as result. Anyway, could you please make sure the behavior is specified and show how it doesn't create a cross-site leak?
On Thursday, May 26, 2022 at 6:51:19 PM UTC+2 Mike Taylor wrote:On 5/26/22 9:35 AM, Mike Taylor wrote:
On 5/26/22 2:42 AM, Jihwan Kim wrote:
4. Gecko vendor signal : I set gecko's signal to 'Shipped/Shipping' as the doc(bit.ly/blink-signals) defines 'Shipped/Shipping' as 'Link to public documentation or bug/issue'. I'm not sure which signal would be right if there is an open issue.Thank for this feedback - I can see how that is confusing. I updated the language to say "Link to public documentation or bug/issue that demonstrates the issue has shipped (i.e., an issue that links to patches that have been merged, or a comment that a previously disabled feature is not enabled by default)."
(this should read "now enabled by default", rather than "not"). 🙈
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/f75f277a-11ca-4482-9af0-7764f1241eafn%40chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/293471ff-f32c-4223-b2cd-994d5d018c59n%40chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/d1d0560a-88b3-3b26-2101-9fc6043e223a%40igalia.com.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAKXHy%3DcbTVJtque1KL_gqYM4-CY6X99sELS7XB%3DW-rUKZf_5CQ%40mail.gmail.com.
No, it's my bad.I'm planning to ship this in 106.Thanks!