Intent to implement and ship: URLSearchParams.sort()

59 views
Skip to first unread message

Takeshi Yoshino

unread,
Jun 26, 2017, 4:18:31 AM6/26/17
to blink-dev
Contact emails


Spec


TAG review: Skipped. Small change.

Summary / Motivation

Allows URLSearchParams to sort the queries in it easily. It's useful for getting higher cache hit rate as discussed in https://github.com/whatwg/url/issues/26.

Interoperability and Compatibility risk

Firefox:
Implemented and already shipped in Firefox 54

WebKit:
Implemented

Will this feature be supported on all six Blink platforms?

Yes

Demo link

See the WPT file below.

Debuggability

N/A

Is this feature fully tested by web-platform-tests?

Yes, by url/urlsearchparams-sort.html

Ongoing technical constraints

None

OWP launch tracking bug

As it's a small change (just 1 method), there's only a normal bug.

Link to entry on the feature dashboard


Requesting approval to ship?

Yes

Rick Byers

unread,
Jun 26, 2017, 10:15:21 AM6/26/17
to Takeshi Yoshino, blink-dev
LGTM1

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH9hSJYcgsqw0MtH7mQL%2B_mK83wpjDQL_JCmZv%2Bn8N07ee2giQ%40mail.gmail.com.

Mike West

unread,
Jun 26, 2017, 3:21:10 PM6/26/17
to Rick Byers, Takeshi Yoshino, blink-dev

TAMURA, Kent

unread,
Jun 27, 2017, 2:21:41 AM6/27/17
to Mike West, Rick Byers, Takeshi Yoshino, blink-dev
LGTM3.


Takeshi Yoshino

unread,
Jun 28, 2017, 8:59:26 AM6/28/17
to TAMURA, Kent, Mike West, Rick Byers, blink-dev
Thanks for reviewing. With 3 LGTMs, I'm shipping it at https://chromium-review.googlesource.com/c/515243/.
Reply all
Reply to author
Forward
0 new messages