Question : How to create *-expected.png for blink_web_tests

41 views
Skip to first unread message

Jihwan Kim

unread,
Mar 14, 2022, 2:39:40 AM3/14/22
to blink-dev
I'm fixing issue with pickers, but some tests failed.
It was a failure due to image diff.

Since the resource (css) file is modified, it is correct that the image diff appears,
So I have to modify the some *-expected.png files.
(ex: datetimelocal-month-year-selector-expected.png)

And my question is -
Are there any rules or tools to create *-expected.png?
or is it manual work (crop after screen capture, etc.)?

This is my first time about an image comparison test,
so please understand even if the question is too basic.

Mathias Bynens

unread,
Mar 14, 2022, 3:32:31 AM3/14/22
to Jihwan Kim, blink-dev

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/dee25422-6fd2-4d08-9883-d9b3d345c7fen%40chromium.org.

Xianzhu Wang

unread,
Mar 14, 2022, 3:41:30 AM3/14/22
to Mathias Bynens, Jihwan Kim, blink-dev

Jihwan Kim

unread,
Mar 14, 2022, 9:01:19 AM3/14/22
to blink-dev, Xianzhu Wang, Jihwan Kim, blink-dev, Mathias Bynens
Thanks for help!

I have one more question.
There are 3 platforms on WPT. (Linux, Mac, Windows)
In this case, to create new *-expected.png, should I have all these three devices?

2022년 3월 14일 월요일 오후 4시 41분 30초 UTC+9에 Xianzhu Wang님이 작성:

Xianzhu Wang

unread,
Mar 14, 2022, 10:00:24 AM3/14/22
to Jihwan Kim, blink-dev, Mathias Bynens
  • blink_tool.py rebaseline-cl: can rebaseline for all platforms.
  • run_web_tests.py --reset-results: can rebaseline for your current platform, or if the baseline is not platform-dependent.
  • rebaseline script in results.html: can rebaseline for a particular platform (which can be different from your current platform) at a time, or if the baseline is not platform-dependent.
See the how-to-rebaseline document for more details about the above options.

Jihwan Kim

unread,
Mar 14, 2022, 10:27:05 AM3/14/22
to blink-dev, Xianzhu Wang, blink-dev, Mathias Bynens, Jihwan Kim
Really really thanks!
have  a good day :)

2022년 3월 14일 월요일 오후 11시 0분 24초 UTC+9에 Xianzhu Wang님이 작성:
Reply all
Reply to author
Forward
0 new messages