Intent to Ship: Move onwebkit{animation,transition}XX handlers to GlobalEventHandlers

[Stephen Mcgruer]

Contact emails smcg...@chromium.org Explainer N/A Spec Specification: https://html.spec.whatwg.org/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects (onwebkitanimationend, onwebkitanimationiteration, onwebkitanimationstart, onwebkittransitionend) Summary Currently, the prefixed onwebkit{animation,transition}XX handlers are only available on the Window object in Chrome. By the spec[0], these should be on GlobalEventHandlers[1] - i.e. available on HTMLElement, Document, and Window. Note that although standardized, these event handlers are still obsolete - web developers should use the non-prefixed versions instead! [0]: https://html.spec.whatwg.org/multipage/webappa [1]: https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers

Link to "Intent to Prototype" blink-dev discussion N/A - this is a direct Intent to Ship.

Motivation This fix brings us into line with the spec, Gecko, and WebKit. Risks

Interoperability and Compatibility This change should be a win for interoperability and compatibility, since it brings us in line with the other browsers. The biggest risk is that web developers end up using the prefixed versions rather than the non-prefixed versions. Note that this already happens today, the high usage is why we spec'd these handlers rather than deprecate them! Firefox: Shipped (https://searchfox.org/mozilla-central/rev/9415ecf29ba1acbef9381335e0ecde5916ca4073/dom/webidl/EventHandler.webidl#138-141) Edge: No public signals Safari: Shipped (https://github.com/WebKit/webkit/blob/8b95fadedc51b4dd26cfff21fe4cad6a78d84177/Source/WebCore/dom/Element.idl#L117-L120) Safari incorrectly specs the handlers on Window and Element rather than GlobalEventHandlers; this means they are missing Document. Web developers: No signals

Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)? Yes Is this feature fully tested by web-platform-tests? Yes

https://wpt.fyi/results/html/dom/ (all the idlharness tests) https://wpt.fyi/results/html/webappapis/scripting/events/event-handler-all-global-events.html https://chromium-review.googlesource.com/c/chromium/src/+/1807190 (tests for specific interactions above and beyond the API tests) Firefox currently passes almost every test (one bug with case sensitivity), Chrome will pass every test once this I2S is implemented, and Safari passes most tests (excepting the Document problem noted above). Link to entry on the Chrome Platform Status https://www.chromestatus.com/feature/4833112531927040

[Rick Byers]

LGTM1

It's always sad to have to continue to maintain and improve obsolete prefixed APIs, but the alternative is worse :-). Thanks for pragmatically driving interop!

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADY3Mad%3DWOB%2BabquaX8mKoQXv6GE6TuK2N-hCq_VHutX1H9QoQ%40mail.gmail.com.

[Boris Zbarsky]

On 1/10/20 10:03 AM, Stephen Mcgruer wrote:
> Firefox currently passes almost every test (one bug with case sensitivity),

Stephen,

Thank you for the thorough tests! I filed
https://bugzilla.mozilla.org/show_bug.cgi?id=1608498 to track this.

-Boris

[PhistucK]

It would be nice to file a bug with WebKit regarding their missing implementation...

☆PhistucK

--

[Stephen Mcgruer]

A very good suggestion Phistuck; https://bugs.webkit.org/show_bug.cgi?id=206170 filed

[Philip Jägenstedt]

LGTM2

If we keep either removing or standardizing webkit-prefixed APIs, then soon enough there won't be any left in limbo and we can worry about interop in other areas :)

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADY3MacZ6DvBvLOYYmhr%3DdTVaWzeG%2B1VY3R_tTvJP%3DpZxMgitA%40mail.gmail.com.

[Daniel Bratell]

LGTM3

/Daniel

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAARdPYedv55ym4MvZqoxn2%3DG2aFkOkYGvRu7PWajrMk0hEqXcA%40mail.gmail.com.