Intent to Ship: AbortSignal in addEventListener
144 views
Skip to first unread message
Joey Arhar
Jan 25, 2021, 9:00:04 PM1/25/21
to blink-dev
Contact emails
jar...@chromium.orgExplainer
NoneSpecification
https://github.com/whatwg/dom/pull/919Summary
This feature adds a new AbortSignal option, named "signal", to the options parameter of addEventListener(). The "signal" option must first be created by an AbortController by accessing the "signal" property on an AbortController instance. Once the signal is passed in to addEventListener, calling "abort()" on the AbortController will remove the event listener added with addEventListener. For more context, see https://github.com/whatwg/dom/issues/911.
Blink component
Blink>DOMTAG review
https://github.com/w3ctag/design-reviews/issues/569TAG review status
PendingRisks
Interoperability and Compatibility
Gecko: Shipped
Edge: No signal
WebKit: Shipped
Web developers: No signals
Is this feature fully tested by web-platform-tests?
Yeshttps://wpt.fyi/results/dom/events/AddEventListenerOptions-signal.any.html
Tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1146467Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5658622220566528Links to previous Intent discussions
Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/9396JedBBOM/m/OfeJ4z1OAQAJThis intent message was generated by Chrome Platform Status.
Yoav Weiss
Jan 26, 2021, 5:02:33 AM1/26/21
to Joey Arhar, Thomas Steiner, blink-dev
LGTM1
On Tue, Jan 26, 2021 at 2:59 AM Joey Arhar <jar...@chromium.org> wrote:
Contact emails
jar...@chromium.orgExplainer
NoneSpecification
https://github.com/whatwg/dom/pull/919Summary
This feature adds a new AbortSignal option, named "signal", to the options parameter of addEventListener(). The "signal" option must first be created by an AbortController by accessing the "signal" property on an AbortController instance. Once the signal is passed in to addEventListener, calling "abort()" on the AbortController will remove the event listener added with addEventListener. For more context, see https://github.com/whatwg/dom/issues/911.
Blink component
Blink>DOMTAG review
https://github.com/w3ctag/design-reviews/issues/569TAG review status
PendingRisks
Brand new! :)
Web developers: No signals
I don't know if this is an accurate description, as it seems like the HTML issue was started by a web developer. It also feels like something web developers would have strong opinions on :)
+Thomas Steiner would it be a good exercise to try the https://goo.gle/developer-signals process in this case and see what it gives?
Is this feature fully tested by web-platform-tests?
Yes
https://wpt.fyi/results/dom/events/AddEventListenerOptions-signal.any.htmlTracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1146467Link to entry on the Chrome Platform Status
https://chromestatus.com/feature/5658622220566528Links to previous Intent discussions
Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/9396JedBBOM/m/OfeJ4z1OAQAJThis intent message was generated by Chrome Platform Status.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwJz-dRuFqXQWKzBrn0-z68GcDpphG6pf--DZPsBzPEymg%40mail.gmail.com.
Manuel Rego Casasnovas
Jan 26, 2021, 5:09:51 AM1/26/21
to Yoav Weiss, Joey Arhar, Thomas Steiner, blink-dev
LGTM2
On 26/01/2021 11:02, Yoav Weiss wrote:
> LGTM1
>
> On Tue, Jan 26, 2021 at 2:59 AM Joey Arhar <jar...@chromium.org
> <mailto:jar...@chromium.org>> wrote:
>
>
> Contact emails
>
> jar...@chromium.org <mailto:jar...@chromium.org>
>
>
>
> Blink component
>
> Blink>DOM
> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EDOM>
>
>
> TAG review
>
> https://github.com/w3ctag/design-reviews/issues/569
>
> Edge: No signal
>
> WebKit: Shipped <https://trac.webkit.org/changeset/271806/webkit>
>
> Yes
> https://wpt.fyi/results/dom/events/AddEventListenerOptions-signal.any.html
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEjTQGoPUm_EkEJOkePX4Nb7BN%2BmN0T46d5JpnoRdWGcaA%40mail.gmail.com?utm_medium=email&utm_source=footer>.
On 26/01/2021 11:02, Yoav Weiss wrote:
> LGTM1
>
> On Tue, Jan 26, 2021 at 2:59 AM Joey Arhar <jar...@chromium.org
> <mailto:jar...@chromium.org>> wrote:
>
>
> Contact emails
>
>
>
> Explainer
>
> None
>
>
> Specification
>
> https://github.com/whatwg/dom/pull/919
> <https://github.com/whatwg/dom/pull/919>
>
>
> Summary
>
> This feature adds a new AbortSignal option, named "signal", to the
> options parameter of addEventListener(). The "signal" option must
> first be created by an AbortController by accessing the "signal"
> property on an AbortController instance. Once the signal is passed
> in to addEventListener, calling "abort()" on the AbortController
> will remove the event listener added with addEventListener. For more
> context, see https://github.com/whatwg/dom/issues/911
> <https://github.com/whatwg/dom/issues/911>.
>
> Explainer
>
> None
>
>
> Specification
>
> https://github.com/whatwg/dom/pull/919
> <https://github.com/whatwg/dom/pull/919>
>
>
> Summary
>
> This feature adds a new AbortSignal option, named "signal", to the
> options parameter of addEventListener(). The "signal" option must
> first be created by an AbortController by accessing the "signal"
> property on an AbortController instance. Once the signal is passed
> in to addEventListener, calling "abort()" on the AbortController
> will remove the event listener added with addEventListener. For more
> context, see https://github.com/whatwg/dom/issues/911
>
>
>
> Blink component
>
> Blink>DOM
> <https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EDOM>
>
>
> TAG review
>
> https://github.com/w3ctag/design-reviews/issues/569
> <https://github.com/w3ctag/design-reviews/issues/569>
>
>
> TAG review status
>
> Pending
>
>
> Risks
>
>
>
> Interoperability and Compatibility
>
>
>
> Gecko: Shipped <https://hg.mozilla.org/mozilla-central/rev/b3d0fba5fd8d>
>
>
> TAG review status
>
> Pending
>
>
> Risks
>
>
>
> Interoperability and Compatibility
>
>
>
>
> Edge: No signal
>
> WebKit: Shipped <https://trac.webkit.org/changeset/271806/webkit>
>
>
> Brand new! :)
>
>
>
> Web developers: No signals
>
>
> I don't know if this is an accurate description, as it seems like the
> HTML issue was started by a web developer. It also feels like something
> web developers would have strong opinions on :)
> +Thomas Steiner <mailto:to...@google.com> would it be a good exercise to
>
> Brand new! :)
>
>
>
> Web developers: No signals
>
>
> I don't know if this is an accurate description, as it seems like the
> HTML issue was started by a web developer. It also feels like something
> web developers would have strong opinions on :)
> try the https://goo.gle/developer-signals
> <https://goo.gle/developer-signals> process in this case and see what it
> gives?
>
>
>
> Is this feature fully tested by web-platform-tests
> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?
> <https://goo.gle/developer-signals> process in this case and see what it
> gives?
>
>
>
> Is this feature fully tested by web-platform-tests
>
> Yes
> https://wpt.fyi/results/dom/events/AddEventListenerOptions-signal.any.html
> <https://wpt.fyi/results/dom/events/AddEventListenerOptions-signal.any.html>
>
>
> Tracking bug
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=1146467
> <https://bugs.chromium.org/p/chromium/issues/detail?id=1146467>
>
>
> Link to entry on the Chrome Platform Status
>
> https://chromestatus.com/feature/5658622220566528
> <https://chromestatus.com/feature/5658622220566528>
>
>
> Links to previous Intent discussions
>
> Intent to prototype:
> https://groups.google.com/a/chromium.org/g/blink-dev/c/9396JedBBOM/m/OfeJ4z1OAQAJ
> <https://groups.google.com/a/chromium.org/g/blink-dev/c/9396JedBBOM/m/OfeJ4z1OAQAJ>
>
>
> This intent message was generated by Chrome Platform Status
> <https://www.chromestatus.com/>.
>
>
> Tracking bug
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=1146467
> <https://bugs.chromium.org/p/chromium/issues/detail?id=1146467>
>
>
> Link to entry on the Chrome Platform Status
>
> https://chromestatus.com/feature/5658622220566528
> <https://chromestatus.com/feature/5658622220566528>
>
>
> Links to previous Intent discussions
>
> Intent to prototype:
> https://groups.google.com/a/chromium.org/g/blink-dev/c/9396JedBBOM/m/OfeJ4z1OAQAJ
> <https://groups.google.com/a/chromium.org/g/blink-dev/c/9396JedBBOM/m/OfeJ4z1OAQAJ>
>
>
> This intent message was generated by Chrome Platform Status
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to blink-dev+...@chromium.org
> <mailto:blink-dev+...@chromium.org>.
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it,
> send an email to blink-dev+...@chromium.org
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwJz-dRuFqXQWKzBrn0-z68GcDpphG6pf--DZPsBzPEymg%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwJz-dRuFqXQWKzBrn0-z68GcDpphG6pf--DZPsBzPEymg%40mail.gmail.com?utm_medium=email&utm_source=footer>.
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAK6btwJz-dRuFqXQWKzBrn0-z68GcDpphG6pf--DZPsBzPEymg%40mail.gmail.com
>
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blink-dev+...@chromium.org
> <mailto:blink-dev+...@chromium.org>.
> --
> You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to blink-dev+...@chromium.org
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEjTQGoPUm_EkEJOkePX4Nb7BN%2BmN0T46d5JpnoRdWGcaA%40mail.gmail.com
> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEjTQGoPUm_EkEJOkePX4Nb7BN%2BmN0T46d5JpnoRdWGcaA%40mail.gmail.com?utm_medium=email&utm_source=footer>.
Joey Arhar
Jan 28, 2021, 11:38:53 AM1/28/21
to Manuel Rego Casasnovas, Thomas Steiner, Yoav Weiss, blink-dev
The TAG review was just approved:
Mike West
Jan 28, 2021, 3:07:51 PM1/28/21
to blink-dev, Joey Arhar, Thomas Steiner, yo...@yoav.ws, blink-dev, Manuel Rego
LGTM3.
Reply all
Reply to author
Forward
0 new messages