Intent to Ship 'white-space: break-spaces'

98 views
Skip to first unread message

Javier Fernandez

unread,
Apr 23, 2019, 6:40:11 AM4/23/19
to blin...@chromium.org
Contact emails

jfern...@igalia.com


Spec

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces


Summary

This white-space:break-spaces feature allows authors to specify that any sequence of preserved white space, that would otherwise overflow the line and hang as per Trimming and Positioning, must be broken.

See the intent to implement discussion for additional details. I'd like to clarify that this feature was initially defined for the 'overflow-wrap' property, but the the CSS WG finally resolved to move it to the 'white-space' property.

Is this feature supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes


Risks

Interoperability and Compatibility

This is a new value added to the white-space CSS property, hence it won't break any previous content that may use such property.

The feature has been implemented in Safari and has positive feedback from Firefox developers.


Edge: No signals

Firefox: Under consideration (bug)

Safari: Shipped in Technology Preview (revision)

Web developers:

- Florian Rivoal presentation about new Line Breaking features

- Chris Coyier article about Line Breaking properties


Is this feature fully tested by web-platform-tests? Link to test suite results from wpt.fyi.

The CSS Text test suite has quite good coverage of he feature.


Entry on the feature dashboard

https://www.chromestatus.com/features/4842781306519552

Daniel Bratell

unread,
Apr 23, 2019, 12:31:16 PM4/23/19
to blin...@chromium.org, Javier Fernandez
LGTM1

/Daniel
--
/* Opera Software, Linköping, Sweden: CET (UTC+1) */

Ian Kilpatrick

unread,
Apr 23, 2019, 1:48:45 PM4/23/19
to Daniel Bratell, blin...@chromium.org, Javier Fernandez, Florian Rivoal
The test suite doesn't seem to have any tests on inline-level elements. E.g. <span style="white-space: break-spaces;"> XX XX</span> or in combination (nested potentially) with other modes. Does this value apply to inline-level elements?
  

Entry on the feature dashboard

https://www.chromestatus.com/features/4842781306519552




--
/* Opera Software, Linköping, Sweden: CET (UTC+1) */

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/op.z0pj53q6rbppqq%40cicero2.linkoping.osa.

Javier Fernandez

unread,
Apr 24, 2019, 6:17:16 AM4/24/19
to Ian Kilpatrick, Florian Rivoal, blin...@chromium.org, Florian Rivoal
Hi Ian,

On 23/4/19 19:48, 'Ian Kilpatrick' via blink-dev wrote:

Is this feature fully tested by web-platform-tests? Link to test suite results from wpt.fyi.

The CSS Text test suite has quite good coverage of he feature.



The test suite doesn't seem to have any tests on inline-level elements. E.g. <span style="white-space: break-spaces;"> XX XX</span> or in combination (nested potentially) with other modes. Does this value apply to inline-level elements?
  


The white-spaces CSS property applies only to inline boxes. 

Regarding the lack of tests using span elements, I'm not sure these will provide different code coverage or functionality. Regarding the combination with other layout models, considering that this feature is just  a new value to an already existent CSS property, I don't see the need of defining such combinations that we are not testing for the rest of the property's values (neither for most of the line-breaking properties, as far as I know).

Yoav Weiss

unread,
Apr 24, 2019, 6:38:26 AM4/24/19
to Javier Fernandez, blin...@chromium.org
You seem to be using an old template :|

On Tue, Apr 23, 2019 at 12:40 PM Javier Fernandez <jfern...@igalia.com> wrote:
Contact emails

jfern...@igalia.com


Spec

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces


Summary

This white-space:break-spaces feature allows authors to specify that any sequence of preserved white space, that would otherwise overflow the line and hang as per Trimming and Positioning, must be broken.

See the intent to implement discussion for additional details. I'd like to clarify that this feature was initially defined for the 'overflow-wrap' property, but the the CSS WG finally resolved to move it to the 'white-space' property.


Have you filed for a TAG review?
 


Is this feature supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes


Risks

Interoperability and Compatibility

This is a new value added to the white-space CSS property, hence it won't break any previous content that may use such property.

The feature has been implemented in Safari and has positive feedback from Firefox developers.


Edge: No signals

Firefox: Under consideration (bug)

Safari: Shipped in Technology Preview (revision)

Web developers:

- Florian Rivoal presentation about new Line Breaking features

- Chris Coyier article about Line Breaking properties


Ergonomics or activation risks?

Debuggability?
 


Is this feature fully tested by web-platform-tests? Link to test suite results from wpt.fyi.

The CSS Text test suite has quite good coverage of he feature.


Entry on the feature dashboard

https://www.chromestatus.com/features/4842781306519552

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

flo...@rivoal.net

unread,
Apr 24, 2019, 6:57:42 AM4/24/19
to blink-dev, bra...@opera.com, jfern...@igalia.com, flo...@rivoal.net

The test suite doesn't seem to have any tests on inline-level elements. E.g. <span style="white-space: break-spaces;"> XX XX</span> or in combination (nested potentially) with other modes. Does this value apply to inline-level elements?


All values of this property apply to inline elements, and there are a few tests for that in the test suite (which also includes the css2.1 test suite), but it's indeed an area with relatively few tests, and I am planning to write some more.

break-spaces isn't particularly risky in that regard, as it shares a large part of its behavior with the existing pre-wrap value, but I'll be sure to test nonetheless.

flo...@rivoal.net

unread,
Apr 24, 2019, 7:04:30 AM4/24/19
to blink-dev, jfern...@igalia.com

Have you filed for a TAG review?

Spec co-editor here. No we haven't asked, because we didn't particularly feel the need to: this is a relatively small addition to an existing system, and asking the TAG for this kind of thing seems overkill. Moreover, two member of the TAG (David Baron and Peter Linss) are members of the CSSWG and were present during the relevant teleconf / meetings. Neither of them have raised any concern.

So, all in all, we could ask the full TAG for a formal review, but for a small incremental addition, the informal review we got thanks to 2 TAG members being in the group feels sufficient to me.

—Florian

Javier Fernandez

unread,
Apr 24, 2019, 7:26:10 AM4/24/19
to blin...@chromium.org
Hi Yoav,

On 24/4/19 12:38, Yoav Weiss wrote:
You seem to be using an old template :|

On Tue, Apr 23, 2019 at 12:40 PM Javier Fernandez <jfern...@igalia.com> wrote:
Contact emails

jfern...@igalia.com


Spec

https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces


Summary

This white-space:break-spaces feature allows authors to specify that any sequence of preserved white space, that would otherwise overflow the line and hang as per Trimming and Positioning, must be broken.

See the intent to implement discussion for additional details. I'd like to clarify that this feature was initially defined for the 'overflow-wrap' property, but the the CSS WG finally resolved to move it to the 'white-space' property.


Have you filed for a TAG review?
 


Is this feature supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?

Yes


Risks

Interoperability and Compatibility

This is a new value added to the white-space CSS property, hence it won't break any previous content that may use such property.

The feature has been implemented in Safari and has positive feedback from Firefox developers.


Edge: No signals

Firefox: Under consideration (bug)

Safari: Shipped in Technology Preview (revision)

Web developers:

- Florian Rivoal presentation about new Line Breaking features

- Chris Coyier article about Line Breaking properties


Ergonomics or activation risks?


Ergonomics
The feature is not intended to be used in combination with any other platform API; it's just a new way of handling white spaces in the line breaking process during layout.

Activation
Web authors will be able to use the feature immediately and transparently after the activation.

Debuggability?

Debuggability
The white-space property is already visible by the available Dev Tools, and the new value will be parsed correctly once the feature is activated.



 


Is this feature fully tested by web-platform-tests? Link to test suite results from wpt.fyi.

The CSS Text test suite has quite good coverage of he feature.


Entry on the feature dashboard

https://www.chromestatus.com/features/4842781306519552

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/666a84d0-153d-4c6f-73df-ea41847ab184%40igalia.com.
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

Yoav Weiss

unread,
Apr 24, 2019, 7:29:40 AM4/24/19
to Javier Fernandez, blink-dev
LGTM2, given Safari already shipping and the presence of TAG members in relevant spec discussion.


Chris Harrelson

unread,
Apr 30, 2019, 1:09:57 PM4/30/19
to Yoav Weiss, Javier Fernandez, blink-dev
Reply all
Reply to author
Forward
0 new messages