Contact emails
alm...@microsoft.com,
ra...@microsoft.com
Explainer
N/A
Spec
https://drafts.csswg.org/css-color-4/#css-system-colors
Summary
Support for the new system color keywords, Canvas and Text, from CSS Color Module Level 4. Canvas maps to the existing Window system color keyword, and Text maps to the existing WindowText system color keyword.
Link to “Intent to Implement” blink-dev discussion
N/A
Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
Yes, the keywords themselves will be supported on all platforms, but they will only evaluate to associated system colors on Windows and Mac.
Note: Text has already been exposed as a system color keyword on Mac.
Risks
Interoperability and Compatibility
Firefox: No public signals
Edge: No public signals
Safari: No public signals
Web developers: No public signals
Ergonomics
At this time, Canvas and Text will be supported in tandem with Window and WindowText. As such, Canvas and Text can be thought of as aliases for Window and WindowText.
Security
System color keywords can be used for fingerprinting as they can be used to expose a user preference. However, Canvas and Text do not add any additional security threats since Window and WindowText are already exposed.
(https://drafts.csswg.org/css-color-4/#priv-sec)
Demo
Sample HTML:
<style>
body {
background: Canvas;
color: Text;
}
</style>
<body>
Sample text.
</body>
Is this feature fully tested by web-platform-tests?
No, since system colors are platform dependent, web-platform tests were not added. Canvas and Text are tested, along with the other system color keywords, in internal Chromium web tests and browser tests.
Tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1015968
Entry on the feature dashboard
N/A
Related CL
https://chromium-review.googlesource.com/c/chromium/src/+/1864378
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/DM5PR00MB0407F4AB72EB2AD4A90392978A690%40DM5PR00MB0407.namprd00.prod.outlook.com.
Thanks Joe! I’ve added a new Chrome Status entry for Canvas and Text: https://www.chromestatus.com/feature/5678291530809344
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/220db1c9-9bc0-4e9a-9137-02b21e5b5d20%40chromium.org.
Good seeing more of CSS 4 coming. Some comments though.
There should have been a section with a link to a TAG review or alternatively an explanation why a TAG review is not necessary. I suspect that you think the latter, but it needs to be there to save us time.
I think there are probably some things you can test with Web
Platform Tests even if the pixel output will be unpredictable.
Things like parsing and serialization of of color values for
instance. Quite possibly there are already similar tests that can
be expanded. If they are also to be equivalent to other values, it
will be possible to test that they are treated the same (if that
is not an implementation detail).
Interoperability is important so you should see if you can get other vendors to pick up this. I suspect it might not be that hard to implement so if you only get their attention, they might react positively, or maybe know of a good reason for not to implement it. At the very least you can make sure webkit and mozilla both have bugs to track this feature and link them here.
/Daniel
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAJUhtG_Ga_dWyYGLx4qRF3F1QXNKbv%3DLGv2Cvfo4yTgK_NECLw%40mail.gmail.com.
- Canvas and Text are aliases for existing system color keywords, so a TAG review is not needed.- A WPT test for parsing/serialization has been added to the in-progress CL: https://github.com/web-platform-tests/wpt/pull/19856- I have filed bugs with mozilla and webkit to track this feature: https://bugzilla.mozilla.org/show_bug.cgi?id=1590894, https://bugs.webkit.org/show_bug.cgi?id=203319
Contact emails
alm...@microsoft.com, ra...@microsoft.com
Explainer
N/A
Spec
https://drafts.csswg.org/css-color-4/#css-system-colors
Summary
Support for the new system color keywords, Canvas and Text, from CSS Color Module Level 4. Canvas maps to the existing Window system color keyword, and Text maps to the existing WindowText system color keyword.
Link to “Intent to Implement” blink-dev discussion
N/A
Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
Yes, the keywords themselves will be supported on all platforms, but they will only evaluate to associated system colors on Windows and Mac.
Note: Text has already been exposed as a system color keyword on Mac.
Risks
Interoperability and Compatibility
Firefox: No public signals
Edge: No public signals
Safari: No public signals
Web developers: No public signals
Ergonomics
At this time, Canvas and Text will be supported in tandem with Window and WindowText. As such, Canvas and Text can be thought of as aliases for Window and WindowText.
Security
System color keywords can be used for fingerprinting as they can be used to expose a user preference. However, Canvas and Text do not add any additional security threats since Window and WindowText are already exposed.
(https://drafts.csswg.org/css-color-4/#priv-sec)
Demo
Sample HTML:
<style>
body {
background: Canvas;
color: Text;
}
</style>
<body>
Sample text.
</body>
Is this feature fully tested by web-platform-tests?
Since system colors are platform dependent, web-platform tests for the calculation of system colors were not added. Instead, the calculation of Canvas and Text are tested, along with the other system color keywords, in internal Chromium web tests and browser tests.
Tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=1015968
Entry on the feature dashboard
Thanks for the feedback, Daniel. I have updated the message below to include your suggestions.To summarize:
- Canvas and CanvasText are aliases for existing system color keywords, so a TAG review is not needed.
- A WPT test for parsing/serialization has been added to the in-progress CL: https://github.com/web-platform-tests/wpt/pull/19856- I have filed bugs with mozilla and webkit to track this feature: https://bugzilla.mozilla.org/show_bug.cgi?id=1590894, https://bugs.webkit.org/show_bug.cgi?id=203319
On Monday, October 21, 2019 at 9:17:27 AM UTC-7, Alison Maher wrote:
Contact emails
alm...@microsoft.com, ra...@microsoft.com
Explainer
N/A
Spec
https://drafts.csswg.org/css-color-4/#css-system-colors
Summary
Support for the new system color keywords, Canvas and CanvasText, from CSS Color Module Level 4. Canvas maps to the existing Window system color keyword, and CanvasText maps to the existing WindowText system color keyword.
Link to “Intent to Implement” blink-dev discussion
N/A
TAG ReviewCanvas and CanvasText are aliases for existing system color keywords, so a TAG review is not needed.
Will this feature be supported on all six Blink platforms (Windows, Mac, Linux, Chrome OS, Android, and Android WebView)?
Yes, the keywords themselves will be supported on all platforms, but they will only evaluate to associated system colors on Windows and Mac.
Risks
Interoperability and Compatibility
Firefox: No public signals
A bug has been filed to track this feature: https://bugzilla.mozilla.org/show_bug.cgi?id=1590894Edge: No public signals
Safari: No public signals
A bug has been filed to track this feature: https://bugs.webkit.org/show_bug.cgi?id=203319
Web developers: No public signals
Ergonomics
At this time, Canvas and CanvasText will be supported in tandem with Window and WindowText. As such, Canvas and CanvasText can be thought of as aliases for Window and WindowText.
Security
System color keywords can be used for fingerprinting as they can be used to expose a user preference. However, Canvas and CanvasText do not add any additional security threats since Window and WindowText are already exposed.
(https://drafts.csswg.org/css-color-4/#priv-sec)
Demo
Sample HTML:
<style>
body {
background: Canvas;
color: CanvasText;
}
</style>
<body>
Sample text.
</body>
Is this feature fully tested by web-platform-tests?
Web-platform tests for the parsing and serialization of Canvas and CanvasText have been added (https://github.com/web-platform-tests/wpt/pull/19856).Since system colors are platform dependent, web-platform tests for the calculation of system colors were not added. Instead, the calculation of Canvas and CanvasText are tested, along with the other system color keywords, in internal Chromium web tests and browser tests.
LGTM1
/Daniel
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/d2ce471d-7e2a-4be4-94a7-911533d11ed1%40chromium.org.
To unsubscribe from this group and stop receiving emails from it, send an email to blin...@chromium.org.
Hey Alison,Some dumb questions as this feature is a long way from my area of expertise:
- Do we have CSS WG resolutions that provide support for this design, or other public discussion of the design? Not having a TAG review filed is a bit of a risk factor, so I'd like to understand how "safe" this is.
- Is there any chance that the "Canvas" == "Window" and "Text" === "Window Text" equivalence will become unmoored in the future? Could they diverge?
- Do we know if this will cause any compat issues?
Thanks
--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/3322e1db-129d-4637-9e13-b8ca10155453%40chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw9nVnegGb_BxP%3DTAK8%3D%3D0wrD7x%3DYT_x3mNeXRuoNXkZFQ%40mail.gmail.com.