Hi Chris,
I think it makes sense. Perhaps it could be reworded such that we move the best practices part into the webview-changes doc (and add the outreach + analysis bits), so it takes up less space. Maybe:
--
You received this message because you are subscribed to the Google Groups "blink-api-owners-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to blink-api-owners-d...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-api-owners-discuss/f6d2b282-b890-20e5-2b45-0094f9ff7a95%40igalia.com.
I share Rego's concerns about this being a question that most Chromium devs won't be able to answer.We could reduce the "surface" by only raising that question in cases of removals or behavior changes (and not in case of shipping new features).Otherwise, it seems that the risks for WebView are similar to the risks elsewhere, only amplified.
I had assumed this was the proposal -
https://new.chromium.org/developers/webview-changes/ is largely
about deprecations and changing behavior of APIs (+ a bit about
large architecture changes), but I can see how that's not obvious
on re-read (and not sure if that was Chris' intent).
With that in mind, maybe the change we want is:
- Always include a feature flag for any removals or changes, that can enable us to disable it if we encounter issues (through Finch in case of Chrome. Other Chromiums have similar mechanisms)
- In case of removal or behavior change, loop in webview-dev and let them make the call of a certain change being a particularly high risk for them. For Enterprises, we do that manually. I wonder if the same would work for WebView.
WDYT?
That sounds fine to me, but maybe we should ask the android-webview-dev folks for their input (assuming this thread isn't the outcome of such a discussion already).
A questionnaire and review bit in the Chrome launch process is
another option, but maybe a heavy handed / super high bandwidth
one.
On 12/14/21 3:05 AM, Yoav Weiss wrote:
I share Rego's concerns about this being a question that most Chromium devs won't be able to answer.We could reduce the "surface" by only raising that question in cases of removals or behavior changes (and not in case of shipping new features).Otherwise, it seems that the risks for WebView are similar to the risks elsewhere, only amplified.I had assumed this was the proposal - https://new.chromium.org/developers/webview-changes/ is largely about deprecations and changing behavior of APIs (+ a bit about large architecture changes), but I can see how that's not obvious on re-read (and not sure if that was Chris' intent).
With that in mind, maybe the change we want is:
- Always include a feature flag for any removals or changes, that can enable us to disable it if we encounter issues (through Finch in case of Chrome. Other Chromiums have similar mechanisms)
- In case of removal or behavior change, loop in webview-dev and let them make the call of a certain change being a particularly high risk for them. For Enterprises, we do that manually. I wonder if the same would work for WebView.
WDYT?That sounds fine to me, but maybe we should ask the android-webview-dev folks for their input (assuming this thread isn't the outcome of such a discussion already).
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-api-owners-discuss/CA%2BN6QZvHZ06J7c4XtPy8aajAazpq%3Dy_pQLu8xXA%3Df0nwsDsDjg%40mail.gmail.com.
On Tue, Dec 14, 2021 at 6:40 AM Mike Taylor <mike...@chromium.org> wrote:On 12/14/21 3:05 AM, Yoav Weiss wrote:
I share Rego's concerns about this being a question that most Chromium devs won't be able to answer.We could reduce the "surface" by only raising that question in cases of removals or behavior changes (and not in case of shipping new features).Otherwise, it seems that the risks for WebView are similar to the risks elsewhere, only amplified.I had assumed this was the proposal - https://new.chromium.org/developers/webview-changes/ is largely about deprecations and changing behavior of APIs (+ a bit about large architecture changes), but I can see how that's not obvious on re-read (and not sure if that was Chris' intent).
My intent was indeed to restrict it to deprecations, changing behavior, or other risky architectural changes. Adjusted text for this point as well as the "what is high risk" below, bolding of new things:"(This section generally does not apply when shipping new APIs, just changes of behavior for existing APIs.)Does this intent have potentially high risk for Android WebView-based applications? (See here for more a definition of "potentially high risk", information on why changes to this platform carry higher risk, and general rules of thumb for which changes have higher or lower risk.) If so:
* Please explain what you've done (e.g. outreach to app developers, data analysis) to ensure smooth rollout on Android WebView.
* Please affirm that you've followed the following best practices:
1. Use a finch-based killswitch in case of compat issues
2. Reach out to android-webview-dev for advice and feedback on the risk level"
I that in mind, maybe the change we want is:
I think that is reasonable!
/Daniel
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-api-owners-discuss/CA%2BN6QZt99Oj%2BbLsz7mp-0fJBK68X6aBX%3D660vU%2BMKp8Sftzxyg%40mail.gmail.com.