Binary-Size: $TEXT not allowing commit?

Dale Curtis

unread,

Jun 25, 2021, 3:15:56 PM6/25/21

to binar...@chromium.org

On https://chromium-review.googlesource.com/c/chromium/src/+/2986157 I added a "Binary-Size: Size increase due to added NEON film grain optimizations." footer, but the android-binary-size CQ check is still complaining. Do I need a special lgtm from someone? The docs don't seem to mention anything like that.

https://chromium.googlesource.com/chromium/src/+/main/docs/speed/binary_size/android_binary_size_trybot.md

- dale

Andrew Grieve

unread,

Jun 25, 2021, 3:44:36 PM6/25/21

to Dale Curtis, binary-size

Just remove the blank line between:

Binary-Size: Size increase due to added NEON film grain optimizations.

Change-Id: I833

The bot is picky about "footers".

--
You received this message because you are subscribed to the Google Groups "binary-size" group.
To unsubscribe from this group and stop receiving emails from it, send an email to binary-size...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/binary-size/CAPUDrwepaHd86wxc1W756x2%3DhepG3Y6ekVVO_Z6OuVo9dBdB5Q%40mail.gmail.com.

Dale Curtis

unread,

Jun 25, 2021, 4:03:49 PM6/25/21

to Andrew Grieve, binary-size

Ah thanks!

- dale

Reply all

Reply to author

Forward