Cannot get test to pass binary size check

[Andres Medina]

Hi,

This CL

https://chromium-review.googlesource.com/c/chromium/src/+/2518036

I have not been able to make it pass Binary-Size test. I was able to do so in a previous patch, but now is just not passing. I thought it was the format of the Binary-Size piece in the commit message. I've tried several formats and non of them have worked, even formats that I have seen passed in this same CL.

Any advice? This is blocking a pretty large enabling in the Chromecast side.

Thanks,

.Andres

[Andrew Grieve]

It looks correct to me...

--
You received this message because you are subscribed to the Google Groups "binary-size" group.
To unsubscribe from this group and stop receiving emails from it, send an email to binary-size...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/binary-size/CAKKfFHKgqFA4Pzn3%2B%3DYQk6goN55-X%3Dh7%3Do1VS%2Bz8hTMKM%3DUdUQ%40mail.gmail.com.

[Andres Medina]

Sorry, thanks.

It seems my last change to limit the Binary-Size comment to a single line did the trick.

[Daniel Cheng]

I know this is somewhat orthogonal, but it looks like the new parser was originally guarded by GOOGLE_PROTOBUF_ENABLE_EXPERIMENTAL_PARSER. Presumably this is the only supported configuration now, making the binary size penalty unavoidable. Should we reach out to the protobuf maintainers to see if there's anything that can be done?

Daniel

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/binary-size/CAKKfFHJAUuG88nDgZBCzY_GLfJ06tzhrXoCZJPfsC4fZ1B8bhA%40mail.gmail.com.