Error in using 'delete' keyword in enum in idl

[pal...@chromium.org]

I need to use the 'delete' keyword in my record type enum for IndexedDb Observer idl.    ( https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md#records ).

Howver adding 'delete' to IndexdDbNames.in https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/indexeddb/IndexedDBNames.in  leads to generating an identifier called delete. 

This conflicts with delete being a keyword in C++ . 

Could anyone please help with this.

+dmuprh

[Daniel Murphy]

+Elliott Sprehn +jya...@google.com Dana says there was a discussion about enum style. Maybe the bindings could expect/generate this style for the C++ side here? This would avoid keyword conflicts.

[Daniel Murphy]

Based on make_names.py (which is the python script for this file. this differs between .in files), you can set the ImplementedAs= property? so do:

delete ImplementedAs=kDelete

We should probably change all of the them but that should be in a different patch.

[Elliott Sprehn]

Yeah we should rename all the enums in blink to kCamelCase style. The code generator should handle any fancy mappings.

[Ian Clelland]

The enum problem bit me yesterday, trying to add a new SHOUTY_CASE IDL constant. Blink style checks really don't like that. Perhaps if I have some time on a flight to Munich tomorrow I'll take a look at renaming them.

I do think the original issue is solvable with the ImplementedAs IDL attribute, though. I had to do the same thing with the 'register' method on SyncManager: (https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/background_sync/SyncManager.idl)

--
You received this message because you are subscribed to the Google Groups "platform-architecture-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to platform-architect...@chromium.org.
To post to this group, send email to platform-arc...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/platform-architecture-dev/CAO9Q3i%2BfAF-_gyU6sJXQ39fjhtqQUaM57GZ%2BcUWfLvCfT4ZuTQ%40mail.gmail.com.

[Ian Clelland]

I have a 90% mechanical CL to do this: replacing any all-caps IDL constants with kBlinkStyleConformant ones in the reflected C++ code. (The bindings generation code is updated to just generate the correct names; the other 10% of the CL is me verifying that my search+replace isn't being overzealous with things like comments, and updating ASSERTs when the style checker forces me to)

See https://codereview.chromium.org/2068053002/ if this still seems like a good thing to do.

[Elliott Sprehn]

I'm happy with that if other people are. It does diverge our code a bit from the web, but it makes all our constants consistent which is nice. In general I'd like to rename all of the enums in the codebase this way.

[Kentaro Hara]

I'm happy with the change.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/platform-architecture-dev/CAO9Q3i%2BY%2BcCNWrzDuAf5Ped%2BD4W-5zxAAXVSa10s57-LqBtvMA%40mail.gmail.com.

--

Kentaro Hara, Tokyo, Japan

[Ian Clelland]

I haven't heard any objections to this plan in the last 30 days; I've been babysitting this CL, rebasing as necessary, for that time.

If no one else has any problems, then it sound like I should send out an announcement on blink-dev about the change and commit it.

Are there any other stakeholders I should reach out to first? Any other reasons to hold off on this any longer?

Thanks,

Ian

[Kentaro Hara]

I think we can make the change now.

[Daniel Murphy]

Digging this thread up because there's actually a problem with "ImplementedAs". It seems to change both the variable name AND the value of the enum we're using. So when we do:

delete ImplementedAs=kDelete

in IndexedDBNames.in, this generates

IndexedDBNames::kDelete in IndexedDBNames.h, but the value of this is 'kDelete', and I need it to be 'delete'.

Do we have a way of doing this?

Daniel

[Daniel Murphy]

(sending from chromium address)

Digging this thread up because there's actually a problem with "ImplementedAs". It seems to change both the variable name AND the value of the enum we're using. So when we do:

delete ImplementedAs=kDelete

in IndexedDBNames.in, this generates

IndexedDBNames::kDelete in IndexedDBNames.h, but the value of this is 'kDelete', and I need it to be 'delete'.

Do we have a way of doing this?

[Daniel Murphy]

Ah! I tried using

delete Symbol=kDelete

and that worked. Nevermind everyone!

[Elliott Sprehn]

Can you share your patch? I'm not sure I follow what you're doing here. :)

Ah! I tried using

To unsubscribe from this group and stop receiving emails from it, send an email to platform-architecture-dev+unsub...@chromium.org.
To post to this group, send email to platform-architecture-dev@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/platform-architecture-dev/CAO9Q3i%2BfAF-_gyU6sJXQ39fjhtqQUaM57GZ%2BcUWfLvCfT4ZuTQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "platform-architecture-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to platform-architecture-dev+unsub...@chromium.org.
To post to this group, send email to platform-architecture-dev@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/platform-architecture-dev/CAO9Q3i%2BY%2BcCNWrzDuAf5Ped%2BD4W-5zxAAXVSa10s57-LqBtvMA%40mail.gmail.com.

--

Kentaro Hara, Tokyo, Japan