services/network vs services/network/public/cpp

[John Abd-El-Malek]

Ken pointed out that in services, public/cpp is the client library which are convenience helpers for interacting with the service. That is different than the public directories of content or webkit, which contain C++ interfaces that are implemented or used by the private source.

Code outside of services/network, until the network service is the only path, will need to share code with the network service. That code can live in services/network. We don't need to wrap this code with public headers anymore (which was needed when it was in content/ because content/ could only be accessed from outside through content/public).

[Matt Menke]

So what about private files used exclusively by the files in public/cpp, where do they go?  I'm largely thinking of SimpleURLLoader - it has a bunch of classes in a private namespace which I think would be better organized in external files, I just didn't want to slime content/common or content/public/common with all of them.

On Wed, Jan 31, 2018 at 4:11 PM, 'John Abd-El-Malek' via network-service-dev <network-s...@chromium.org> wrote:

Ken pointed out that in services, public/cpp is the client library which are convenience helpers for interacting with the service. That is different than the public directories of content or webkit, which contain C++ interfaces that are implemented or used by the private source.

Code outside of services/network, until the network service is the only path, will need to share code with the network service. That code can live in services/network. We don't need to wrap this code with public headers anymore (which was needed when it was in content/ because content/ could only be accessed from outside through content/public).

--
You received this message because you are subscribed to the Google Groups "network-service-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to network-service-dev+unsub...@chromium.org.
To post to this group, send email to network-service-dev@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/network-service-dev/CALhVsw1B3U38YA4EmddXn7a6bRLhHZGoL6wj_ZXF8vO8ZAM1rQ%40mail.gmail.com.

[Ken Rockot]

They can still go in public/cpp. You can use GN to keep external targets from using them directly.

On Wed, Jan 31, 2018 at 1:54 PM, Matt Menke <mme...@chromium.org> wrote:

So what about private files used exclusively by the files in public/cpp, where do they go?  I'm largely thinking of SimpleURLLoader - it has a bunch of classes in a private namespace which I think would be better organized in external files, I just didn't want to slime content/common or content/public/common with all of them.

On Wed, Jan 31, 2018 at 4:11 PM, 'John Abd-El-Malek' via network-service-dev <network-service-dev@chromium.org> wrote:

Ken pointed out that in services, public/cpp is the client library which are convenience helpers for interacting with the service. That is different than the public directories of content or webkit, which contain C++ interfaces that are implemented or used by the private source.

Code outside of services/network, until the network service is the only path, will need to share code with the network service. That code can live in services/network. We don't need to wrap this code with public headers anymore (which was needed when it was in content/ because content/ could only be accessed from outside through content/public).

--
You received this message because you are subscribed to the Google Groups "network-service-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to network-service-dev+unsubscribe...@chromium.org.

To post to this group, send email to network-service-dev@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/network-service-dev/CALhVsw1B3U38YA4EmddXn7a6bRLhHZGoL6wj_ZXF8vO8ZAM1rQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "network-service-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to network-service-dev+unsub...@chromium.org.
To post to this group, send email to network-service-dev@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/network-service-dev/CAEK7mvqj_A70rSsdocDgu0ePLkrpoRvnVUHHG7M0pFY0N6KE6A%40mail.gmail.com.

[Ken Rockot]

Either through separate target visibility, or by taking advantage of the very nice but very infrequently used public target variable. I would encourage more use of the latter in general.

On Wed, Jan 31, 2018 at 1:56 PM, Ken Rockot <roc...@google.com> wrote:

They can still go in public/cpp. You can use GN to keep external targets from using them directly.

On Wed, Jan 31, 2018 at 1:54 PM, Matt Menke <mme...@chromium.org> wrote:

So what about private files used exclusively by the files in public/cpp, where do they go?  I'm largely thinking of SimpleURLLoader - it has a bunch of classes in a private namespace which I think would be better organized in external files, I just didn't want to slime content/common or content/public/common with all of them.

On Wed, Jan 31, 2018 at 4:11 PM, 'John Abd-El-Malek' via network-service-dev <network-service-dev@chromium.org> wrote:

Ken pointed out that in services, public/cpp is the client library which are convenience helpers for interacting with the service. That is different than the public directories of content or webkit, which contain C++ interfaces that are implemented or used by the private source.

Code outside of services/network, until the network service is the only path, will need to share code with the network service. That code can live in services/network. We don't need to wrap this code with public headers anymore (which was needed when it was in content/ because content/ could only be accessed from outside through content/public).

--
You received this message because you are subscribed to the Google Groups "network-service-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to network-service-dev+unsubscribe...@chromium.org.
To post to this group, send email to network-service-dev@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/network-service-dev/CALhVsw1B3U38YA4EmddXn7a6bRLhHZGoL6wj_ZXF8vO8ZAM1rQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "network-service-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to network-service-dev+unsubscribe...@chromium.org.
To post to this group, send email to network-service-dev@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/network-service-dev/CAEK7mvqj_A70rSsdocDgu0ePLkrpoRvnVUHHG7M0pFY0N6KE6A%40mail.gmail.com.