Layout Team Weekly Snippets - October 16, 2017

16 views
Skip to first unread message

Emil A Eklund

unread,
Oct 16, 2017, 2:46:36 PM10/16/17
to layou...@chromium.org, Philip Rogers
Please use the following document for Q4 OKR planning:
https://docs.google.com/document/d/1ci6s93m4r0bcuGHkVbyZ_VnVoOsUJsRjggwnZvbfuO8/edit
Please make sure it lists appropiate OKRs for you by the end of the day *today*!

Updates since October 9:
- Implemented hit testing for LayoutNG by walking the fragment tree to
find the element(s) for a given point. Implements the nodeAtPoint API
and supports crossing between legacy layout and LayoutNG.
- Started working on updating fragment painting to use the correct
paint order. Requires changes to how fragments are represented as the
type of fragment may dictate the paint order (e.x. inline blocks and
floats paint in different phases than other elements).
- Finishing up Q4 planning.
- 2018 planning.

This week:
- Finish paint order patch.
- Finishing up Q4 planning.
- 2018 planning.

As for discussion topics for tomorrows meeting I offer the following
suggestions:
- Caching in LayoutNG.
- Triggering prepare-layout on DOM changes only.
- Exposing more fine-grained layout information in tracing.

Please reply-all with your own update for last week and also indicate
if any of the proposed topics sounds interesting to you or if you have
another one you'd like to add to the agenda.

Philip Rogers

unread,
Oct 16, 2017, 3:50:39 PM10/16/17
to Emil A Eklund, layou...@chromium.org
More root layer scrolling (RLS) progress with 64 more passing layout tests:
* Fixed composited-scroll.js tests, fixing 12 root layer scrolling layout tests.
* Fixed iframe clip bug, fixing 33 root layer scrolling layout tests.
* Fixed scrollbar snapping bug, fixing non-rls as well as 19 rls layout tests.
All unit tests now pass with root layer scrolling.

Fixed a hit test regression in the compositor.
Landed a debugging patch for printing LayerTreeHostImpl (LayerListAsJson()).

Investigated a tough compositor and paint regression and rolled out one patch.


--
You received this message because you are subscribed to the Google Groups "layout-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+unsubscribe@chromium.org.
To post to this group, send email to layou...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CADu_oUAMZ%2Btw%3DUt6cUbwNvJDivMm_MZgt6Hj2TbOB-EWTnjkuw%40mail.gmail.com.

Steve Kobes

unread,
Oct 16, 2017, 4:52:01 PM10/16/17
to Philip Rogers, Emil A Eklund, layou...@chromium.org
[RLS]
- final review of fixed background painting, closed out old bugs
- landed fix for iframe borders (crrev.com/508878)
- fixed crash in try-flag (crrev.com/508777)
- working on try-flag trigger step

[other]
- preparing "Life of a Pixel"

Xiaocheng Hu

unread,
Oct 16, 2017, 5:33:01 PM10/16/17
to Steve Kobes, Philip Rogers, Emil A Eklund, layou...@chromium.org
Last week:
- Adding NG versions of position canonicalization functions
- Fixed some other random editing stuff

This week:
- Finish NG version of position canonicalization
- Prototype NG line mapping

--
You received this message because you are subscribed to the Google Groups "layout-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+unsubscribe@chromium.org.
To post to this group, send email to layou...@chromium.org.

Aleks Totic

unread,
Oct 16, 2017, 8:01:59 PM10/16/17
to Emil A Eklund, layou...@chromium.org

Last week was spent making LayoutTests better, some abspos, and minor ResizeObserver work.


# LayoutTests


test-expectations got a added text filter, and a progress bar  715336. I also have an oustanding CL to add flagging. With this CL, test-expectations will reach feature parity with results.html. The hope is that infra will be able to default to test-expectations, and my work here will be done.


I've added --skip-timeouts flag to run-webkit-tests. This flag has cut down the run time of complete local test suite from 20m to 8m. 710755


I've fixed an outstanding bug to make svg tests run in 800x600. The hope was that this would enable tests to be run faster in fully parallel mode. The speedup did not happen, but I got the peer bonus from pdr :-)


# Absolute positioning


Fix border writing mode mixup 709946


Made progress in always adding OOF children to Legacy. Hope to land this week, after I fix some unit tests. The interesting outstanding issue is that tests used to call NGBlockNode::Layout directly. This no longer works with OOF blocks, because now Legacy code also runs, which DCHECKs(IsInPerformLayout). This fails, because we are not doing legacy layout cycle.


# ResizeObserver


Got more feedback, and one more LGTM. One to go.


There was a lot of discussion about event vs. observer pattern. I need to summarize all the feedback, and call a meeting where we can make a decision (suggestion by dimitri).


Aleks

Yoichi Osato

unread,
Oct 17, 2017, 3:38:39 AM10/17/17
to Emil A Eklund, layou...@chromium.org
Finishing bushing up LayoutObject.SelectionState marking and invalidation.
Will start selection paint on NG.

2017年10月17日(火) 9:02 'Aleks Totic' via layout-dev <layou...@chromium.org>:
--
You received this message because you are subscribed to the Google Groups "layout-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+...@chromium.org.

To post to this group, send email to layou...@chromium.org.

Karl Anders Øygard

unread,
Oct 17, 2017, 1:05:40 PM10/17/17
to layout-dev
Various managerial responsibilities last week, so less than usual activity.

- Reworked the NG table cell patch (https://crrev.com/c/649698), the new approach should be easier on the eyes.
- Fixing a painting issue with legacy floats with margins.  Review forthcoming.

Karl
Reply all
Reply to author
Forward
0 new messages