google/tricky: Fix RW ramstage index [chromiumos/third_party/coreboot : firmware-tricky-5829.B]

[世璋 蔡 (Gerrit)]

Hello Stefan Reinauer, Duncan Laurie,

I'd like you to do a code review. Please visit

https://chromium-review.googlesource.com/203404

to review the following change.

Change subject: google/tricky: Fix RW ramstage index
......................................................................

google/tricky: Fix RW ramstage index

Without this patch coreboot will always use the read-only version
of ramstage, even if there is a read-write version available.
Signed-off-by: Justin Tsai <Justi...@quantatw.com>
BRANCH=tricky
BUG=chrome-os-partner:25870
TEST=Install different RO and RW version, check in cbmem log that
coreboot's romstage and ramstage have different timestamps
in their banners.

Change-Id: Ia8c5a76ce4fbb7c8aeb6fa175b0546cd59ccfdeb
(cherry picked from commit 495b5613ebe377f8087a70f292ff21b0aa1b7016)
Reviewed-by: Duncan Laurie <dla...@chromium.org>
Commit-Queue: Stefan Reinauer <rein...@chromium.org>
Tested-by: Stefan Reinauer <rein...@chromium.org>
---
M src/mainboard/google/tricky/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/mainboard/google/tricky/Kconfig
b/src/mainboard/google/tricky/Kconfig
index c41a1c9..33540f8 100644
--- a/src/mainboard/google/tricky/Kconfig
+++ b/src/mainboard/google/tricky/Kconfig
@@ -23,7 +23,7 @@

config VBOOT_RAMSTAGE_INDEX
hex
- default 0x2
+ default 0x1

config MAINBOARD_DIR
string

--
To view, visit https://chromium-review.googlesource.com/203404
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8c5a76ce4fbb7c8aeb6fa175b0546cd59ccfdeb
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/coreboot
Gerrit-Branch: firmware-tricky-5829.B
Gerrit-Owner: 世璋 蔡 <Justi...@quantatw.com>
Gerrit-Reviewer: Duncan Laurie <dla...@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <rein...@chromium.org>

[Stefan Reinauer (Gerrit)]

Stefan Reinauer has posted comments on this change.

Change subject: google/tricky: Fix RW ramstage index
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit https://chromium-review.googlesource.com/203404
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: Ia8c5a76ce4fbb7c8aeb6fa175b0546cd59ccfdeb
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/coreboot
Gerrit-Branch: firmware-tricky-5829.B
Gerrit-Owner: 世璋 蔡 <Justi...@quantatw.com>
Gerrit-Reviewer: Duncan Laurie <dla...@chromium.org>
Gerrit-Reviewer: Stefan Reinauer <rein...@chromium.org>

Gerrit-HasComments: No

[Justin Tsai (Gerrit)]

Justin Tsai has posted comments on this change.

Change subject: google/tricky: Fix RW ramstage index
......................................................................

Patch Set 1: Commit-Queue+1 Verified+1

--
To view, visit https://chromium-review.googlesource.com/203404
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: Ia8c5a76ce4fbb7c8aeb6fa175b0546cd59ccfdeb
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/coreboot
Gerrit-Branch: firmware-tricky-5829.B
Gerrit-Owner: 世璋 蔡 <Justi...@quantatw.com>
Gerrit-Reviewer: Duncan Laurie <dla...@chromium.org>

Gerrit-Reviewer: Justin Tsai <Justi...@quantatw.com>

[chrome-internal-fetch (Gerrit)]

chrome-internal-fetch has submitted this change and it was merged.

Change subject: google/tricky: Fix RW ramstage index
......................................................................


google/tricky: Fix RW ramstage index

Without this patch coreboot will always use the read-only version
of ramstage, even if there is a read-write version available.
Signed-off-by: Justin Tsai <Justi...@quantatw.com>
BRANCH=tricky
BUG=chrome-os-partner:25870
TEST=Install different RO and RW version, check in cbmem log that
coreboot's romstage and ramstage have different timestamps
in their banners.

Change-Id: Ia8c5a76ce4fbb7c8aeb6fa175b0546cd59ccfdeb
(cherry picked from commit 495b5613ebe377f8087a70f292ff21b0aa1b7016)
Reviewed-by: Duncan Laurie <dla...@chromium.org>
Commit-Queue: Stefan Reinauer <rein...@chromium.org>
Tested-by: Stefan Reinauer <rein...@chromium.org>

Reviewed-on: https://chromium-review.googlesource.com/203404
Reviewed-by: Stefan Reinauer <rein...@chromium.org>
Commit-Queue: Justin Tsai <Justi...@quantatw.com>
Tested-by: Justin Tsai <Justi...@quantatw.com>

---
M src/mainboard/google/tricky/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
Stefan Reinauer: Looks good to me, approved
Justin Tsai: Ready; Verified

diff --git a/src/mainboard/google/tricky/Kconfig
b/src/mainboard/google/tricky/Kconfig
index c41a1c9..33540f8 100644
--- a/src/mainboard/google/tricky/Kconfig
+++ b/src/mainboard/google/tricky/Kconfig
@@ -23,7 +23,7 @@

config VBOOT_RAMSTAGE_INDEX
hex
- default 0x2
+ default 0x1

config MAINBOARD_DIR
string

--
To view, visit https://chromium-review.googlesource.com/203404
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8c5a76ce4fbb7c8aeb6fa175b0546cd59ccfdeb
Gerrit-PatchSet: 2

Gerrit-Project: chromiumos/third_party/coreboot
Gerrit-Branch: firmware-tricky-5829.B
Gerrit-Owner: 世璋 蔡 <Justi...@quantatw.com>

Gerrit-Reviewer: Justin Tsai <Justi...@quantatw.com>
Gerrit-Reviewer: Stefan Reinauer <rein...@chromium.org>

Gerrit-Reviewer: chrome-internal-fetch <chrome-int...@google.com>