Hi chromium developers (especially on windows).
I just landed a
CL enabling a new clang flag "/Zc:dllexportInlines-" (
draft document) collaborating with chrome c++ toolchain team (
hans,
thakis and
rnk).
I hope this give windows developer better experience of faster edit and test cycles on windows.
But you may see linker error like
[97/1686] LINK net_unittests.exe
FAILED: net_unittests.exe
ninja -t msvc -e environment.x86 -- ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./net_unittests.exe /PDB:./net_unittests.exe.pdb @./net_unittests.exe.rsp
lld-link: error: undefined symbol: "bool __thiscall net::internal::ClientSocketPoolBaseHelper::Group::RequestWithHandleHasJobForTesting(class net::ClientSocketHandle const *) const" (?RequestWithHandleHasJobForTesting@Group@ClientSocketPoolBaseHelper@internal@net@@QBE_NPBVClientSocketHandle@4@@Z)
>>> referenced by obj/net/net_unittests/client_socket_pool_base_unittest.obj:("bool __thiscall net::internal::ClientSocketPoolBaseHelper::RequestInGroupWithHandleHasJobForTesting(class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> const &, class net::ClientSocketHandle const *) const" (?RequestInGroupWithHandleHasJobForTesting@ClientSocketPoolBaseHelper@internal@net@@QBE_NABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@PBVClientSocketHandle@3@@Z))
If you see this kind of error, please add export attribute to
the class (this is recommended, but not always work) or
function where the undefined symbol is defined.
Also if you see other strange behavior, please let me know.
Thanks, Takuto