chromium_presubmit

Thiago Farina

unread,

Jan 12, 2015, 10:07:43 PM1/12/15

to Chromium-dev, infr...@chromium.org

Why is being red right way we upload and try?

--

Thiago Farina

Lei Zhang

unread,

Jan 12, 2015, 10:23:41 PM1/12/15

to Thiago Farina, Chromium-dev, infr...@chromium.org

Due to https://code.google.com/p/chromium/issues/detail?id=431255 perhaps?

> --
> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev

Daniel Cheng

unread,

Jan 13, 2015, 12:45:30 AM1/13/15

to the...@chromium.org, Thiago Farina, Chromium-dev, infr...@chromium.org, Paweł Hajdan, Jr.

This came up last year during some of the recipe-based builder changes for Blink: https://groups.google.com/a/chromium.org/d/msg/blink-dev/5ArYZHC_QR8/8mXmLdTJfR0J

I don't know how this was resolved then; I just recall that one day, I stopped getting tryserver failures for missing LGTMs. Maybe Pawel will have some background.

Daniel

Paweł Hajdan, Jr.

unread,

Jan 13, 2015, 6:47:23 AM1/13/15

to Daniel Cheng, Lei Zhang, Thiago Farina, Chromium-dev, infr...@chromium.org

https://codereview.chromium.org/833243009/ (in review) should fix this.

Paweł

Reply all

Reply to author

Forward