PSA: python 2.7.5 getting near you soon on Windows

[Marc-Antoine Ruel]

[warning: crosspost]

If you are not using Windows; lucky you, you can skip this email.

As announced on chromium-dev and blink-dev, I'm updating the python version embedded in depot_tools for Windows to 2.7.5. After successful trial on chromium.win where I actively deleted depot_tools\python_bin (2.6), I'll go forward with the transition. I'll soon commit the CL that will switch the default to auto-upgrade unless DEPOT_TOOLS_PYTHON_275=0.

There is still some level of uncertainty where I may have revert if it breaks build slaves and only reapply after fixing. Let's consider the upgrade is a fatality, it's just a matter of hammering hard enough.

FAQ

Won't it kill buildbot slaves or other python processes currently running?

No, because it's adding it aside in depot_tools\python275_bin and leaving depot_tools\python_bin intact. It was necessary to not kill the buildbot slaves mid-build anyway. It's up to you to delete depot_tools\python_bin when you are fine with the upgrade.

Yo dawg, Y U SO SLOW?

First, it was somewhat tricky. For example, there were a few assumptions about depot_tools\python_bin sprinkled through the source code. Thanks to Michael Moss for catching one of the nastiest one. I'm also naturally slow. I also happen to work on other things that are actually fun to work on.

Can I assertIs already?

Not yet. I'll do a follow up when I think it's safe.

I have trouble downloading

It's updating the same way it used before. So make sure no http proxy gets in the way. You can also extract the zip at https://src.chromium.org/chrome/trunk/tools/third_party/python275_bin.zip manually into your depot_tools.

What's in the zip?

Look at python275_bin\README.chromium to get the steps used to reproduce the exact same zip. I'm just trying to save you the trouble.

I don't want your python package

Read the batch file, you'll see the check is simple: it looks if both "python275_bin" and "python.bat" exist. So make sure they exist.

Thanks,

M-A

[Marc-Antoine Ruel]

Roll out went relatively well taking in account how many assumptions crept in through the years.

Important problems surfaced:

• We hit a snag that is specific to 2.7.5 so I'm currently packaging 2.7.6 which was released 5 days ago. It will be rolled out but DEPOT_TOOLS_PYTHON_275=0 will still block the roll out, even if it will now be rolling out 2.7.6.
• It broke nacl_integration_tests (tracking bug). I'll going to have the chromium build slaves running nacl_integration_tests switch temporarily back to 2.6 and I removed nacl_integration_tests from the CQ.
• It broke the NaCl build (tracking bug). The build slaves were downgraded to 2.6 in the meantime.

In addition, an unrelated event severely cut my connectivity. Thanks to C# for help me out.

M-A

2013/11/13 Marc-Antoine Ruel <mar...@chromium.org>

[Marc-Antoine Ruel]

CL 73013003 has been committed. You are being auto-upgraded to 2.7.6.

We'll do investigation next week to confirm it fix the first bug, as confirming the fix is tricky. The other NaCl specific issues are being handled by NaCl folks.

Thanks,

M-A

2013/11/15 Marc-Antoine Ruel <mar...@chromium.org>

[Nico Weber]

It looks like nacl_integration_tests are red on the main waterfall due to this (looks like maybe https://code.google.com/p/chromium/issues/detail?id=319585 ?) The bug is marked "Pri-0" (which seems appropriate) but has no owner and is marked "Available". What's the plan here? Are we going to disable the test on the bots until this is resolved, or revert the python roll until this is resolved?

[Marc-Antoine Ruel]

I downgraded the two VMs to 2.6 and they are now green http://build.chromium.org/p/chromium.win/waterfall?builder=NaCl%20Tests%20(x86-32)&builder=NaCl%20Tests%20(x86-64)

I'm not personally working on making nacl_integration_tests green by being compatible with python 2.7. On the other hand, I decided against blocking the upgrade on that, for now. That decision can be revisited.

M-A

2013/11/17 Nico Weber <tha...@chromium.org>