Componentization wants YOU

128 views
Skip to first unread message

Colin Blundell

unread,
May 6, 2014, 9:03:36 AM5/6/14
to chromium-dev, Darin Fisher, b...@chromium.org
Hello Chromium engineers,

Would you like to enhance the maintainability and scalability of Chromium, gain broad exposure to the Chromium codebase, and aid the integration of the iOS port? The componentization team has the perfect opportunity for you!

The team has more work on our hands than we can handle on our lonesome at any given time. This work comes in all shapes and sizes -- anything from contributing CLs to helping burn down a bugtree to designing and executing a feature componentization -- and much of it can be done by any motivated Chromium engineer! If you're interested in getting involved, please contact me.

Best,

Colin 

Lei Zhang

unread,
May 7, 2014, 3:20:11 PM5/7/14
to blun...@chromium.org, chromium-dev, Darin Fisher, Ben Goodger (Google)
Is there a list of things that need componentizing? Some concrete
details might help others decide whether they would like to jump
onboard or not.
> --
> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev

Colin Blundell

unread,
May 8, 2014, 5:20:22 PM5/8/14
to Lei Zhang, Colin Blundell, chromium-dev, Darin Fisher, Ben Goodger (Google)
Hi all,

Yes, there is (now) such a list (thanks for the excellent suggestion, Lei)!

If you're interested in one of the features marked "Available", email me and we can discuss how best to proceed.

If you're interested in one of the features marked "Started", email me and the owner of the bug and we can likely find some work for you to contribute toward the feature's componentization.

Thanks,

Colin

Shezan Baig

unread,
May 8, 2014, 5:25:40 PM5/8/14
to blun...@chromium.org, Lei Zhang, chromium-dev, Darin Fisher, Ben Goodger (Google)
Hi Colin,

I don't see "chrome/browser/spellchecker" in that list.  Do you still plan to componentize spellchecking?

Thanks,
-shez-




To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.

Lei Zhang

unread,
May 8, 2014, 5:26:11 PM5/8/14
to Colin Blundell, chromium-dev, Darin Fisher, Ben Goodger (Google)
I was just thinking of writing it as C14N yesterday.

Colin Blundell

unread,
May 8, 2014, 5:34:34 PM5/8/14
to Shezan Baig, Colin Blundell, Lei Zhang, chromium-dev, Darin Fisher, Ben Goodger (Google)
Hi Shez,

No, spellchecker is not on the list at this point.

Best,

Colin

Ryo Hashimoto

unread,
May 9, 2014, 8:44:27 AM5/9/14
to blun...@chromium.org, Shezan Baig, Lei Zhang, chromium-dev, Darin Fisher, Ben Goodger (Google)
Hi Colin,

Thanks for sharing the task list.
IIUC, basically, componentizing a directory means moving as much code as possible from chrome/browser/foo/ to component/foo/, right?
Do we have some kind of guideline which helps developers decide which code to be moved to component/?

Colin Blundell

unread,
May 9, 2014, 9:04:10 AM5/9/14
to Ryo Hashimoto, Colin Blundell, Shezan Baig, Lei Zhang, chromium-dev, Darin Fisher, Ben Goodger (Google)
Hi Ryo,

That's basically correct; rather than "as much code as possible" I would say "the code that is not specific to the Chrome embedder." What we've used as a rough guideline is: Is the code used by the iOS port? If it is, then it almost certainly should be componentized. If it's not, it still *might* make sense for it to be componentized but the priority would be much lower. If you're interested in a feature for which componentization has not yet begun, the first step would be to talk to me and we can coordinate working through the design phase of the componentization.

I've also started a hotlist for bugs that are ripe for being tackled by any interested party. I will add to this hotlist over time as bugtrees get created for individual feature componentizations.

Best,

Colin

Colin Blundell

unread,
May 12, 2014, 10:28:08 AM5/12/14
to Colin Blundell, Ryo Hashimoto, Shezan Baig, Lei Zhang, chromium-dev, Darin Fisher, Ben Goodger (Google)
Hi all,

I have brought the Browser Components design doc and cookbook up-to-date to take iOS into account (notably, mentioning layered components) and to document the componentization process that I and my team use, which is different in some ways from the one that Jói's team had employed. If you're interested in componentization, start with those and let me know where there are holes to fill!

Thanks,

Colin

Ben Goodger (Google)

unread,
May 12, 2014, 10:36:19 AM5/12/14
to Colin Blundell, Ryo Hashimoto, Shezan Baig, Lei Zhang, chromium-dev, Darin Fisher, oshima
Another concrete example that relates to a subset of src/chrome code: is this code needed by any other module outside src/chrome, e.g. src/ash? Good examples are much of the code in src/chrome/browser/chromeos which could live in src/ash, src/ui/* or src/chromeos.

-Ben
Reply all
Reply to author
Forward
0 new messages