Can we use gyp --no-duplicate-basename-check?

[Matthew Dempsky]

I'm trying to add a library to third_party that contains both a Solver.cpp and Solver.cc file, and gyp complains thusly:

Updating projects from gyp files...

gyp: Duplicate basenames in sources section, see list above

static library /usr/local/google/home/mdempsky/crwd/src/third_party/stp/stp.gyp:stp#target has several files with the same basename:

  Solver: src/lib/Sat/cryptominisat2/Solver.cpp src/lib/Sat/minisat/core/Solver.cc

Some build systems, e.g. MSVC08 and Make generator for Mac, cannot handle that. Use --no-duplicate-basename-check todisable this validation.

Error: Command /usr/bin/python src/build/gyp_chromium returned non-zero exit status 1 in /usr/local/google/home/mdempsky/crwd

Hook '/usr/bin/python src/build/gyp_chromium' took 15.61 secs

Do we still care about MSVC08 or using Makefiles on Mac?  Are there any other supported platforms that can't handle multiple files with the same basename?  Can I just add --no-duplicate-basename-check to the gyp_chromium invocation in DEPS?

[Scott Graham]

Windows doesn't care any more. I'm not sure about Mac, or any other platforms that might happen to be unmentioned in that message, e.g. iOS.

If we decide to allow duplicate basenames, we should remove that code from gyp rather than adding the flag as the only reason it was there was for Chromium.

(A single third_party library really couldn't decide on file extension or non-ugly basenames within itself? o_O)

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev